From mboxrd@z Thu Jan 1 00:00:00 1970 From: gnurou@gmail.com (Alexandre Courbot) Date: Thu, 30 Jun 2016 15:04:22 +0900 Subject: [PATCH] arm64: tegra: Add missing Smaug revision In-Reply-To: <57738EC3.3070200@nvidia.com> References: <20160629085229.31350-1-acourbot@nvidia.com> <57738EC3.3070200@nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 29, 2016 at 6:02 PM, Jon Hunter wrote: > > On 29/06/16 09:52, Alexandre Courbot wrote: >> The "google,smaug-rev2" string is missing from the compatible list of >> Smaug's DT. The differences of rev2 are not relevant at our current >> level of support and it boots just fine, so add it. >> >> Signed-off-by: Alexandre Courbot >> --- >> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts >> index 431266a48e9c..82a96bd27bc8 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts >> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts >> @@ -11,7 +11,8 @@ >> compatible = "google,smaug-rev8", "google,smaug-rev7", >> "google,smaug-rev6", "google,smaug-rev5", >> "google,smaug-rev4", "google,smaug-rev3", >> - "google,smaug-rev1", "google,smaug", "nvidia,tegra210"; >> + "google,smaug-rev2", "google,smaug-rev1", >> + "google,smaug", "nvidia,tegra210"; >> >> aliases { >> serial0 = &uarta; > > Acked-by: Jon Hunter > > Olof, let us know if you have any comments on this? Looks like I missed > this initially because the rev2 support had been broken out in the > chrome-os kernel tree to support some specific features for this board. > However, I think for now it is ok to include rev2 here as well for mainline. This should be perfectly safe. If I run a diff between tegra210-smaug-p1.dts and tegra210-smaug-p2.dts in the ChromeOS tree, the only node that differs is sysedp-batmon-calc. The other node in these files (spiflash) is identical. Besides I don't think there are that many rev2s out there. :)