* [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on
@ 2015-06-08 7:41 Alexandre Courbot
2015-06-08 8:12 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2015-06-08 7:41 UTC (permalink / raw)
To: linux-arm-kernel
The wifi chip on roth needs to have its reset deasserted in order to be
probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
working at boot time.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
index ea1772a686c2..04762532a178 100644
--- a/arch/arm/boot/dts/tegra114-roth.dts
+++ b/arch/arm/boot/dts/tegra114-roth.dts
@@ -972,6 +972,11 @@
nvidia,invert-interrupt;
};
+ sdhci0_pwrseq: sdhci0_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
+ };
+
/* Wifi */
sdhci at 78000000 {
status = "okay";
@@ -979,6 +984,7 @@
broken-cd;
keep-power-in-suspend;
cap-sdio-irq;
+ mmc-pwrseq = <&sdhci0_pwrseq>;
};
/* SD card */
--
2.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on
2015-06-08 7:41 [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on Alexandre Courbot
@ 2015-06-08 8:12 ` Javier Martinez Canillas
2015-07-08 7:18 ` Alexandre Courbot
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-06-08 8:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello Alexandre,
On Mon, Jun 8, 2015 at 9:41 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> The wifi chip on roth needs to have its reset deasserted in order to be
> probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
> working at boot time.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
> index ea1772a686c2..04762532a178 100644
> --- a/arch/arm/boot/dts/tegra114-roth.dts
> +++ b/arch/arm/boot/dts/tegra114-roth.dts
> @@ -972,6 +972,11 @@
> nvidia,invert-interrupt;
> };
>
> + sdhci0_pwrseq: sdhci0_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> /* Wifi */
> sdhci at 78000000 {
> status = "okay";
> @@ -979,6 +984,7 @@
> broken-cd;
> keep-power-in-suspend;
> cap-sdio-irq;
> + mmc-pwrseq = <&sdhci0_pwrseq>;
> };
>
> /* SD card */
I'm neither familiar with this board nor have a schematic but the
patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on
2015-06-08 8:12 ` Javier Martinez Canillas
@ 2015-07-08 7:18 ` Alexandre Courbot
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2015-07-08 7:18 UTC (permalink / raw)
To: linux-arm-kernel
Ping Thierry, is this patch good to be merged?
On Mon, Jun 8, 2015 at 5:12 PM, Javier Martinez Canillas
<javier@dowhile0.org> wrote:
> Hello Alexandre,
>
> On Mon, Jun 8, 2015 at 9:41 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
>> The wifi chip on roth needs to have its reset deasserted in order to be
>> probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
>> working at boot time.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
>> index ea1772a686c2..04762532a178 100644
>> --- a/arch/arm/boot/dts/tegra114-roth.dts
>> +++ b/arch/arm/boot/dts/tegra114-roth.dts
>> @@ -972,6 +972,11 @@
>> nvidia,invert-interrupt;
>> };
>>
>> + sdhci0_pwrseq: sdhci0_pwrseq {
>> + compatible = "mmc-pwrseq-simple";
>> + reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
>> + };
>> +
>> /* Wifi */
>> sdhci at 78000000 {
>> status = "okay";
>> @@ -979,6 +984,7 @@
>> broken-cd;
>> keep-power-in-suspend;
>> cap-sdio-irq;
>> + mmc-pwrseq = <&sdhci0_pwrseq>;
>> };
>>
>> /* SD card */
>
> I'm neither familiar with this board nor have a schematic but the
> patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Best regards,
> Javier
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-08 7:41 [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on Alexandre Courbot
2015-06-08 8:12 ` Javier Martinez Canillas
2015-07-08 7:18 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).