linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gnurou@gmail.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 4/5] mfd: palmas: support IRQ inversion at the board level
Date: Thu, 10 Apr 2014 16:04:02 +0900	[thread overview]
Message-ID: <CAAVeFuJY67zdoHiZufxDbkaw=xt8YwxyDAwHW_T7UZeSOt35NA@mail.gmail.com> (raw)
In-Reply-To: <1393876300-3061-4-git-send-email-swarren@wwwdotorg.org>

Stephen, any news about this patch? I'm waiting for it to be merged in
order to resend some Tegra DTs, but still cannot see it in -next.

Thanks,
Alex.

On Tue, Mar 4, 2014 at 4:51 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Implement the new DT property ti,irq-externally-inverted, and add an
> equivalent platform data field to match. This allows the driver to
> correctly automatically configure the IRQ output polarity when the board
> or SoC contains an inverter between the Palmas IRQ output and IRQ
> controller input.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v3:
> * Use an IRQD flag to represent the data, rather than a custom DT property.
> v2:
> * Split V1's patch 1/2 into separate patches 1/3 and 2/3.
> ---
>  drivers/mfd/palmas.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index d280d789e55a..3281d4103e9d 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -292,7 +292,8 @@ static int palmas_set_pdata_irq_flag(struct i2c_client *i2c,
>                 return -EINVAL;
>         }
>
> -       pdata->irq_flags = irqd_get_trigger_type(irq_data);
> +       pdata->irq_flags = irqd_get_trigger_type(irq_data) |
> +                          irqd_get_src_dst_inverted(irq_data);
>         dev_info(&i2c->dev, "Irq flag is 0x%08x\n", pdata->irq_flags);
>         return 0;
>  }
> @@ -447,6 +448,8 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
>                 reg = PALMAS_POLARITY_CTRL_INT_POLARITY;
>         else
>                 reg = 0;
> +       if (pdata->irq_flags & IRQ_SRC_DST_INVERTED)
> +               reg ^= PALMAS_POLARITY_CTRL_INT_POLARITY;
>         ret = palmas_update_bits(palmas, PALMAS_PU_PD_OD_BASE,
>                         PALMAS_POLARITY_CTRL, PALMAS_POLARITY_CTRL_INT_POLARITY,
>                         reg);
> --
> 1.8.1.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-04-10  7:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 19:51 [PATCH V3 1/5] genirq: define flag IRQ_SRC_DST_INVERTED, and accessors Stephen Warren
2014-03-03 19:51 ` [PATCH V3 2/5] dt: define IRQ flags bit 4 as src/dst inversion Stephen Warren
2014-03-03 19:51 ` [PATCH V3 3/5] irqchip: gic: parse IRQ specifier flag " Stephen Warren
2014-03-03 19:51 ` [PATCH V3 4/5] mfd: palmas: support IRQ inversion at the board level Stephen Warren
2014-03-04  8:25   ` Lee Jones
2014-04-10  7:04   ` Alexandre Courbot [this message]
2014-04-10  7:25     ` Lee Jones
2014-04-10 15:42     ` Stephen Warren
2014-04-11  2:44       ` Alexandre Courbot
2014-03-03 19:51 ` [PATCH V3 5/5] ARM: tegra: fix Dalmore PMIC IRQ polarity Stephen Warren
2014-03-04 10:04 ` [PATCH V3 1/5] genirq: define flag IRQ_SRC_DST_INVERTED, and accessors Thomas Gleixner
2014-03-04 10:34   ` Thomas Gleixner
2014-03-04 15:57   ` Stephen Warren
2014-03-04 21:31     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAVeFuJY67zdoHiZufxDbkaw=xt8YwxyDAwHW_T7UZeSOt35NA@mail.gmail.com' \
    --to=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).