Re: [PATCH v3 11/27] KVM: arm64: Add missing HCR_EL2 trap bits

From: Jing Zhang <jingzhangos@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Eric Auger <eric.auger@redhat.com>,
	 Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	 Alexandru Elisei <alexandru.elisei@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	 Chase Conklin <chase.conklin@arm.com>,
	 Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
	 Darren Hart <darren@os.amperecomputing.com>,
	Miguel Luis <miguel.luis@oracle.com>,
	 James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	 Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v3 11/27] KVM: arm64: Add missing HCR_EL2 trap bits
Date: Fri, 11 Aug 2023 09:21:39 -0700	[thread overview]
Message-ID: <CAAdAUtj-5PeXCH3tzdFYogg94aBRd4k7sr8x9SWD793XeFBS9Q@mail.gmail.com> (raw)
In-Reply-To: <20230808114711.2013842-12-maz@kernel.org>

Hi Marc,

On Tue, Aug 8, 2023 at 4:48 AM Marc Zyngier <maz@kernel.org> wrote:
>
> We're still missing a handfull of HCR_EL2 trap bits. Add them.
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Reviewed-by: Miguel Luis <miguel.luis@oracle.com>
> ---
>  arch/arm64/include/asm/kvm_arm.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
> index 58e5eb27da68..028049b147df 100644
> --- a/arch/arm64/include/asm/kvm_arm.h
> +++ b/arch/arm64/include/asm/kvm_arm.h
> @@ -18,10 +18,19 @@
>  #define HCR_DCT                (UL(1) << 57)
>  #define HCR_ATA_SHIFT  56
>  #define HCR_ATA                (UL(1) << HCR_ATA_SHIFT)
> +#define HCR_TTLBOS     (UL(1) << 55)
> +#define HCR_TTLBIS     (UL(1) << 54)
> +#define HCR_ENSCXT     (UL(1) << 53)
> +#define HCR_TOCU       (UL(1) << 52)
>  #define HCR_AMVOFFEN   (UL(1) << 51)
> +#define HCR_TICAB      (UL(1) << 50)
>  #define HCR_TID4       (UL(1) << 49)
>  #define HCR_FIEN       (UL(1) << 47)
>  #define HCR_FWB                (UL(1) << 46)
> +#define HCR_NV2                (UL(1) << 45)
> +#define HCR_AT         (UL(1) << 44)
> +#define HCR_NV1                (UL(1) << 43)
> +#define HCR_NV         (UL(1) << 42)
>  #define HCR_API                (UL(1) << 41)
>  #define HCR_APK                (UL(1) << 40)
>  #define HCR_TEA                (UL(1) << 37)
> --
> 2.34.1
>
>

Reviewed-by: Jing Zhang <jingzhangos@google.com>

Jing

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel