From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F3FC433EF for ; Wed, 13 Jul 2022 05:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=15vM9bRGKvOxz9JDnDGtlPObxKb+8fI3TXsj6acXYLE=; b=lTFoO10EcyB/Z9 pITPMoz2r6WnPTYQuUL/d64j/6ElgXKxt1mQU2oi0wQLaapmBUoFWhN17iMXkRKgu9Br9HeuMlnlG t9KmfGSwWpYZ2JwU3OIni7tFSViYmnFQiLF4D0oE0Rw+xUc0PGD7gQiksdxeKlELoaPbgyzB2yZt1 x7+ZbvG9akX/AFmeLyr4edcw6XfaPtLYZdFM2HR5sA8o3LHLXtL/kC5ZtERo7hY9eZRDON7XfPhko BihFah2mvkVqnfrW83T851+SstafxNLMrZsqQJvnQ1HNpMqMcPhN5qxzzzPMLSrU+o6rrRQ/2QLEU 4tnXDCK1Tq+rszetnYew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBVHn-000MF9-Pi; Wed, 13 Jul 2022 05:51:47 +0000 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBVHj-000MCV-7t for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 05:51:44 +0000 Received: by mail-vs1-xe36.google.com with SMTP id 189so9844314vsh.2 for ; Tue, 12 Jul 2022 22:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V6DsLVB1Os/T467zl8XHHfVTC79R6u1QIg76nXthRf0=; b=X07y/aH0bERy3yMTWnhLUJfEU4C3NSMDvTZ2dqjIhvWFXrV5dn+isPnxxXf6wkY9EW Be45usNE+fO2CyTyVnM+8YL9iTkWOuR1dUeJ7u9M645jE4fgcP3ezP75uR+Jp9LaJ9xv P9fQjwoC69dhtrVRWBJHuki2xt6YhU0mQlaeruRXko32UKJfOY7GbC++VP9rhJZ8HMjI 9ZHlNheUJu5x92W2EPuum6PxktoSelq/+SKK2NHiDoPsW/MmpM00ePiXQQUsAAmwOwjO FuEhU454w2bVLRbpT28sMpGXdmHOR6JAJhrltMOraKg+W41dIRomFpqqpjo8Aanh7z6R jK/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V6DsLVB1Os/T467zl8XHHfVTC79R6u1QIg76nXthRf0=; b=ilGnJ75GYVfPgZrcxBeQzI/HM3P7aXE440y60969G6Xo+PgHsqksHn6LKn6oCXSj+I nityFwkfUPJtIIixEzCAxnJUS0IWUSKsJPf2uoRh48uT9s4PAColsi8kRpDp/GG7jjaM qkeF28EZhfE1CSorH6yDCOQMgZiao19i1cdGob2Pw1EvO7RVwP/IT1OK/3PrkThrxHye SwVRbVbrhasfRmPAxqUzdCmhN8aZzUREWawGzaDcr9vGPq4IuzMKr0KvguD4Bmsx9h3o pNdcvBIKMGQzZiTUnJLy/ztlWoPwr6izcxvbVbp4mlw8/H8SY9oPX8UC99ElHPFFAFAv sMqw== X-Gm-Message-State: AJIora+L7BuCdQdT+m45B7RswPJOmEpAcRFlv6KB+IRGYCs/MLquboT3 btBZoLcmvBiuqIFMqMmZsVBq6PodC9af/zgFnpS/bA== X-Google-Smtp-Source: AGRyM1vmw3DqET09DU69NtxLbHGCoiebSBcuxxz9079JWzLSn2pteanGKVgXbkE8PBhG6kBPfsnDc2/g7nxtlqiayyY= X-Received: by 2002:a67:5c41:0:b0:356:20ab:2f29 with SMTP id q62-20020a675c41000000b0035620ab2f29mr502511vsb.63.1657691501271; Tue, 12 Jul 2022 22:51:41 -0700 (PDT) MIME-Version: 1.0 References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-11-maz@kernel.org> In-Reply-To: <20220706164304.1582687-11-maz@kernel.org> From: Reiji Watanabe Date: Tue, 12 Jul 2022 22:51:25 -0700 Message-ID: Subject: Re: [PATCH 10/19] KVM: arm64: vgic-v3: Convert userspace accessors over to FIELD_GET/FIELD_PREP To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , Schspa Shi , kernel-team@android.com, Oliver Upton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_225143_296618_BFA1E6B0 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 6, 2022 at 10:05 AM Marc Zyngier wrote: > > The GICv3 userspace accessors are all about dealing with conversion > between fields from architectural registers and internal representations. > > However, and owing to the age of this code, the accessors use > a combination of shift/mask that is hard to read. It is nonetheless > easy to make it better by using the FIELD_{GET,PREP} macros that solely > rely on a mask. > > This results in somewhat nicer looking code, and is probably easier > to maintain. > > Signed-off-by: Marc Zyngier Reviewed-by: Reiji Watanabe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel