From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1341C433EF for ; Sat, 11 Jun 2022 18:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EwoUCF6ruQOmmTLb7gzSUxuK1RAOB8AvCNaQ/LsFGmQ=; b=v7UAgeJf9s9z/U ZPQtv834PaWNw8GfpzsAvKJKMfb6LrwCbQJWpbumttumERmyN1yUlv2N97PdV8ivLJ7kJF1igIh2u 9+BDlRug0U83CmrFAQdz4bMleCM4D2oB4/TooqVAdEkom6Te+TpjbUoMpnLTlubzKlTQedfeeqEhR qddPZtZm47dxQUTY76ncl1RsZ1n099dSs17FJJDDpkidlc/C4DTwcJmmn3w+80sBb2h1rFad4Rnpf enALIx+N0wuXs8oyczv7HDivepTMJGP+GBo1jPKjxKI6pnfAsXdR0kLTgRk+XOrlHF0NE4WPtSzXS /dztXx42EL6k520JzihQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o063Y-00EAgZ-Ta; Sat, 11 Jun 2022 18:41:57 +0000 Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o063W-00EAfX-Hu for linux-arm-kernel@lists.infradead.org; Sat, 11 Jun 2022 18:41:55 +0000 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-fe539f9afbso3303723fac.5 for ; Sat, 11 Jun 2022 11:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aGUj2LVLNGk5sOwR7+tKcU/mD91p7d7Dvbf7YRvu4qg=; b=rPFZGQ3gOLwesD2QG9IU7Z5ORHjifYdHd3M3rHmqO3uS3mAECeXs6WSr08jhHalONZ 00kH3g/6qwvm7Dxs4OZ+92EBsLjn+o7VUtqj90p3R3wmrgQ2eb8atHHvBtZZBrCW8++X kFVuv1Ot4n+8SKCcIx2n/ihi+/dBLMJD8UVXyxR68MluJYDarVW4aa25cfakTZv84r1J nn7YN7qw6zWnfq/+xGkexU0DFWnuoSdRk9EyoCt1b05nphByzWoPaWx2BZLAk18WZ0gs 5+qCnSeOw0GNdYe6zeodER3hcZKsS8SpAhSeNZnVC6+Hjz3AEQiwhzij2Jsh9TGn5hDx +E4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aGUj2LVLNGk5sOwR7+tKcU/mD91p7d7Dvbf7YRvu4qg=; b=gOlO1mKiEUU67blEgLDUGqgdiDgJN48ajrqqO9QuYE5A9Hnbez4II5/K4oFTXqgPhk AcmmSgrmSSdGFsKn/BVLtvuhrLrIX8uGy8nMBX7+ULnqdOSW5mzdkf/YXdMoRUtdwpTM Ypcaxh7SA5zPglPto4sEuf2QJLotLD5YcRqX7OXokBt28dHdfBcXSP+AWCpXv/skaeU2 cM2taZf7276tvhTZom6Yl0FVyNjZiVw2qqex0VhVByXKCw7N3MBb7SajWAUGRamAUKD7 1WmFcKJ9t7Z70jVFRifmAr5yGWXuuBvgXup2b5E55POXYoxGgvAbk24F0o6LdzMRUqxx 5StA== X-Gm-Message-State: AOAM533iSuOG5cg78IPJXuGvimJ2j7WyIQiQs2UHZbNKEdAdd1+RZUtv l3a1nHb/EaXMnMTvk4VJdcMD7tVo6Lt/sockkUKKAQ== X-Google-Smtp-Source: ABdhPJwBqvM9uOWilf/hZkJ/qSGvf+HPCw8ZzSqEItH5yaUmYPdRrrdg19+h1EH+Z84nEY0g6QaKN8589eW/COQRu1E= X-Received: by 2002:a05:6870:304b:b0:f2:d164:5c85 with SMTP id u11-20020a056870304b00b000f2d1645c85mr3138557oau.107.1654972913135; Sat, 11 Jun 2022 11:41:53 -0700 (PDT) MIME-Version: 1.0 References: <20220610092838.1205755-1-maz@kernel.org> <20220610092838.1205755-7-maz@kernel.org> In-Reply-To: <20220610092838.1205755-7-maz@kernel.org> From: Reiji Watanabe Date: Sat, 11 Jun 2022 11:41:37 -0700 Message-ID: Subject: Re: [PATCH v2 06/19] KVM: arm64: Add three sets of flags to the vcpu state To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , James Morse , Suzuki K Poulose , Alexandru Elisei , Oliver Upton , Will Deacon , Fuad Tabba , Quentin Perret , Mark Brown , kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220611_114154_647385_D71A94D3 X-CRM114-Status: GOOD ( 24.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 10, 2022 at 2:29 AM Marc Zyngier wrote: > > It so appears that each of the vcpu flags is really belonging to > one of three categories: > > - a configuration flag, set once and for all > - an input flag generated by the kernel for the hypervisor to use > - a state flag that is only for the kernel's own bookkeeping > > As we are going to split all the existing flags into these three > sets, introduce all three in one go. > > No functional change other than a bit of bloat... > > Reviewed-by: Fuad Tabba > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 6d30ac7e3164..af45320f247f 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -335,6 +335,15 @@ struct kvm_vcpu_arch { > /* Miscellaneous vcpu state flags */ > u64 flags; > > + /* Configuration flags, set once and for all before the vcpu can run */ > + u64 cflags; > + > + /* Input flags to the hypervisor code, potentially cleared after use */ > + u64 iflags; > + > + /* State flags for kernel bookkeeping, unused by the hypervisor code */ > + u64 sflags; Reviewed-by: Reiji Watanabe Thank you, those comments are more clear to me now. Thanks, Reiji > + > /* > * We maintain more than a single set of debug registers to support > * debugging the guest from the host and to maintain separate host and > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel