From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 641D6C433F5 for ; Tue, 23 Nov 2021 00:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+TyU7u1r9IDOreGEcEfEu7Vgfzk8xqk4K9P3w93lWLI=; b=EWbY74eNFiXlH2 KWzLDV1mKxfLlBCYnT64dpVWe2IrxRMI6KKYJMToFPR2TUlGBNGSMiE7T0VMLWJDNNu1Hus4fu+wK +faMHzTIe9I4R5PjKIzZuU4hwrTy6fsZC80c8wqH/Z8/xg4M0ta8ZAJsbgeg/ToUjgb/Niw/rYW59 SVoK2GRKJpqCD+xvi7LMjBNA5kzpyqhRyLNFJ+G0pmijF5T09gI3BZfFVQJtNKg7I19EykyAJ7OCq WyDckqhj8eJUeUn68Qel0ttxB2pzOuTKuIFiIKhmOSuTTXtei7o90WygyfTR8SbnsWnbRWHbsp2Rp CgU00N2dLWP+caFomkTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpK2a-000Yjt-AT; Tue, 23 Nov 2021 00:52:08 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpK2W-000YjD-H3 for linux-arm-kernel@lists.infradead.org; Tue, 23 Nov 2021 00:52:05 +0000 Received: by mail-pf1-x435.google.com with SMTP id x131so17663922pfc.12 for ; Mon, 22 Nov 2021 16:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U8wVUqAGerxKdyql8K3cQpZeIXWsZUSoHk+rQSQu8dQ=; b=lGN8M+8oQF0Hjs4njXU12qJ0QTEbrLTpdd9PGYmqJsG+hVHBDnY0wLf/3ow5s17ApQ 4p0nPHvvB49y+9AC6f3x7F9CqWBJW7GLmN42yml1mvQ5ItTxYmEtSugGIKSyAe/jLLKl j0qtH2g1/MkWlltsehxN3jKJyhXaGg85cNQaJEX5onIL59dJqtEjl7vJbvxzcWpAKBMf C07Tez1lwA1jq4p8ZoaP8CwwXJHAOIIC4F57STxdUDow6OVt0esTkiVGAuG9If4uZyOd H4YYvSM87+z6xufGwEmMFxTWljQDXtDoyKkS2FqS00upycbkwBAxMPy7KMeGtX+yGhCn i+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U8wVUqAGerxKdyql8K3cQpZeIXWsZUSoHk+rQSQu8dQ=; b=ZnTnB+DOGDRMEBDqAebLCdkkG8Vbp1B761AQ9Mx6dmhenaHWV6OVkTgpQcQBPwt8v4 PkabRw+Oqt0kT6nYeH94t4fTtmxuaSViPYE2wkRc2xdQf3/tBCYVvxDSDUdToulczv2H Kk9F1yd35vkoy0F+9lKw27x7Ou71sthyNuTnROH27Nw+mE3IwzrSLVinta7xoKlW9cyh w92nwGztdc5P5QirAyDi3QJ04GjKT44QUmXUZ1O/HnfslC2vgJe+y/QPSU0HteDExXLD IUWNOaYMT6z7tNUSOkz4UkIMaHbw2Bfy6WO08+x84ZVJJozN+exfp0PUMwrzM8np+XZ1 MDkg== X-Gm-Message-State: AOAM532xWlV3h0koqp5SOBOaNynoN3IFn+JDR2nFrU3jcFy4QTNQ9PUO VxOr/AzxtTvAzQ9yrGo7RQEOp+g7f+mMTr6JwURgXyYcSdg= X-Google-Smtp-Source: ABdhPJyubfAEVgA+QQrnFhtEtO0iS8FLlQEPm5gaAFwunjtCJUIDZnMl618fjlYHTqqeIy4H0Mr1zygLiMBuKOx1xWU= X-Received: by 2002:a63:6ec7:: with SMTP id j190mr855827pgc.395.1637628719955; Mon, 22 Nov 2021 16:51:59 -0800 (PST) MIME-Version: 1.0 References: <20211117064359.2362060-1-reijiw@google.com> <20211117064359.2362060-2-reijiw@google.com> <87mtlxsn1l.wl-maz@kernel.org> In-Reply-To: <87mtlxsn1l.wl-maz@kernel.org> From: Reiji Watanabe Date: Mon, 22 Nov 2021 16:51:44 -0800 Message-ID: Subject: Re: [RFC PATCH v3 01/29] KVM: arm64: Add has_reset_once flag for vcpu To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Will Deacon , Andrew Jones , Peng Liang , Peter Shier , Ricardo Koller , Oliver Upton , Jing Zhang , Raghavendra Rao Anata X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_165204_614505_93739576 X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 21, 2021 at 4:36 AM Marc Zyngier wrote: > > On Wed, 17 Nov 2021 06:43:31 +0000, > Reiji Watanabe wrote: > > > > Introduce 'has_reset_once' flag in kvm_vcpu_arch, which indicates > > if the vCPU reset has been done once, for later use. > > It would be nice if you could at least hint at what this flag is going > to be used for, as being able to reset a vcpu as often as userspace > wants it is part of the KVM ABI. I will update the description. > > Signed-off-by: Reiji Watanabe > > Reviewed-by: Oliver Upton > > --- > > arch/arm64/include/asm/kvm_host.h | 2 ++ > > arch/arm64/kvm/reset.c | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 2a5f7f38006f..edbe2cb21947 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -385,6 +385,7 @@ struct kvm_vcpu_arch { > > u64 last_steal; > > gpa_t base; > > } steal; > > + bool has_reset_once; > > Why can't this be a new flag (part of the vcpu->arch.flags set) rather > than a discrete bool? Thank you for the suggestion ! I will fix it to use vcpu->arch.flags. Regards, Reiji _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel