From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B672C433F5 for ; Thu, 10 Feb 2022 05:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lpi5h5VG4aeR59m8qk18gJqTGAZ5emumtpcyLXl7D1o=; b=KDptvMgbgN93t4 /50vvfklNMwEVifQiMWMYPo+0vUJwyQ+GslZ9bace/1Tej9p7XHy1ItOEtMauTfx/384IBufkuPCm FAl0/2zap8klf/0kk6pQIK43GkdIBUNNX+Qkq5drbbzdmzLFLHQw2KjINajsXTlNUCbIl80SjLZyT Oojnv4KEHq6OTjBBIgZ8x2SB5IZqMcLF4nDdrH4fLoTTvQ26OLhvKLpsF+gqEf/uUDOhthFAOYeAM WJQact6gylRuRUUeqn/tHSa0etV7kEcCMD8t/NEH8UBAa8dFdKGXGoQlAN10vOjXV8dRqF/+D3pqT 1VEO3bsDFeW8avNCO15g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI25d-002ck5-Pv; Thu, 10 Feb 2022 05:33:57 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI25b-002cjX-5H for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 05:33:56 +0000 Received: by mail-pl1-x629.google.com with SMTP id p6so699679plf.10 for ; Wed, 09 Feb 2022 21:33:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4S1PGlBITDbPfDHxEWfVav4BYHFT1sybX2IDUqfuWTQ=; b=isDaEpKYGvxkxAbKsHb9vCzaGtOkhUtqMKoKEgF+nkKbnZtS8+ac5cIFoVRR23suou GVcLttonHw8byyKbCHgqQ0YS8UDZ+WQkPQBf+7svOSZ7NojZkt3+H45Kl7kRIpSoawW2 hRgvESlJS+kiKrWMJBAracoDlptVNsidTAYCHcsrI8pvYmmg2WLY5MFCmbAnCkBo7uzI S1U25BcrPqOG04jupyggHGdQBLvFa05TvdYN8SZ87q3tEgqOhdx4okHKJRZ3g24uFoaJ BsmhtRgY0YthsOyByDn65K7Uz879V77+rlGFxz9XCkn116Pnb+3C3ElFjDZrZP0WTz2S +FSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4S1PGlBITDbPfDHxEWfVav4BYHFT1sybX2IDUqfuWTQ=; b=QSjCrdB63GilnblSxqZIl/GquByxurZv1J9IA9Wz54VIZwZC35f08AZ/7FP1EdEKI+ T9hzFDV73aO3zzzlXtVbtxlceeNMwXSkIOK/DCsr/rHL1cdKAu+UPRjg+ggKKuKd6v/+ vwSUncl3SsaU3WnojUDMeTJHeq5hGjRj3li1TLc75rdRuJ/HwdRHlLTKjMhDf2JMEfz9 PqN6vAGNCkR6nyorx4wT8Kdx4X54eFjBVZcE5BlXz1DTQ81l9eQ3cIcLFwwpfQ+3Si4P zLwKrXUleqNW4y0CmdysHqpWShFGW00ZQs+CMP7DM3pvSO4C8XikOUUCm7E9u6KTdpxu 8Fgw== X-Gm-Message-State: AOAM531SLOsyTgQvOOjfnToyw0QukQRbVXothGjpTgq+dtOo2JevkHRx Vk7UWyZyVregfRTh+j+H1AK9dv/N730BigtuIAhlfg== X-Google-Smtp-Source: ABdhPJyOYpAB/1KVlL9BpGn1hBcrVObh/j/ZODwkPJefZgNp7E9L6Xi+YRMLTn6dQNZAMk+w8rpZ0mbxDKUleu0QqeE= X-Received: by 2002:a17:90b:390a:: with SMTP id ob10mr1074103pjb.110.1644471234298; Wed, 09 Feb 2022 21:33:54 -0800 (PST) MIME-Version: 1.0 References: <20220106042708.2869332-1-reijiw@google.com> <20220106042708.2869332-5-reijiw@google.com> In-Reply-To: From: Reiji Watanabe Date: Wed, 9 Feb 2022 21:33:38 -0800 Message-ID: Subject: Re: [RFC PATCH v4 04/26] KVM: arm64: Make ID_AA64PFR0_EL1 writable To: Fuad Tabba Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Peter Shier , Paolo Bonzini , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_213355_226541_6155F949 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fuad, On Tue, Feb 1, 2022 at 6:14 AM Fuad Tabba wrote: > > Hi Reiji, > > ... > > > > > diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c > > > > index 0a06d0648970..28d9bf0e178c 100644 > > > > --- a/arch/arm64/kvm/vgic/vgic-init.c > > > > +++ b/arch/arm64/kvm/vgic/vgic-init.c > > > > @@ -116,6 +116,11 @@ int kvm_vgic_create(struct kvm *kvm, u32 type) > > > > else > > > > INIT_LIST_HEAD(&kvm->arch.vgic.rd_regions); > > > > > > > > + if (type == KVM_DEV_TYPE_ARM_VGIC_V3) > > > > + /* Set ID_AA64PFR0_EL1.GIC to 1 */ > > > > + (void)kvm_set_id_reg_feature(kvm, SYS_ID_AA64PFR0_EL1, > > > > + ID_AA64PFR0_GIC3, ID_AA64PFR0_GIC_SHIFT); > > > > + > > > > > > If this fails wouldn't it be better to return the error? > > > > This should never fail because kvm_vgic_create() prevents > > userspace from running the first KVM_RUN for any vCPUs > > while it calls kvm_set_id_reg_feature(). > > So, I am thinking of adding WARN_ON_ONCE() for the return value > > rather than adding an unnecessary error handling. > > Consider this to be a nit from my part, as I don't have any strong > feelings about this, but kvm_vgic_create() already returns an error if > there's a problem. So I don't think that that would be imposing any > additional error handling. That's true. But, since this failure case cannot be caused by userspace (but KVM's bug), I would still prefer using WARN_ON_ONCE. Thanks, Reiji _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel