From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Oliver Upton <oupton@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>
Subject: Re: [PATCH v2 1/2] KVM: arm64: mixed-width check should be skipped for uninitialized vCPUs
Date: Thu, 10 Feb 2022 21:04:14 -0800 [thread overview]
Message-ID: <CAAeT=FzGP6jcsDbhZsNZVCUib8UQ4zc+y6s0TrsaKjAKx9WSWg@mail.gmail.com> (raw)
In-Reply-To: <87wni33td7.wl-maz@kernel.org>
Hi Marc,
> > > Also, we really should turn all these various bits in the kvm struct
> > > into a set of flags. I have a patch posted there[1] for this, feel
> > > free to pick it up.
> >
> > Thank you for the suggestion. But, kvm->arch.el1_reg_width is not
> > a binary because it needs to indicate an uninitialized state. So, it
> > won't fit perfectly with kvm->arch.flags, which is introduced by [1]
> > as it is. Of course it's feasible by using 2 bits of the flags though...
>
> 2 bits is what I had in mind (one bit to indicate that it has already
> been initialised, another to carry the actual width).
Understood. Then, I will take the patch and will work on v3.
Thank you for all the comments!
Regards,
Reiji
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-02-11 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 4:19 [PATCH v2 1/2] KVM: arm64: mixed-width check should be skipped for uninitialized vCPUs Reiji Watanabe
2022-01-18 4:19 ` [PATCH v2 2/2] KVM: arm64: selftests: Introduce vcpu_width_config Reiji Watanabe
2022-02-08 14:41 ` [PATCH v2 1/2] KVM: arm64: mixed-width check should be skipped for uninitialized vCPUs Marc Zyngier
2022-02-09 5:32 ` Reiji Watanabe
2022-02-09 12:04 ` Marc Zyngier
2022-02-10 5:31 ` Reiji Watanabe
2022-02-10 10:31 ` Marc Zyngier
2022-02-11 5:04 ` Reiji Watanabe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeT=FzGP6jcsDbhZsNZVCUib8UQ4zc+y6s0TrsaKjAKx9WSWg@mail.gmail.com' \
--to=reijiw@google.com \
--cc=alexandru.elisei@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rananta@google.com \
--cc=ricarkol@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).