From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BDADC433EF for ; Fri, 11 Feb 2022 05:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=42XT2K8cudgsHw0jjhrgCXROt+OnCZ8MOFcvYTXkJJg=; b=iQmVeIu83fFp1e +4G6rqOOIZSvtfkVUCekDmvv/MPWBp88fG8Idrwf4RCHQmI3jxE3yfBeMBvlNECv45M94I5ZM+q7A s5UlR/UIwuhNnw2PtlU5t9U5k2x0h1QJsw1+rVqQDYD07UXnGmZRMCCzI4Y0jdQ8CW77XlXww/Cwd Zgp1WZE7cpikcVyebKwRpwDvRNksCoq9Nsi3RWBg7duK61L3vtkoa1Yi9JJsogqMirjPsrztYgJ4e RJzVFACFusTkoBYp5ky72k6WyfAT6hZ8SHa3fcgFUadaILl5viQ91XC/bAHCBLx5YkUNeCvLpfhSn pxUQHogQ21ETk2nsCCfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIO6o-005qRL-My; Fri, 11 Feb 2022 05:04:38 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIO6l-005qQY-Eg for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 05:04:37 +0000 Received: by mail-pl1-x633.google.com with SMTP id w1so3751845plb.6 for ; Thu, 10 Feb 2022 21:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hafp+SZmlpr9AIwlLC0AjbdundomKkMQTM3i7h5hOko=; b=HEmqti9TBXPB3AgN69donMmH29Y5xqziF2WLDQcCD96zK0fU5P6wypu/8lgYF25myR di+zV3FTrLjipVxiPY3X97CT5YE0pRdBQxNXOuSNGi/8pzZeZYIlHFcCB5Hlm0Q9FWSm qnuH2jYgA9ahhyiMcZ7St/2u2UiHo17yD9ZKPYWJFtj72/Vu26fHu6/3PGqB32j481UI Z3isYpTw7Hcq35PSpqRSkqualueaMF/Kfv9Mx5P4VYlO5OgpNLs+GQqoE8okm9BHvjPx YlSuNiDxiaWm5eDr7gcCdbpie6pq/crRlk5RMcnwa/TJwY+A2h0HoD/jPoeOzspyyeNb LUFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hafp+SZmlpr9AIwlLC0AjbdundomKkMQTM3i7h5hOko=; b=zTl8HzWfyUUy52sjecBtUvzkTxp+6o8VEKE4CkNugM/ShO6oYe4z1TNhMNLuvfwSgy 7ETadptib02+w1D1PicRqi4GXrC2SKbhjN8EGplAQbxpydjcUP6ilAvwT84OmBX6yV2l sNJFCOZZnI+RgEHfPYbMk+IpMMgKuNLVMyOhIdSTc80XksRzKVFkKl2A6KSRcXI6BCLK JA3mGnzZWmWYbv0SAl2K81upQLsyslc+HDvhGvp2TBjyrYlyqOIiWHnJBAcbaCQ1J7u2 Tdcl76LGk+LAIWcvW7G+e2e7+eMpuI3bUFbnxJnaCNFQIjXLY/b30IAiQMntwCwe9XpR 4gyw== X-Gm-Message-State: AOAM5321ZrU8JFmuSmPVDXWZWm+lacjTc3RfcoEpgpiR5+buzR3dnNfY 8LeWtxiSfiuyQtp12rvkM1+8CywmN4rPUrpLDoUAgA== X-Google-Smtp-Source: ABdhPJxVpz+4mZJs01nTXHzISx4FfZlba+M0gcEsKqH63dBrGFwxdQMBlt246gsdjFdx9ihmmFqnpFYoybH0AaYSP78= X-Received: by 2002:a17:90b:3c6:: with SMTP id go6mr912970pjb.230.1644555870192; Thu, 10 Feb 2022 21:04:30 -0800 (PST) MIME-Version: 1.0 References: <20220118041923.3384602-1-reijiw@google.com> <87a6f15skj.wl-maz@kernel.org> <875ypo5jqi.wl-maz@kernel.org> <87wni33td7.wl-maz@kernel.org> In-Reply-To: <87wni33td7.wl-maz@kernel.org> From: Reiji Watanabe Date: Thu, 10 Feb 2022 21:04:14 -0800 Message-ID: Subject: Re: [PATCH v2 1/2] KVM: arm64: mixed-width check should be skipped for uninitialized vCPUs To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Jing Zhang , Raghavendra Rao Anata X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_210435_499789_7F33E693 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, > > > Also, we really should turn all these various bits in the kvm struct > > > into a set of flags. I have a patch posted there[1] for this, feel > > > free to pick it up. > > > > Thank you for the suggestion. But, kvm->arch.el1_reg_width is not > > a binary because it needs to indicate an uninitialized state. So, it > > won't fit perfectly with kvm->arch.flags, which is introduced by [1] > > as it is. Of course it's feasible by using 2 bits of the flags though... > > 2 bits is what I had in mind (one bit to indicate that it has already > been initialised, another to carry the actual width). Understood. Then, I will take the patch and will work on v3. Thank you for all the comments! Regards, Reiji _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel