From: padma.kvr@gmail.com (Padma Venkat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/4] DMA: PL330: Modify pl330 filter based on new generic dma dt bindings.
Date: Mon, 4 Feb 2013 10:51:29 +0530 [thread overview]
Message-ID: <CAAgF-BdfwpOSyrGccs+xepZqMix4q1GRLSAgDnx2NxNTq+MNxA@mail.gmail.com> (raw)
In-Reply-To: <1692358.6BmDsJsb25@wuerfel>
On Sat, Feb 2, 2013 at 8:39 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 02 February 2013 08:00:54 Padma Venkat wrote:
>
>> > The result of this looks good, but I fear that changing the filter function
>> > like this wil break all drivers that currently use the plat-samsung/dma-ops.c
>> > code. For migration purposes, I think the best way is to change
>> > samsung_dmadev_request() to match the new filter_param format.
>> >
>> > After that is done, you can migrate all the drivers using samsung_dma_get_ops
>> > over to the new dma_request_slave_channel interface without breaking
>> > anything when only part of the series is applied.
>> >
>> > Arnd
>>
>> Please check the below link where I made the dma request compatible to
>> both DT and non-DT
>>
>> http://git.kernel.org/?p=linux/kernel/git/broonie/sound.git;a=commit;h=e7ba5f1d0f6292e1b99c63cc4bb74c70232e9065
>> http://git.kernel.org/?p=linux/kernel/git/broonie/sound.git;a=commit;h=b5be04d35dbb2e00ab27a97bfd26e17019e857ef
>>
>> Please let me know if any changes required.
>>
>
> Those two changes by themselves still look ok, I think but you
> still break the non-DT case in this 4/4 patch by changing the
> pl330_filter function in an incompatible way. You will still
> have to either change the filter_param argument in the
> samsung_dmadev_request() function, or provide separate filter
> functions, one to be used by samsung_dmadev_request and
> one for the pl330_xlate function.
I missed out to delete this part. Thanks for your point. I will send
another patch.
>
> In the long run, I think it would be better to move the slave
> drivers away from the samsung_dma wrappers and use
> dma_request_slave_channel directly, but that is an independent
> discussion.
>
> Arnd
Regards
Padma
prev parent reply other threads:[~2013-02-04 5:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 12:51 [PATCH V2 0/4] Add generic DMA DT binding support Padmavathi Venna
2013-02-01 12:51 ` [PATCH V2 1/4] DMA: PL330: Add xlate function Padmavathi Venna
2013-02-01 14:57 ` Arnd Bergmann
2013-02-01 12:51 ` [PATCH V2 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers Padmavathi Venna
2013-02-01 14:58 ` Arnd Bergmann
2013-02-01 12:51 ` [PATCH V2 3/4] ARM: dts: Add #dma-cells for generic dma binding support Padmavathi Venna
2013-02-01 15:16 ` Arnd Bergmann
2013-02-01 12:51 ` [PATCH V2 4/4] DMA: PL330: Modify pl330 filter based on new generic dma dt bindings Padmavathi Venna
2013-02-01 15:23 ` Arnd Bergmann
2013-02-02 2:30 ` Padma Venkat
2013-02-02 15:09 ` Arnd Bergmann
2013-02-04 5:21 ` Padma Venkat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAgF-BdfwpOSyrGccs+xepZqMix4q1GRLSAgDnx2NxNTq+MNxA@mail.gmail.com \
--to=padma.kvr@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).