* [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp
@ 2015-08-12 14:22 Mike Looijmans
2015-08-12 16:27 ` Moritz Fischer
2015-08-25 14:22 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Mike Looijmans @ 2015-08-12 14:22 UTC (permalink / raw)
To: linux-arm-kernel
Group names should be smc0_nand_grp and smc0_nor_grp, otherwise you'll
get errors like this if you try to pinmux them via the devicetree:
zynq-pinctrl 700.pinctrl: invalid group "smc0_nand_grp" for function "smc0_nand"
Probably a typo while creating these tables.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Acked-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
---
drivers/pinctrl/pinctrl-zynq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index 7ce23b6..5aafea8 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -706,10 +706,10 @@ static const char * const sdio1_wp_groups[] = {"gpio0_0_grp",
"gpio0_39_grp", "gpio0_41_grp", "gpio0_43_grp",
"gpio0_45_grp", "gpio0_47_grp", "gpio0_49_grp",
"gpio0_51_grp", "gpio0_53_grp", "sdio1_emio_wp_grp"};
-static const char * const smc0_nor_groups[] = {"smc0_nor"};
+static const char * const smc0_nor_groups[] = {"smc0_nor_grp"};
static const char * const smc0_nor_cs1_groups[] = {"smc0_nor_cs1_grp"};
static const char * const smc0_nor_addr25_groups[] = {"smc0_nor_addr25_grp"};
-static const char * const smc0_nand_groups[] = {"smc0_nand"};
+static const char * const smc0_nand_groups[] = {"smc0_nand_grp"};
static const char * const can0_groups[] = {"can0_0_grp", "can0_1_grp",
"can0_2_grp", "can0_3_grp", "can0_4_grp", "can0_5_grp",
"can0_6_grp", "can0_7_grp", "can0_8_grp", "can0_9_grp",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp
2015-08-12 14:22 [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp Mike Looijmans
@ 2015-08-12 16:27 ` Moritz Fischer
2015-08-25 14:22 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2015-08-12 16:27 UTC (permalink / raw)
To: linux-arm-kernel
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
On Wed, Aug 12, 2015 at 7:22 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> Group names should be smc0_nand_grp and smc0_nor_grp, otherwise you'll
> get errors like this if you try to pinmux them via the devicetree:
> zynq-pinctrl 700.pinctrl: invalid group "smc0_nand_grp" for function "smc0_nand"
>
> Probably a typo while creating these tables.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> Acked-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> drivers/pinctrl/pinctrl-zynq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index 7ce23b6..5aafea8 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -706,10 +706,10 @@ static const char * const sdio1_wp_groups[] = {"gpio0_0_grp",
> "gpio0_39_grp", "gpio0_41_grp", "gpio0_43_grp",
> "gpio0_45_grp", "gpio0_47_grp", "gpio0_49_grp",
> "gpio0_51_grp", "gpio0_53_grp", "sdio1_emio_wp_grp"};
> -static const char * const smc0_nor_groups[] = {"smc0_nor"};
> +static const char * const smc0_nor_groups[] = {"smc0_nor_grp"};
> static const char * const smc0_nor_cs1_groups[] = {"smc0_nor_cs1_grp"};
> static const char * const smc0_nor_addr25_groups[] = {"smc0_nor_addr25_grp"};
> -static const char * const smc0_nand_groups[] = {"smc0_nand"};
> +static const char * const smc0_nand_groups[] = {"smc0_nand_grp"};
> static const char * const can0_groups[] = {"can0_0_grp", "can0_1_grp",
> "can0_2_grp", "can0_3_grp", "can0_4_grp", "can0_5_grp",
> "can0_6_grp", "can0_7_grp", "can0_8_grp", "can0_9_grp",
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp
2015-08-12 14:22 [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp Mike Looijmans
2015-08-12 16:27 ` Moritz Fischer
@ 2015-08-25 14:22 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-08-25 14:22 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 12, 2015 at 4:22 PM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> Group names should be smc0_nand_grp and smc0_nor_grp, otherwise you'll
> get errors like this if you try to pinmux them via the devicetree:
> zynq-pinctrl 700.pinctrl: invalid group "smc0_nand_grp" for function "smc0_nand"
>
> Probably a typo while creating these tables.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> Acked-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
Patch applied with Moritz' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-25 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 14:22 [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp Mike Looijmans
2015-08-12 16:27 ` Moritz Fischer
2015-08-25 14:22 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).