From mboxrd@z Thu Jan 1 00:00:00 1970 From: eliad@wizery.com (Eliad Peller) Date: Tue, 17 Mar 2015 08:58:50 +0200 Subject: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data In-Reply-To: <20150316182426.GW5264@atomide.com> References: <1426162154-8716-1-git-send-email-eliad@wizery.com> <20150313151301.GJ5264@atomide.com> <2070859.WcMooC33YH@wuerfel> <20150316152939.GP5264@atomide.com> <20150316182536.GA16829@earth> <20150316182426.GW5264@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 16, 2015 at 8:24 PM, Tony Lindgren wrote: > * Sebastian Reichel [150316 11:26]: >> Hi, >> >> On Mon, Mar 16, 2015 at 08:29:39AM -0700, Tony Lindgren wrote: >> > * Arnd Bergmann [150315 05:10]: >> > > On Sunday 15 March 2015 10:50:42 Eliad Peller wrote: >> > > > yeah, i missed it :/ >> > > > >> > > > looks like there's no platform that defines platform data for it. >> > > > i'll replace the dev_get_platdata() with a function that only parses >> > > > the clock-frequency properties (the irq is taken in this case from the >> > > > spi_device). >> > > > (or maybe i should just drop it, as no one actually uses it?) >> > > >> > > I don't think we should drop the driver, but dropping the platform_data >> > > support sounds reasonable. New users of this driver should all be using >> > > DT, and if there is a good reason to use platform_data, it's easily >> > > put back. >> > >> > Well we have n8x0 and n900 using the spi driver. For those, n8x0 boot >> > all in dts mode, but n900 still also boots in legacy mode. It seems the >> > board-rx51-peripherals.c only passes the power_gpio though, so that >> > should be easy to keep around. >> > >> > We should keep things still working for n900 in legacy mode until the >> > pending regressions with device tree based booting have been cleared >> > for at least one merge cycle. I believe the last pending issues is the >> > support for ATAG_REVISION in device tree mode as posted by Pali. >> >> mh by migrating to newer gpiod interface platform data is no longer >> needed (instead the boardfile would need a gpiod_lookup_table). That >> way all of the dirty code is in the board file and will be removed >> once the time comes. See for example rx51_fmtx_gpios_table. >> >> Note: This is independent of wl12xx changes, since N900 uses wl1251. > > Oh sorry yes sounds like that's different platform data then. In that > case I see no reasons to drop the platform data for wl12xx. > great. so i'll drop the relevant wlcore_spi platform data code, and rebase the patches on top of v4.0-rc4 (probably tomorrow). Eliad.