linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: groeck@google.com (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399
Date: Thu, 23 Jun 2016 14:47:18 -0700	[thread overview]
Message-ID: <CABXOdTcZ2O7tK8yNSJH_Unap8RweUa_iW8aT3Hb_NWCZRoyAzQ@mail.gmail.com> (raw)
In-Reply-To: <1466686264-6744-4-git-send-email-zyw@rock-chips.com>

Hi Chris,

On Thu, Jun 23, 2016 at 5:51 AM, Chris Zhong <zyw@rock-chips.com> wrote:
> Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB
> Type-C PHY is designed to support the USB3 and DP applications. The
> PHY basically has two main components: USB3 and DisplyPort. USB3
> operates in SuperSpeed mode and the DP can operate at RBR, HBR and
> HBR2 data rates.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>
[ ... ]

> +
> +static void tcphy_get_state(struct rockchip_typec_phy *tcphy,
> +                           struct extcon_dev *edev)
> +{
> +       int mode;
> +       bool plugged, flip, pin_assign, dfp, ufp, dp;
> +
> +       ufp = extcon_get_cable_state_(edev, EXTCON_USB);
> +       dfp = extcon_get_cable_state_(edev, EXTCON_USB_HOST);
> +       dp = extcon_get_cable_state_(edev, EXTCON_DISP_DP);
> +       flip = extcon_get_cable_state_(edev, EXTCON_TYPEC_POLARITY);
> +       pin_assign = extcon_get_cable_state_(edev, EXTCON_TYPEC_PIN_ASSIGN);
> +
> +       plugged = ufp | dfp | dp;
> +       tcphy->flip = flip;
> +
> +       if (plugged) {
> +               if (ufp) {
> +                       mode = MODE_UFP_USB;
> +               } else if (dfp && !dp) {
> +                       mode = MODE_DFP_USB;
> +               } else if (dfp && dp) {
> +                       mode = MODE_DFP_USB | MODE_DFP_DP;
> +                       tcphy->pin_assign = pin_assign ? PIN_MAP_D : PIN_MAP_B;
> +               } else {
> +                       mode = MODE_DFP_DP;
> +                       tcphy->pin_assign = pin_assign ? PIN_MAP_C : PIN_MAP_A;

I am having trouble extracting pin_assign from our code. What
determines if map A or C should be selected ?

Thanks,
Guenter

  parent reply	other threads:[~2016-06-23 21:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 12:50 [v3 PATCH 0/5] Rockchip Type-C and DispplayPort driver Chris Zhong
2016-06-23 12:51 ` [v3 PATCH 2/5] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY Chris Zhong
2016-06-24 19:19   ` Rob Herring
2016-06-23 12:51 ` [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong
2016-06-23 12:57   ` Kishon Vijay Abraham I
2016-06-24 19:39     ` Heiko Stuebner
2016-06-27  2:19       ` Chris Zhong
2016-06-27  4:01         ` Guenter Roeck
2016-06-27  4:39           ` Chris Zhong
2016-06-23 17:23   ` Guenter Roeck
2016-06-23 21:47   ` Guenter Roeck [this message]
2016-06-24  0:34     ` Chris Zhong
2016-06-24  2:10       ` Guenter Roeck
2016-06-24  2:48         ` Chris Zhong
2016-06-23 12:51 ` [v3 PATCH 4/5] Documentation: bindings: add dt documentation for cdn DP controller Chris Zhong
2016-06-24 19:20   ` Rob Herring
2016-06-23 12:51 ` [v3 PATCH 5/5] drm/rockchip: cdn-dp: add cdn DP support for rk3399 Chris Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABXOdTcZ2O7tK8yNSJH_Unap8RweUa_iW8aT3Hb_NWCZRoyAzQ@mail.gmail.com \
    --to=groeck@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).