From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E041C47082 for ; Mon, 7 Jun 2021 04:16:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21026611C2 for ; Mon, 7 Jun 2021 04:16:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21026611C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=izKC1swdW0wwG8ADpjhfxKnBLWtaOfUMeMWIYo1mIoU=; b=nLdRI4INABxzMt DwQGjpxLt2MVgYeA6EXaiGQoW3qOTjYaEV94XGMWSxoIPpH77G1RfKbDi0Zn/GQbDNUhwWxx+tz+i t43hCAGvlkmczQEagcfE/RKLf/XKHuHVnqVGwmXXCqCCGlMp/rFiJ3e+jTBttPbCXGyg8GNSjdszR ob++Fl14iJaKboQeFoX3Ne85tyca18S4ecQ13wBFSACQCkApBVytNOIrxAt/uEJ7UZokcwlsTd0CN lMA51b1vS2D4X1pKMGgXsg0qVN7XMQJcEt2bmGx9958Cioe6bjQJITPco6MhzUd9n0Bq09KmQwdxz 824stJc5jbuWPMrYm5rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lq6d7-001SNi-3c; Mon, 07 Jun 2021 04:12:49 +0000 Received: from mail-qk1-f173.google.com ([209.85.222.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lq6d1-001SMd-CU for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 04:12:47 +0000 Received: by mail-qk1-f173.google.com with SMTP id j184so15460056qkd.6 for ; Sun, 06 Jun 2021 21:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hbR25Ey1jYTS5sXaXKkm7NsaVYIVVD2EtITwUZt+jv4=; b=eKsNiSwDdQrxODDTUtuA3Uy1ZOpjV0TNA6OQVCt8it1vcmDzH4pXSHCslNNVdqQs6H gtXvbWVWqX3fhQ1IQVbXQICfR06Wd1oOm/RbPoR3y5haOeOC1BV0Wc7q6mzp77VZxTyJ G/XG14v1FeXw9YdIv+tixboAv/PzlMASCV8FM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hbR25Ey1jYTS5sXaXKkm7NsaVYIVVD2EtITwUZt+jv4=; b=A5oNYrZo8mzA+uBgMiqveSRM3xES8nlf6yJDWYPrybQZKSbbpOgXZ2ebUX773GCBjD CaxJ59WT0ureeSktonuwGJPT3PMftCI/F5SPBCVxTXmuAfgug8kTsC6fEG8fH5bdzcpT hUtf14+6C/UWwBnS88r8QQF1bL8iamq5zO7CFd2nFyhy145Ika0RyDS35B6pcgSrlDBV oIRpPMErI5YtDjF9lIf10OWofgHDpb4cqjrzAEPsIXs8GCJPWWd723OUuN/xOWXWCDeU B7XmnhIDvPJN2Mc0pl7QUVGC9VKSUYLglcTA2M3G4OtucARfcJdrP7DNOghSOLAfvrQa dvvw== X-Gm-Message-State: AOAM5318jvjNseVJCfst7kHo7xNRopnQgHYFVbVs9dfxlE+Rs/YP/6uA L62/ba6SVRyjweUtC8ZgDydOCUectUCDP6AEgnA= X-Google-Smtp-Source: ABdhPJww3/VFgYyaDmLGX7xYSKpphZ34RO5B4B8KHOZzHIN6EN/Za5WTmJybfY+OvXChMMKumHsWj9EEfDRLcB/9Xp0= X-Received: by 2002:a37:b404:: with SMTP id d4mr3459096qkf.465.1623039100241; Sun, 06 Jun 2021 21:11:40 -0700 (PDT) MIME-Version: 1.0 References: <20210607013020.85885-1-andrew@aj.id.au> In-Reply-To: <20210607013020.85885-1-andrew@aj.id.au> From: Joel Stanley Date: Mon, 7 Jun 2021 04:11:28 +0000 Message-ID: Subject: Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning To: Andrew Jeffery Cc: linux-mmc , Adrian Hunter , Ulf Hansson , linux-aspeed , Linux ARM , Linux Kernel Mailing List , Steven Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210606_211243_451538_1C444C25 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 7 Jun 2021 at 01:30, Andrew Jeffery wrote: > > The card timing and the bus frequency are not changed atomically with > respect to calls to the set_clock() callback in the driver. The result > is the driver sees a transient state where there's a mismatch between > the two and thus the inputs to the phase correction calculation > formula are garbage. > > Switch from dev_warn() to dev_dbg() to avoid noise in the normal case, > though the change does make bad configurations less likely to be > noticed. > > Reported-by: Joel Stanley > Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley > --- > drivers/mmc/host/sdhci-of-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c > index d001c51074a0..e4665a438ec5 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed.c > +++ b/drivers/mmc/host/sdhci-of-aspeed.c > @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz, > > tap = div_u64(phase_period_ps, prop_delay_ps); > if (tap > ASPEED_SDHCI_NR_TAPS) { > - dev_warn(dev, > + dev_dbg(dev, > "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n", > tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS); > tap = ASPEED_SDHCI_NR_TAPS; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel