From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B834C433FF for ; Fri, 2 Aug 2019 05:51:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 318CC2073D for ; Fri, 2 Aug 2019 05:51:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T78TmHTC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="ZlXyZ6zt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 318CC2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HpoZLJ9lzALyF+6jyNUBMGGlmfmKY8Ni7vYm/1bvDXI=; b=T78TmHTCZt0vDx yjI/TRwG1l6xNkF9OejdouZJq9soXX75bAY9gH7Qq2Hu+Q3bc2J03AshDueG8i3Rlvhclyi2On8Ps 3h/3IsVifv9zR1yKJXl5piByeHvSmJH9G0oObDPkeUBCnywMgrJGhB47GXYrUuWDf8gVzwkHsl6oh jxmprwxJtCa1bxxysYg/apjbB1BR7yA6jo6X4VJMzuYdwqPRrj6xgPCI23PvJ9c0pMnLb2utchEGw 1F9WY5uVo7M04nfnGFjV1Y5+Ph4xpoSX2QXZ4yFnJY8oqooZAd8let+OM9JtszZWtqA1smLZ5mS3s /IiSWe0kWWuiWfClsrBg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htQTa-0006Xu-SU; Fri, 02 Aug 2019 05:51:38 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htQTX-0006XX-Uo for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2019 05:51:37 +0000 Received: by mail-qt1-x843.google.com with SMTP id d17so72656597qtj.8 for ; Thu, 01 Aug 2019 22:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ITQyJRBl7ht1TYk00a4jNJ9PbzaX8Bwy7nVWaA9ibU=; b=ZlXyZ6ztAsHkWX/gNtW3rbHVMXIy8YlD4tZkfmEg2K2GZWwrJbhbsffFVc4OaXLrg9 4tTqk4gATmYjzkZBvV6sH+07OauO8iQOl7F9IrPpZzBS6Z/6Juf2gv2baaqlQJdyWdqq U2PcA4vf7asSgaO+0RaIZUlir57+Jn+ToB2VE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ITQyJRBl7ht1TYk00a4jNJ9PbzaX8Bwy7nVWaA9ibU=; b=NBqPR37OdgQ0cCW6Y+8akMOj5//RMkABvvUUBSMJExQf/9Y1H4p9ezWO8pumjABa6a 6PpZbgWM5bXjP1kZcexDL0ILfyRtsz1UYfVUKdwMdyip8Wm0wzzdrI9/6IemoRr34ulJ KLXWcScpDMDNt+AJRmgWOs7mXd5ipbA1L5Z5tIexXmWyGtnVBfJyRNEq2b5dHqFV7gaV T47KZ400aJoWst05couT0tFqr6xQMGZrLycN3HWFxrTpgRJWYUlgSqKj/h83IfUA/1Tf mfCnkJrcKuFaaHl79EeUE1UCSs6xWERTPrj0/zsLRl3ogr5zzJet4TzPCPAfIv/6Zn1z 5UqA== X-Gm-Message-State: APjAAAUGCyLZNsNphzFRJ6/9slTDLh7qje/8H359ukIRAZpi64VOzkkQ rlCTu0+2vr9d4bp0p7zYkD++TCNEjnCs4PycOrU= X-Google-Smtp-Source: APXvYqxO7iXCAjOTakLYUnlXhbQV3QpIiWAYTjbetNNaVVixnu8M5TKpFH8tA3QT0jtpa2v4Vzycy56QBDbI0RnB0tU= X-Received: by 2002:a05:6214:1306:: with SMTP id a6mr97854130qvv.38.1564725094592; Thu, 01 Aug 2019 22:51:34 -0700 (PDT) MIME-Version: 1.0 References: <20190726053959.2003-1-andrew@aj.id.au> In-Reply-To: From: Joel Stanley Date: Fri, 2 Aug 2019 05:51:23 +0000 Message-ID: Subject: Re: [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings To: Andrew Jeffery X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190801_225135_997571_3D58ECAB X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-aspeed@lists.ozlabs.org, Linus Walleij , Corey Minyard , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree , Xo Wang , Arnd Bergmann , Ken Chen , Adriana Kobylak , "open list:GPIO SUBSYSTEM" , Rob Herring , =?UTF-8?B?WWFuZ0JyaWFuQy5XIOaliuWYieWBiSBUQU8=?= , openipmi-developer@lists.sourceforge.net, "Alexander A. Filippov" , Tao Ren , "linux-kernel@vger.kernel.org" , yao.yuan@linaro.org, Patrick Venture , John Wang , Greg Kroah-Hartman , Stefan M Schaeckeler , Haiyue Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Jul 2019 at 01:09, Andrew Jeffery wrote: > > > The bang-for-buck is in fixing up the KCS bindings which removes all-but-two of > > > the remaining warnings (which we can't feasibly remove), but doing so forces > > > code changes (which I'd avoided up until this point). > > > > > > Reflecting broadly on the fixes, I think I've made a mistake way back by using > > > syscon/simple-mfds to expose the innards of the SCU and LPC controllers in the > > > devicetree. This series cleans up what's currently there, but I have half a > > > mind to rev the SCU and LPC bindings to not use simple-mfd and instead have a > > > driver implementation that uses `platform_device_register_full()` or similar to > > > deal with the mess. > > > > > > Rob - I'm looking for your thoughts here and on the series, I've never felt > > > entirely comfortable with what I cooked up. Your advice would be appreciated. > > > > The series generally looks fine to me from a quick scan. As far as > > dropping 'simple-mfd', having less fine grained description in DT is > > generally my preference. It comes down to whether what you have > > defined is maintainable. As most of it is just additions, I think what > > you have is fine. Maybe keep all this in mind for the next chip > > depending how the SCU and LPC change. > > Okay, I think the timing of that suggestion is good given where things are with > the AST2600. I'll keep that in mind. > > Consensus so far seems to be that the series is fine. I'll split it up and send out > the sub-series to the relevant lists with the acks accumulated here. The series look good. I suggest posting the KCS bindings and driver changes as their own series to go through the IPMI tree. Please add my tag to all the patches except the OCC one, which I need to do some investigation in to. Reviewed-by: Joel Stanley The others can go via the aspeed tree. Perhaps post them as their own series too so I don't get confused and apply the wrong ones. That way if Rob wants to send his reviewed-by he can. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel