From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9268C48BDF for ; Fri, 11 Jun 2021 02:04:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9CAE6100A for ; Fri, 11 Jun 2021 02:04:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9CAE6100A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RyegvFm7tb5VxSfEUuKVcEbOp6oLIJ51dYzfJYWi9FM=; b=iErtx/roEtl0Hw PTSxuvkhnhYe1f8I7xaOy3hryEi1DW4iui3iuoDe0CSgALnT86o/wrHBSEJ5vvQv3eOCHdZoa9eMD LYrbyZC6EFdx6quyo+C9F4IfJoTfPu6nEf/ZFcQdiGiT0n5Oa/NyAnE6XoBE6NQuOVmfFubiFKZv/ Ou9IApSP5vw6UvyUZEXTANu3OVTtumQOQ7Evj2FhevxdfFWuCDXXRBzPT9VxhJSZrOpFunTcs1MI3 bTF3cMyScxsrnjvHCMP7iN2H8NEbW5M30t0f8pGR5LYZgnUwNwHndVU37WrYd/K7PsugmPPEJ3ujT JPAgcV8HspvP5lyIw+EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrWUF-003CJh-G0; Fri, 11 Jun 2021 02:01:31 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrWUA-003CIv-EE for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 02:01:27 +0000 Received: by mail-qk1-x735.google.com with SMTP id c18so14399707qkc.11 for ; Thu, 10 Jun 2021 19:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y6czCmeYJi+8/bsNpSEJ/y8kcHGUuFKrYFx1oGjn1Lw=; b=aMwR9u7nIahzHMBDEpY5f0zL7VrGlNOmUjnmZgbDXydaKm7bQ2GFyXRb+h+9M0hQax LeROgfnM6YdzsSNrffZPY3vsddToIFQHfVMQ0USESl/jCBi7dN4q0ZyGlN756G3GkfNV jjBZxO/H4mRKUNmF12xGzMy1vzjDYIvHkYeMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y6czCmeYJi+8/bsNpSEJ/y8kcHGUuFKrYFx1oGjn1Lw=; b=gWhzK2WkPXX9N5V3vAJwchJTTbCfHD3P8k3erNMK4MaFYJ8GS64oFtTx5F1YZ3NS4i 098sDEzMuj53gx7WVdLEut7ouQdTGIMIljMLHazCYGMcIHHzfdaaHgM3/0cunsLBVzgT pTkCKxgTnXhzwdUTQGbrZHVFz8Ly9TRWSjJJ/eNX60VjYS1W0vW6euGZxlUD0C2s80xQ k084sqHSOuYt9tTSI5VDDA0WGad9/SIYWK8vibjhfouCVbl3Iw1bc6QWZbuvFnraPqGv +cWEkDNE0Ks8rj1TDBe6l5HOCF8O1ymXD/wp6JK+My1cWr8AxOxR1NgHeWkB10CuXQgj vTtg== X-Gm-Message-State: AOAM53194BHhgN3yefZyNXRKkKhQ8YMTiMH7rj3hck676wJ+doSXTNNT /p40oOG1mFwXGN5mSnt02kYv6XmMKMBJjlb7NBs= X-Google-Smtp-Source: ABdhPJye9Gjpi6NmptG+WU4kxxUGYNaUfEZaIAWWq6TKZOI1CDvF0+VnbGfypEcPGdkWsRKM8Hcvpc1WfYP9UCmatfc= X-Received: by 2002:a05:620a:1485:: with SMTP id w5mr1648141qkj.66.1623376885199; Thu, 10 Jun 2021 19:01:25 -0700 (PDT) MIME-Version: 1.0 References: <20210610034957.93376-1-joel@jms.id.au> In-Reply-To: <20210610034957.93376-1-joel@jms.id.au> From: Joel Stanley Date: Fri, 11 Jun 2021 02:01:12 +0000 Message-ID: Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi , Shawn Guo , Li Yang , NXP Linux Team , Stephen Rothwell Cc: linux-usb@vger.kernel.org, Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_190126_564108_FE1B1898 X-CRM114-Status: GOOD ( 25.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Jun 2021 at 03:50, Joel Stanley wrote: > > The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") > dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending > solely on FSL_SOC. > > FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was > removed by commit cfd074ad8600 ("ARM: imx: temporarily remove > CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be > enabled on ARM platforms. > > This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 > SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: > > arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y > arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y > arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y > arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y > > To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the > ARM platforms, and with COMPILE_TEST. This didn't work out, as there's some missing clock initialisation calls that were removed when fsl_mxc_udc was deleted: arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function `fsl_udc_remove': fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release' arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function `fsl_udc_probe': fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init' arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined reference to `fsl_udc_clk_finalize' arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined reference to `fsl_udc_clk_release' We could add them back, but it's not clear if this driver is still maintained. I'm looking to the NXP people for input here. Stephen has dropped the patch from today's -next. I suggest we drop (or revert?) this patch from the USB tree while a solution is found. Cheers, Joel > > Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") > Signed-off-by: Joel Stanley > --- > v2: Fix spelling of ARCH_LAYERSCAPE > --- > drivers/usb/gadget/udc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig > index 8c614bb86c66..7348acbdc560 100644 > --- a/drivers/usb/gadget/udc/Kconfig > +++ b/drivers/usb/gadget/udc/Kconfig > @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC > > config USB_FSL_USB2 > tristate "Freescale Highspeed USB DR Peripheral Controller" > - depends on FSL_SOC > + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST > help > Some of Freescale PowerPC and i.MX processors have a High Speed > Dual-Role(DR) USB controller, which supports device mode. > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel