From: joel@jms.id.au (Joel Stanley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] clk: aspeed: Add reset controller
Date: Wed, 27 Sep 2017 16:13:38 +1000 [thread overview]
Message-ID: <CACPK8Xf6_hVgzakTYUrTND52fAeJrEi92Q+mdwOKjwACVLqN6Q@mail.gmail.com> (raw)
In-Reply-To: <1506344081.30138.32.camel@aj.id.au>
On Mon, Sep 25, 2017 at 10:54 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2017-09-21 at 13:56 +0930, Joel Stanley wrote:
>> +static const u8 aspeed_resets[] = {
>> + 25, /* x-dma */
>> + 24, /* mctp */
>> + 23, /* adc */
>> + 22, /* jtag-master */
>> + 18, /* mic */
>> + 9, /* pwm */
>> + 8, /* pci-vga */
>> + 2, /* i2c */
>> + 1, /* ahb */
>
> Bit of a nit, but given you define macros for the indices, maybe use designated
> initialisers and drop the comments.
Done. And that way I'd notice that I missed the define for the ADC :)
Cheers,
Joel
prev parent reply other threads:[~2017-09-27 6:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 4:26 [PATCH v2 0/5] clk: Add Aspeed clock driver Joel Stanley
2017-09-21 4:26 ` [PATCH v2 1/5] clk: Add clock driver for ASPEED BMC SoCs Joel Stanley
2017-09-25 3:40 ` Andrew Jeffery
2017-09-27 6:11 ` Joel Stanley
2017-09-21 4:26 ` [PATCH v2 2/5] clk: aspeed: Register core clocks Joel Stanley
2017-09-25 12:02 ` Andrew Jeffery
2017-09-27 6:13 ` Joel Stanley
2017-10-02 21:39 ` Stephen Boyd
2017-09-21 4:26 ` [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs Joel Stanley
2017-09-25 12:40 ` Andrew Jeffery
2017-09-27 6:13 ` Joel Stanley
2017-09-27 7:34 ` Andrew Jeffery
2017-09-28 4:29 ` Joel Stanley
2017-10-02 21:24 ` Stephen Boyd
2017-10-03 5:48 ` Joel Stanley
2017-10-04 21:18 ` Stephen Boyd
2017-10-05 6:22 ` Joel Stanley
2017-09-21 4:26 ` [PATCH v2 4/5] clk: aspeed: Register gated clocks Joel Stanley
2017-10-02 21:37 ` Stephen Boyd
2017-10-03 5:47 ` Joel Stanley
2017-09-21 4:26 ` [PATCH v2 5/5] clk: aspeed: Add reset controller Joel Stanley
2017-09-25 12:54 ` Andrew Jeffery
2017-09-27 6:13 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xf6_hVgzakTYUrTND52fAeJrEi92Q+mdwOKjwACVLqN6Q@mail.gmail.com \
--to=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).