From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver
Date: Thu, 15 Nov 2012 20:09:20 +0100 [thread overview]
Message-ID: <CACRpkdY+noKODLNUEV4dNM7cJVuRayEhJRjND75Ggm2kBoX1mw@mail.gmail.com> (raw)
In-Reply-To: <CAKohpomLRYAKJ=dNLVsjj1xf=G6xj4EcTpPmhSDvgBYUMXc1mA@mail.gmail.com>
On Thu, Nov 15, 2012 at 3:19 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 15 November 2012 19:47, Linus Walleij <linus.walleij@linaro.org> wrote:
>> Just one question: since this driver is not using any
>> pinctrl interfaces, why is it under drivers/pinctrl/*?
>>
>> Shouldn't it be under drivers/gpio from a technical
>> point of view?
>>
>> I think I'd accept it under drivers/pinctrl/spear/*
>> if you just want this to keep everything SPEAr-related
>> in one place though, so enlighten me.
>
> That's because they are controlling few pads. They are not
> actually gpio's but just pads that we are controlling.
>
> That's why we thought they are better in this place.
The grouping of drivers in the kernel is about what in-kernel
subsystem interface they're using, not how their electronics
work...
Since this driver is only using the GPIO API it should be
in drivers/gpio/gpio-*.c.
Many, many drivers in drivers/gpio* are controlling pads
too, so it will be in good company ;-)
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-11-15 19:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 4:39 [PATCH 00/14] ARM: SPEAr: DT updates Viresh Kumar
2012-11-11 4:39 ` [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver Viresh Kumar
2012-11-12 15:03 ` Arnd Bergmann
2012-11-15 14:17 ` Linus Walleij
2012-11-15 14:19 ` Viresh Kumar
2012-11-15 19:09 ` Linus Walleij [this message]
2012-11-16 5:15 ` [PATCH 01/16] gpio: " Viresh Kumar
2012-11-16 8:19 ` Arnd Bergmann
2012-11-16 8:19 ` Viresh Kumar
2012-11-17 23:02 ` Linus Walleij
2012-11-11 4:39 ` [PATCH 02/14] ARM: SPEAr13xx: DT: Add spics gpio controller nodes Viresh Kumar
2012-11-13 14:08 ` Linus Walleij
2012-11-13 14:34 ` Viresh Kumar
2012-11-15 14:06 ` Linus Walleij
2012-11-15 14:08 ` Viresh Kumar
2012-11-15 17:25 ` Linus Walleij
2012-11-11 4:39 ` [PATCH 03/14] ARM: SPEAr: DT: Update pinctrl list Viresh Kumar
2012-11-11 4:39 ` [PATCH 04/14] ARM: SPEAr: DT: Update partition info for MTD devices Viresh Kumar
2012-11-11 4:39 ` [PATCH 05/14] ARM: SPEAr: DT: Fix existing DT support Viresh Kumar
2012-11-11 4:39 ` [PATCH 06/14] ARM: SPEAr: DT: Modify DT bindings for STMMAC Viresh Kumar
2012-11-11 4:39 ` [PATCH 07/14] ARM: SPEAr: DT: add uart state to fix warning Viresh Kumar
2012-11-11 4:39 ` [PATCH 08/14] ARM: SPEAr: DT: Update device nodes Viresh Kumar
2012-11-26 11:25 ` Viresh Kumar
2012-11-11 4:39 ` [PATCH 09/14] ARM: SPEAr1310: Move 1310 specific misc register into machine specific files Viresh Kumar
2012-11-11 4:39 ` [PATCH 10/14] ARM: SPEAr13xx: Remove fields not required for ssp controller Viresh Kumar
2012-11-11 4:39 ` [PATCH 11/14] ARM: SPEAr1310: Fix AUXDATA for compact flash controller Viresh Kumar
2012-11-11 4:39 ` [PATCH 12/14] ARM: SPEAr3xx: shirq: simplify and move the shared irq multiplexor to DT Viresh Kumar
2012-11-12 15:09 ` Arnd Bergmann
2012-11-12 16:37 ` viresh kumar
2012-11-12 17:00 ` Arnd Bergmann
2012-11-12 17:16 ` [PATCH] fixup! " Viresh Kumar
2012-11-12 17:35 ` [PATCH] ARM: SPEAr3xx: Shirq: Move shirq controller out of plat/ Viresh Kumar
2012-11-11 4:39 ` [PATCH 13/14] ARM: SPEAr3xx: DT: add shirq node for interrupt multiplexor Viresh Kumar
2012-11-11 4:39 ` [PATCH 14/14] ARM: SPEAr320: DT: Add SPEAr 320 HMI board support Viresh Kumar
2012-11-12 15:21 ` [PATCH 00/14] ARM: SPEAr: DT updates Arnd Bergmann
2012-11-12 16:39 ` viresh kumar
2012-11-12 17:18 ` Viresh Kumar
2012-11-21 20:24 ` Olof Johansson
2012-11-22 3:19 ` Viresh Kumar
2012-11-22 9:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY+noKODLNUEV4dNM7cJVuRayEhJRjND75Ggm2kBoX1mw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).