From: Linus Walleij <linus.walleij@linaro.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Marc Zyngier <maz@kernel.org>, Maxime Ripard <maxime@cerno.tech>,
Phil Elwell <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks
Date: Sun, 26 Jun 2022 01:04:18 +0200 [thread overview]
Message-ID: <CACRpkdY6ykRSmTzavm9F5ZHysPaU5He0GCqqPrhG4zD-e0jorQ@mail.gmail.com> (raw)
In-Reply-To: <20220614202831.236341-2-stefan.wahren@i2se.com>
On Tue, Jun 14, 2022 at 10:29 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The commit b8a19382ac62 ("pinctrl: bcm2835: Fix support for threaded level
> triggered IRQs") assigned the irq_mask/unmask callbacks with the
> already existing functions for irq_enable/disable. The wasn't completely
> the right way (tm) to fix the issue, because these callbacks shouldn't
> be identical. So fix this by rename the functions to represent their
> intension and drop the unnecessary irq_enable/disable assigment.
>
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-25 23:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 20:28 [PATCH V2 0/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
2022-06-14 20:28 ` [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks Stefan Wahren
2022-06-25 23:04 ` Linus Walleij [this message]
2022-06-14 20:28 ` [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
2022-06-25 23:05 ` Linus Walleij
2022-06-15 6:04 ` [PATCH V2 0/2] " Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY6ykRSmTzavm9F5ZHysPaU5He0GCqqPrhG4zD-e0jorQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=maz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).