From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: mediatek: include chained_irq.h header
Date: Sun, 29 Jul 2018 23:15:54 +0200 [thread overview]
Message-ID: <CACRpkdYHhS7sPY6RqMNUSZ+otnoGPkBVgcfT20B-jscemnmotQ@mail.gmail.com> (raw)
In-Reply-To: <20180724115722.1274065-1-arnd@arndb.de>
On Tue, Jul 24, 2018 at 1:57 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Some randconfig builds fail in the mtk-eint driver:
>
> drivers/pinctrl/mediatek/mtk-eint.c: In function 'mtk_eint_irq_handler':
> drivers/pinctrl/mediatek/mtk-eint.c:324:2: error: implicit declaration of function 'chained_irq_enter'; did you mean 'rcu_irq_enter'? [-Werror=implicit-function-declaration]
> chained_irq_enter(chip, desc);
> ^~~~~~~~~~~~~~~~~
> rcu_irq_enter
> drivers/pinctrl/mediatek/mtk-eint.c:367:2: error: implicit declaration of function 'chained_irq_exit'; did you mean 'rcu_irq_exit'? [-Werror=implicit-function-declaration]
>
> The functions are declared in linux/irqchip/chained_irq.h, and including
> that header makes it build in all configurations.
>
> Fixes: e46df235b4e6 ("pinctrl: mediatek: refactor EINT related code for all MediaTek pinctrl can fit")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Thanks Arnd!
Yours,
Linus Walleij
prev parent reply other threads:[~2018-07-29 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 11:57 [PATCH] pinctrl: mediatek: include chained_irq.h header Arnd Bergmann
2018-07-29 21:15 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYHhS7sPY6RqMNUSZ+otnoGPkBVgcfT20B-jscemnmotQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).