From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: ux500: !CONFIG_OF build error drivers/gpio/gpio-nomadik.c
Date: Wed, 9 May 2012 14:54:10 +0200 [thread overview]
Message-ID: <CACRpkdYa1PcLjOFemsE_LabYqyKhF+wfUCTCCsTpd0=2-gQZWg@mail.gmail.com> (raw)
In-Reply-To: <201205071551.17327.arnd@arndb.de>
On Mon, May 7, 2012 at 5:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> a60b57e "ddrivers/gpio: gpio-nomadik: Add support for irqdomains" broke
> building with CONFIG_OF_GPIO disabled.
>
> Without this patch, building nhk8815_defconfig results in:
>
> /home/arnd/linux-arm/drivers/gpio/gpio-nomadik.c: In function 'nmk_gpio_probe':
> /home/arnd/linux-arm/drivers/gpio/gpio-nomadik.c:1238:6: error: 'struct gpio_chip' has no member named 'of_node'
> make[3]: *** [drivers/gpio/gpio-nomadik.o] Error 1
> make[2]: *** [drivers/gpio] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> If I hear no complaints, I'd like to apply this patch on the ux500/gpio branch.
Sure! However I'm floating some patch moving gpio/gpio-nomadik.c to
pinctrl/pinctrl-nomadik.c so prepare to handle that merge conflict when
pulling that in.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-05-09 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 15:51 ARM: ux500: !CONFIG_OF build error drivers/gpio/gpio-nomadik.c Arnd Bergmann
2012-05-09 12:54 ` Linus Walleij [this message]
2012-05-09 13:48 ` Arnd Bergmann
2012-05-10 11:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYa1PcLjOFemsE_LabYqyKhF+wfUCTCCsTpd0=2-gQZWg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).