From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: add dma_ctrl_cmd to pass buffer stride configuration
Date: Tue, 12 Jul 2011 13:09:31 +0200 [thread overview]
Message-ID: <CACRpkdYk65dmgvy325EA0rFEL3sZXMzNBvPBLGxctjQsfZhCBg@mail.gmail.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E94030259DB5B@dbde02.ent.ti.com>
On Tue, Jul 12, 2011 at 12:56 PM, Raju, Sundaram <sundaram@ti.com> wrote:
> [Me]
>> [Jassi]
>> > 3) TI may not have just one DMAC IP used in all the SoCs. So if you want
>> > ?vendor specific defines anyway, please atleast also add DMAC version to it.
>> > ?Something like
>> >> ? ? ? ?DMA_SLAVE_CONFIG,
>> >> ? ? ? ?FSLDMA_EXTERNAL_START,
>> >> + ? ? ? TI_DMA_v1_STRIDE_CONFIG,
>>
>> Yep unless we make it generic DMA_STRIDE_CONFIG simply, this makes
>> a lot of sense.
>
> Okay, I can add one cmd for the EDMAC in DaVinci series of SoCs and
> one for SDMAC in OMAP series of SoCs.
Wait, that's two different silicon blocks right? Then you already have proof
that this spans more than one DMAC and then you can just go for a generic
DMA_STRIDE_CONFIG from day one.
That both are TI does not matter, if they are totally unrelated implementations.
Yours,
Linus Walleij
next prev parent reply other threads:[~2011-07-12 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 15:03 [PATCH] dmaengine: add dma_ctrl_cmd to pass buffer stride configuration Sundaram Raju
2011-07-11 9:28 ` Linus Walleij
2011-07-11 21:39 ` Dan Williams
2011-07-12 9:58 ` Linus Walleij
2011-07-12 10:15 ` Raju, Sundaram
2011-07-12 4:17 ` Jassi Brar
2011-07-12 10:03 ` Linus Walleij
2011-07-12 10:56 ` Raju, Sundaram
2011-07-12 11:09 ` Linus Walleij [this message]
2011-07-12 11:20 ` Jassi Brar
2011-07-12 11:31 ` Raju, Sundaram
2011-07-12 12:45 ` Jassi Brar
2011-07-18 7:51 ` Raju, Sundaram
2011-07-23 20:35 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYk65dmgvy325EA0rFEL3sZXMzNBvPBLGxctjQsfZhCBg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).