From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43E6FC43334 for ; Mon, 18 Jul 2022 09:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TnKHATtWoW9WhkzgIQTe5uowAanTB8uGP5CEXyqfCS4=; b=r52Um9AvsUOzGO HDLFvs16Sw7UGjvzcy60l3++vJ3FlY5Scee9Y7g9HkbQUSNPakNlFkdsD+2occkfxl2pyUR0ordAl WXaZnOYiCQgGOSsFQ+igi1u0YkF7u2w1ZiBBt+APdgMEXZ9ahYqJdjTLWEFP1xS6zzTQ4ZtmZb9DO cK3j24HVEnrFx8uJu934WtqXT2GCDb88qT5Rme948dzA9NrUxLcoOofTUpH33U3IrcNVbvrQ3HtXy ruVycmOuCJEQjHjdpWrEQByvS40B0BclRzFRwFh7QQvNGyqwl8ko3hwOlPrgGiXl21NsreFtfrpL3 ny4sCokAT2uc//FHrgqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDMq6-00C2ng-WC; Mon, 18 Jul 2022 09:14:55 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDMq4-00C2kz-7h for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 09:14:53 +0000 Received: by mail-ej1-x62c.google.com with SMTP id ss3so20011439ejc.11 for ; Mon, 18 Jul 2022 02:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwFbbauDX9gsZYxtY8fxgYizduNV3aBKsO3yUHiYWcA=; b=lOzYBZxkWa12PFEYxuRa3esea0uZmAzb/unlVnlRnHnhGEcFOCjG5X8DbepRn1wyTe JoxJDTxc5gvW/Gs1ToHLdEEEHD/HuuzW/ZZFtax6eEzY0qPDWja14ZRctGByO3HY9bbb 8GQETaShmaNthrEDIDz5sk72HoLj45JDd4chLJlosTfzpiG0MJMWsXlZXMlOS9/W2Vy6 nwOD7j0J64i/6T3zM/DnxFniv+zu7SL+KLPl/kR2adbEsVCLomFDOlIV/Rvj0oqGSSHb J5kYntdMLrmzpvbmIUOTB62LeN4drnmiHLsEPXJEqU1wDXIUmLbycaKfos5QQcNiI10u Icgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwFbbauDX9gsZYxtY8fxgYizduNV3aBKsO3yUHiYWcA=; b=eLtjL/Z0g5lD5O6S5QKJgSmaz6k+Q8Y1+z44yZ73nSzIuhrvyd5Dt0bNyK4ulrtZyc 6WlnDf9H6/0yK/gAgfxmjO4X0jrQzyd0U4DPhe1u+8bHjXi7HBllACD60TQ6wk64c6/2 4K0k2Dh8iOb/N3X23l6DGbCkv+2YZgOjp5IjF78Arn+RPYQ2Yb+n4qrrSxpHjC91Uaq6 I4e1yujmUDZ+6I8R+xss1/FTvgRLL9mn+z80vzWCfSx45Nf0K0JvYaF052Q9gb4SYZFT AIqXvdmq8Nz7IPRJqD+Wej7blEAR/XHLFaTxZ/vL4wNl37gjZKHo2pVku1lG05UMOz/L ns7g== X-Gm-Message-State: AJIora9Q/lbICDPy+4Jn2OvfRK5/OG+y/p+ILCdLtAoJzCdfWRXBEeCH eL2uA5qNGRkPD2mtYF0LT+kRSEYPbe+08lRL/xurA+boq8g= X-Google-Smtp-Source: AGRyM1tCH5IixWtJI6STLtZK5K2JWPfTCLpcSnp75RgNnuxfWdyUFS3S8v9F4PaWSdnjzvnIzUM7VsEodFwZl4fW2Sc= X-Received: by 2002:a17:906:58c8:b0:6fe:91d5:18d2 with SMTP id e8-20020a17090658c800b006fe91d518d2mr24964642ejs.190.1658135688605; Mon, 18 Jul 2022 02:14:48 -0700 (PDT) MIME-Version: 1.0 References: <20220713110020.85511-1-lihuafei1@huawei.com> In-Reply-To: <20220713110020.85511-1-lihuafei1@huawei.com> From: Linus Walleij Date: Mon, 18 Jul 2022 11:14:37 +0200 Message-ID: Subject: Re: [PATCH v2 0/5] ARM: Convert to ARCH_STACKWALK To: Li Huafei Cc: linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk, ardb@kernel.org, will@kernel.org, broonie@kernel.org, mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, arnd@arndb.de, rostedt@goodmis.org, nick.hawkins@hpe.com, john@phrozen.org, mhiramat@kernel.org, ast@kernel.org, linyujun809@huawei.com, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_021452_301207_9A1D02D2 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 13, 2022 at 1:02 PM Li Huafei wrote: > This series mainly updates the ARM stack trace code to use the newer and > simpler arch_stack_walk() interface. Two issues were fixed before that > (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to > trace non-current tasks (see patch 3). > > v2: > - As suggested by Mark, the commit logs for patch 4 and 5 were > refined for easy review. I see I reviewed v1 when v2 was already out but think the comments still stand. I think you can already add patches 1 & 2 to Russells patch tracker, they are straight-forward fixes. Patches 3-5 may need some elaboration but I trust that you have done some serious testing since you found the snags in patches 1 & 2. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel