From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0E2C4338F for ; Wed, 11 Aug 2021 13:10:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74CD460D07 for ; Wed, 11 Aug 2021 13:10:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 74CD460D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IaTXcrlAvGDkj0INMViqDVOsFsxzdkwjUFsqyaKg+p8=; b=3Ctr8VmHlfAkif wxwvqzcQrcMqRJ2tqI1sqHrs2sKjzKvqyuPAW8p5gyY1h1HRpJocYf1gJYmoA4oiK43LJixGR/nSV zgTErEZ4WAqXw8oWM6c5sEBK+N5rGovbH7H7PspNZS6fd/qXmdeYAMYpPLRQZDZj+W6m1DBM1Lf/0 O6kswS0BGN+JoxFy5tcZHMRGUbo+onRCTEy+ZiuAcVylX5mmbwZwgZ7X7CxmyjvW/TWJSEYV769yY iNUCbWnE9xlEKGv/Nw9ryrd+YeRYcH0XhTONoef8TSe9B01a+56MpleZY7g2QFWDsDWL8g6bZoWOp Wke1VxNoy3s5mYdiFsIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDnyZ-007HPt-A6; Wed, 11 Aug 2021 13:08:55 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDnyS-007HOs-CM for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 13:08:52 +0000 Received: by mail-lf1-x136.google.com with SMTP id t9so5593149lfc.6 for ; Wed, 11 Aug 2021 06:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0Q/OipXg5g+bBy7pKTFAJBo2h8NmRufFU0TcCTZHVxQ=; b=AEXFKHPH/3LxE48BApNLzNCXADbLmx6mJVTDYzP/UWXVBa8MGkwlfj61fz+YT+n/iF 3QQ7XxyzctODusGygoOKQQiUOvB4iIMwB/jr4J0c2z68EOP0yP5mRj0LcbMqRHUqRX8y Ifo7slj7QlHMDleExdEmQNrKgWcEh+xM/U8ofNrSmEaIOXQxEoK2qH7yncdNhLWY2SBL Ww4xGrpQSR81gkDVkoxX0lpbVa2Z8OiJEPSnHHJO0/cjgykb7uuF/N04nJJ3jVMkycpd T11rjgEA/i671M5tagCGiB24spbPA+wSw31MGHVjvLEQu9ZR8aIAtoXRcSyNScf6UtUb /hmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Q/OipXg5g+bBy7pKTFAJBo2h8NmRufFU0TcCTZHVxQ=; b=tHKQZJ/3UL459d8URgQ37Acx1J57J93vOtsT7v0lEkpYbhYPMEKHOyimz0VCRhD1xh /OO1UHrdVKP9QhKIbBG4ZHxn8dV7EszwU8KyUj12pl5x9aXfZoOHyfPjuwlP6GKw+w/d M39J1ooSZhCrxI2eQqS7CKD5ZHd4oqUgMctkYyVQefmF6RawHxLcWC/D5Cuni4EjPK7e oMRfXheH35AUCcHecaeMs4mrziPr/6o2/7fE2nqSShlg+0bMXXbyVXR3n7a1ZO84UkHk 6nXqInV1w0HnyosC0kQQr0eFHuMTxQvlWmksjhL4r6Lsj2ZaxnOdczh0tU7g7hG8Mnjj O9SQ== X-Gm-Message-State: AOAM533rA2khY+ng5hSGEwR1a8LpMcmqFbb5eITNsAyQe5T3lb6iDcym UkrmDEpGGNNuQFp8IM5+yqKjCCJrwAkZ009Acbg1PQ== X-Google-Smtp-Source: ABdhPJzngrlz2QK7UpQplrwK8nq9N3R5uqem/ckB0ImAfMdAQvhtKbnN9URtS6Tro73RTdIez51pslkCrnGNaLO3pIo= X-Received: by 2002:a05:6512:32a3:: with SMTP id q3mr13907141lfe.157.1628687326222; Wed, 11 Aug 2021 06:08:46 -0700 (PDT) MIME-Version: 1.0 References: <20210805174219.3000667-1-piyush.mehta@xilinx.com> <20210805174219.3000667-2-piyush.mehta@xilinx.com> In-Reply-To: <20210805174219.3000667-2-piyush.mehta@xilinx.com> From: Linus Walleij Date: Wed, 11 Aug 2021 15:08:35 +0200 Message-ID: Subject: Re: [PATCH V2 1/3] firmware: zynqmp: Add MMIO read and write support for PS_MODE pin To: Piyush Mehta Cc: Arnd Bergmann , Zou Wei , Greg KH , Michal Simek , wendy.liang@xilinx.com, Nobuhiro Iwamatsu , Bartosz Golaszewski , Rob Herring , rajan.vaja@xilinx.com, "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , git , Srinivas Goud , Linux ARM , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_060848_461118_744623C4 X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 5, 2021 at 7:42 PM Piyush Mehta wrote: > Add Xilinx ZynqMP firmware MMIO APIs support to set and get PS_MODE > pins value and status. These APIs create an interface path between > mode pin controller driver and low-level API to access GPIO pins. > > Signed-off-by: Piyush Mehta > --- > Changes in v2: > - Added Xilinx ZynqMP firmware MMIO API support to set and get pin > value and status. I doubt this is "GPIO". General Purpose? I think not. It seems to be about boot mode. If you need a userspace ABI, then add sysfs files to this firmware driver instead of bridging it to the GPIO subsystem. However I can be argued down from usecases etc that it is used as GPIO but I need to push back on this. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel