From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized
Date: Sun, 3 Apr 2016 18:35:15 +0200 [thread overview]
Message-ID: <CACRpkdYrTCRaeXjjEOripqtqhC-ndqTrht6cByCMBw_iVLsC5Q@mail.gmail.com> (raw)
In-Reply-To: <20160401140218.GA14502@roeck-us.net>
On Fri, Apr 1, 2016 at 4:02 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Apr 01, 2016 at 10:04:57AM +0200, Linus Walleij wrote:
>> > Please ignore/drop this patch - a better (cleaner) fix is in the works
>> > for gpiolib.
>>
>> This delivers though. I tested it on my also regressing iPAQ.
>>
> I am a bit concerned that the gpio initialization was that early on purpose,
> and that by moving it we might miss some use cases. I did not find any, but that
> doesn't mean that there are none. Without knowing _why_ the initialization was
> that early, I would prefer not to touch the code if it can be avoided.
I think we'll go for the other patch to gpiolib. It seems much more clean
and generic to support this kind of cases.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-04-03 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 18:15 [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized Guenter Roeck
2016-03-31 16:21 ` Guenter Roeck
2016-04-01 8:04 ` Linus Walleij
2016-04-01 14:02 ` Guenter Roeck
2016-04-03 16:35 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYrTCRaeXjjEOripqtqhC-ndqTrht6cByCMBw_iVLsC5Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).