* [PATCH] pinctrl: mediatek: Consistently use the BIT() macro
@ 2015-08-28 23:25 Javier Martinez Canillas
2015-09-01 9:45 ` Matthias Brugger
2015-09-25 16:41 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-08-28 23:25 UTC (permalink / raw)
To: linux-arm-kernel
The mediatek pinctrl driver uses the BIT() macro instead of open
coding 1 << n in all but one place. Replace this occurrence with
the BIT() macro for consistency.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 23f2de07f598..497b9125342a 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -898,7 +898,7 @@ static int mtk_eint_flip_edge(struct mtk_pinctrl *pctl, int hwirq)
int start_level, curr_level;
unsigned int reg_offset;
const struct mtk_eint_offsets *eint_offsets = &(pctl->devdata->eint_offsets);
- u32 mask = 1 << (hwirq & 0x1f);
+ u32 mask = BIT(hwirq & 0x1f);
u32 port = (hwirq >> 5) & eint_offsets->port_mask;
void __iomem *reg = pctl->eint_reg_base + (port << 2);
const struct mtk_desc_pin *pin;
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] pinctrl: mediatek: Consistently use the BIT() macro
2015-08-28 23:25 [PATCH] pinctrl: mediatek: Consistently use the BIT() macro Javier Martinez Canillas
@ 2015-09-01 9:45 ` Matthias Brugger
2015-09-25 16:41 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2015-09-01 9:45 UTC (permalink / raw)
To: linux-arm-kernel
On 29/08/15 01:25, Javier Martinez Canillas wrote:
> The mediatek pinctrl driver uses the BIT() macro instead of open
> coding 1 << n in all but one place. Replace this occurrence with
> the BIT() macro for consistency.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 23f2de07f598..497b9125342a 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -898,7 +898,7 @@ static int mtk_eint_flip_edge(struct mtk_pinctrl *pctl, int hwirq)
> int start_level, curr_level;
> unsigned int reg_offset;
> const struct mtk_eint_offsets *eint_offsets = &(pctl->devdata->eint_offsets);
> - u32 mask = 1 << (hwirq & 0x1f);
> + u32 mask = BIT(hwirq & 0x1f);
> u32 port = (hwirq >> 5) & eint_offsets->port_mask;
> void __iomem *reg = pctl->eint_reg_base + (port << 2);
> const struct mtk_desc_pin *pin;
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] pinctrl: mediatek: Consistently use the BIT() macro
2015-08-28 23:25 [PATCH] pinctrl: mediatek: Consistently use the BIT() macro Javier Martinez Canillas
2015-09-01 9:45 ` Matthias Brugger
@ 2015-09-25 16:41 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-09-25 16:41 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 28, 2015 at 4:25 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The mediatek pinctrl driver uses the BIT() macro instead of open
> coding 1 << n in all but one place. Replace this occurrence with
> the BIT() macro for consistency.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Patch applied with Matthias' Ack.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-25 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-28 23:25 [PATCH] pinctrl: mediatek: Consistently use the BIT() macro Javier Martinez Canillas
2015-09-01 9:45 ` Matthias Brugger
2015-09-25 16:41 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).