From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Tue, 10 Oct 2017 22:06:48 +0200 Subject: [PATCH 04/11] watchdog: ftwdt010: Add clock support In-Reply-To: References: <20170812184318.10144-1-linus.walleij@linaro.org> <20170812184318.10144-5-linus.walleij@linaro.org> <20170814160536.GC7025@roeck-us.net> <20170827170641.GF22819@roeck-us.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org So need info from Joel Stanley here: On Tue, Oct 10, 2017 at 9:51 PM, Linus Walleij wrote: > On Sun, Aug 27, 2017 at 7:06 PM, Guenter Roeck wrote: >> On Thu, Aug 24, 2017 at 10:32:22PM +0200, Linus Walleij wrote: >>> On Mon, Aug 14, 2017 at 6:05 PM, Guenter Roeck wrote: >> If I understand your comment below correctly, the driver won't work >> without clock subsystem because the clock frequency would in that case >> be 0. Why not catch that situation here, or even better make the driver >> depends on the clock subsystem ? > > OK fair enough I can do that. > > I think Aspeed is merging its clock driver this kernel cycle > so all variant SoCs actually have clocks. So when I later in the patch series convert Aspeed to use this driver we get a problem because Joel is currently working on the clock driver for Aspeed and it's not ready for merge yet as it looks. I can of course wait with the Aspeed conversion to use the common driver. Also I can slap in a fixed-rate clock in the device tree @1 MHz. But that is cheating. So I guess I rest the Aspeed conversion. Joel: does your clock patch set cover the 1MHz used by the watchdog EXTCLK? Yours, Linus Walleij