From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux
Date: Fri, 2 Sep 2011 10:11:48 +0200 [thread overview]
Message-ID: <CACRpkdZ1kNbtOqw=X1mmM-bA+Gg2BbmO5_CT0sSQtBCK_WdwYw@mail.gmail.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B327A40C@HQMAIL01.nvidia.com>
On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren <swarren@nvidia.com> wrote:
>> +static const struct u300_pmx_func u300_pmx_functions[] = {
>> + ? ? {
>> + ? ? ? ? ? ? .name = "power",
>> + ? ? ? ? ? ? .groups = { POWERGRP_INDEX },
>> + ? ? ? ? ? ? /* Mask is N/A */
>> + ? ? },
>
> Hmmm. That's a lot of _INDEX defines that'd need to be set up, at least
> to fully represent a chip like Tegra. Can the pinmux core be modified
> such that the group list is an array of names (char*) rather than the
> actual numeric IDs of the groups? Still, perhaps we could use the enum
> we already have for this, so perhaps it isn't a big deal...
Well I could think about a lot of ways to do this, but it's basically up
to the driver, the U300 is just some simple example of what you can
do, it's just trying to satisfy the API.
Maybe as part of writing the nVidia driver you find a clever
mechanism for doing this, if it's looking generally useful at that
point then let's move it to the core I'd say.
Thanks,
Linus Walleij
next prev parent reply other threads:[~2011-09-02 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 9:32 [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux Linus Walleij
2011-09-01 21:33 ` Stephen Warren
2011-09-02 8:11 ` Linus Walleij [this message]
2011-09-02 16:04 ` Stephen Warren
2011-09-13 13:06 ` Linus Walleij
2011-09-14 1:48 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ1kNbtOqw=X1mmM-bA+Gg2BbmO5_CT0sSQtBCK_WdwYw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).