From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Sun, 19 Aug 2012 00:42:12 +0200 Subject: [PATCH 5/6] ARM: integrator: convert AMBA devices to device tree In-Reply-To: <20120816124002.GB7439@game.jcrosoft.org> References: <1345119373-22774-1-git-send-email-linus.walleij@linaro.org> <20120816124002.GB7439@game.jcrosoft.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 16, 2012 at 2:40 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:16 Thu 16 Aug , Linus Walleij wrote: >> +/* For the Device Tree, add in the UART callbacks as AUXDATA */ >> +static struct of_dev_auxdata ap_auxdata_lookup[] __initdata = { >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE, >> + "rtc", NULL), >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART0_BASE, >> + "uart0", &integrator_uart_data), >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART1_BASE, >> + "uart1", &integrator_uart_data), >> + OF_DEV_AUXDATA("arm,primecell", KMI0_BASE, >> + "kmi0", NULL), >> + OF_DEV_AUXDATA("arm,primecell", KMI1_BASE, >> + "kmi1", NULL), >> + { /* sentinel */ }, > why that? Based on similar code by Grant in arch/arm/mach-versatile/core.c also ending with a {}. Also at other places ... I though this terminated the list iteration, is it not needed anymore? Yours, Linus Walleij