linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: dts: juno/rtsm: re-structure motherboard includes
Date: Wed, 23 May 2018 09:59:27 +0200	[thread overview]
Message-ID: <CACRpkdZgexdti2ko1APDi5Pk6F9yN2Et1v-uO2b72jR2PizEOw@mail.gmail.com> (raw)
In-Reply-To: <1525884291-18851-3-git-send-email-sudeep.holla@arm.com>

On Wed, May 9, 2018 at 6:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:

> It is a bit unorthodox to just include a file in the middle of a another
> DTS file, it breaks the pattern from other device trees and also makes
> it really hard to reference things across the files with phandles.
>
> Restructure the include for the Juno/RTSM motherboards to happen at the
> top of the file, reference the target nodes directly, and indent the
> motherboard .dtsi files to reflect their actual depth in the hierarchy.
>
> This is a purely syntactic change that result in the same DTB files from
> the DTS/DTSI files. This is based on similar patch from Linus Walleij
> for ARM Vexpress platforms.
>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks for doing this, it is much more readable for me now.

Sorry for slow review :/

Yours,
Linus Walleij

  parent reply	other threads:[~2018-05-23  7:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 16:44 [PATCH 1/3] arm64: dts: juno: Fix "debounce-interval" property misspelling Sudeep Holla
2018-05-09 16:44 ` [PATCH 2/3] arm64: dts: juno: replace '_' with '-' in node names Sudeep Holla
2018-05-09 21:15   ` Rob Herring
2018-05-10  9:45   ` Liviu Dudau
2018-05-09 16:44 ` [PATCH 3/3] arm64: dts: juno/rtsm: re-structure motherboard includes Sudeep Holla
2018-05-10  9:49   ` Liviu Dudau
2018-05-10 10:07     ` Sudeep Holla
2018-05-23  7:59   ` Linus Walleij [this message]
2018-05-10  9:44 ` [PATCH 1/3] arm64: dts: juno: Fix "debounce-interval" property misspelling Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZgexdti2ko1APDi5Pk6F9yN2Et1v-uO2b72jR2PizEOw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).