From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: ux500: select I2C for U8500
Date: Wed, 29 Feb 2012 18:06:46 +0100 [thread overview]
Message-ID: <CACRpkda8P5pv4m2hwP8fWNnpmZb-cBJBhkyYEtzet69vBpVJvg@mail.gmail.com> (raw)
In-Reply-To: <201202291703.33907.arnd@arndb.de>
On Wed, Feb 29, 2012 at 6:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> I got one more build error when actually disabling CONFIG_I2C on ux500:
>
> arnd at klappe2:~/linux-arm$ make O=obj-arm/ ?ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- -s ?-j3 -k
> /git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c: In function 'mop500_uib_i2c_add':
> /git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:74:2: error: implicit declaration of function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
> /git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:81:3: error: implicit declaration of function 'i2c_new_device' [-Werror=implicit-function-declaration]
> /git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:121:2: error: implicit declaration of function 'i2c_smbus_xfer' [-Werror=implicit-function-declaration]
>
> I guess those need to be fixed, too. Ideally the API could just
> get stubbed out for !CONFIG_I2C, but it might be easier to
> conditionally build the code using it.
Hm in this case it's the code probing the board using I2C to figure out if it's
this or that variant.
So selecting this board needs to select I2C and I2C_NOMADIK to work
properly, I'll see if I can reproduce and think of something.
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-02-29 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1330199334-5133-1-git-send-email-mathieu.poirier@linaro.org>
[not found] ` <1330199334-5133-6-git-send-email-mathieu.poirier@linaro.org>
[not found] ` <CACRpkdbGAhwdxE6tYdib0Aiw=9qScmV507npzDU1hkH1xXgxRQ@mail.gmail.com>
[not found] ` <201202291634.41686.arnd@arndb.de>
2012-02-29 17:00 ` [PATCH 6/6] ARM: ux500: select I2C for U8500 Linus Walleij
2012-02-29 17:03 ` Arnd Bergmann
2012-02-29 17:06 ` Linus Walleij [this message]
2012-02-25 19:55 [PATCH 1/6] arm: U8500 depends on MMU mathieu.poirier at linaro.org
2012-02-25 19:55 ` [PATCH 6/6] ARM: ux500: select I2C for U8500 mathieu.poirier at linaro.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda8P5pv4m2hwP8fWNnpmZb-cBJBhkyYEtzet69vBpVJvg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).