From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F368C433E0 for ; Tue, 2 Feb 2021 19:16:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2779464DD6 for ; Tue, 2 Feb 2021 19:16:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2779464DD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8t8dbYL2k2hBqt5UprsuF/wTj/Iuri3fcjiPt67tEZ4=; b=GXhdsMrgFKPOPRHAmpX6NFJgg RH07nInM6oHk9uVaE9pEJ9yYI/jYmxmk8sgGSZeXg9RvD3AG9oxrVeM75sZHBCe9pEWS1RUHGlIkb ATgMbu2URUfvEVnlix2XBCVs2f1ajlNrIRhfL62LUtNii5mb6STRF/0+UCMPZuaCXqZs1PZdbk2VU YKbMS6SrfGn5ITQWPq1XgNPCGEftW8TMDcn/+Bdq1ZnFrA8MxxK+luceTcbW/byBcHgweYk3W5D+G jp13fIqfOJ8x80IsE7GTRbZPi6+CoUftVZHb4wOoXGz8HbqvXHsTYITpblsDBexfWxO11PqYykaU7 6NSE8jnmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l719M-0002Jm-Cs; Tue, 02 Feb 2021 19:15:44 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l719J-0002Ix-M1 for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 19:15:42 +0000 Received: by mail-lf1-x135.google.com with SMTP id m22so29598082lfg.5 for ; Tue, 02 Feb 2021 11:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/7QquFjvRxPY0U7aF3eWrvZSM21MySROeK24YtU62q0=; b=KMxUnzUOqmD0gRF9g6XAj9MG52HyTdDUa5d/Bi/Vn4JioC4VtgrjT48qvz14nwsyTQ tZklwetTSy7v3cTQftpr10BzE0nVRi1EexypGHZ86NGTQydOExljc4FBj2PKLaTgnOLk HS5XkiJYqG7DnTQe2N/0MQlC9k2ZDQS8ygmgiGx/q3n2wMWCvtVAG1K/yTVRDunTgzCs 8h7jU1AqxMjZFjUJtiKJehGd+0j8nZBVSWO+t6+AFR05GBLzoyUUQupb28Zh0R3q9RP1 G4q4l1beHewGN74UoeooGBOVOs+WH/7W+f8ZF1xFo8yvb5vqroAyXJgUXfoZRee9uF1d AsDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/7QquFjvRxPY0U7aF3eWrvZSM21MySROeK24YtU62q0=; b=baVZAh8hkWGmxeSjlnhypq6WHqN8Cj9cfxMPWy+GLIunc226TG9kY4VZ//6TYuL/nD IjqecPn8fFElSvCnCNUwu1qYlNYKH7ThzvfkFhb2PC0d/EPQUzCDgjC7FyR3009nqS8a yhEDug1H1a780sqXH9J7kuGLPg9AmF3/fDZGYmelP5cyK+TmUKExEQ24H44ac2JWcSYs wDMJosYf/79h6PjgugxVHgGCK800NbWdsU9hleuc+C0EqhcfpO5LLh9sPdPPqt1zZH+i WEcoEVY8gEHYHlnU1gtrP2NqFGe97nU9f+XFM5e1OIG+u0HvgxmS+3+0BmX7R/jlXYtA 4trw== X-Gm-Message-State: AOAM5331iE67cCkX4fVAmed2yhc41RQTvf147w1HXSRsuOP+plkkAXtB FfFOLLHNCnEUXULOs08w3NdnVuImh21CEwqpkUVRRQ== X-Google-Smtp-Source: ABdhPJzV0Ns8BDjfiy5cULmWtU7+/Q7DEwfm2A+ng3fvCQIHmuXBUxuZVEji+2lLXBCPgA+O62NnK87WtnQKbUuQAug= X-Received: by 2002:a19:b8e:: with SMTP id 136mr12406124lfl.29.1612293338259; Tue, 02 Feb 2021 11:15:38 -0800 (PST) MIME-Version: 1.0 References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> In-Reply-To: <20210120132717.395873-8-mohamed.mediouni@caramail.com> From: Linus Walleij Date: Tue, 2 Feb 2021 20:15:26 +0100 Message-ID: Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. To: Mohamed Mediouni X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_141541_765350_F2640013 X-CRM114-Status: UNSURE ( 8.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Hector Martin , "linux-kernel@vger.kernel.org" , Marc Zyngier , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mohamed, just a small drive-by comment: On Wed, Jan 20, 2021 at 2:32 PM Mohamed Mediouni wrote: > + for_each_cpu (cpu, mask) { > + smp_mb__before_atomic(); > + atomic_or(1u << irqnr, per_cpu_ptr(&aic_ipi_mask, cpu)); Use: #include atomic_or(BIT(irqnr), per_cpu_ptr(&aic_ipi_mask, cpu)); Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel