From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 28 Oct 2016 14:24:27 +0200 Subject: [PATCH] Revert "gpio/mvebu: convert to use irq_domain_add_simple()" In-Reply-To: <87twbyb65j.fsf@free-electrons.com> References: <1476831396-24359-1-git-send-email-jgunthorpe@obsidianresearch.com> <871szcerxl.fsf@free-electrons.com> <20161019210341.GA3746@obsidianresearch.com> <87twbyb65j.fsf@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 27, 2016 at 9:30 AM, Gregory CLEMENT wrote: > On lun., oct. 24 2016, Linus Walleij wrote: >> On Wed, Oct 19, 2016 at 11:03 PM, Jason Gunthorpe >> wrote: >> >>> From 7566f05ac445b652ba7607cc1899fed10fea1c76 Mon Sep 17 00:00:00 2001 >>> From: Jason Gunthorpe >>> Date: Wed, 19 Oct 2016 14:57:45 -0600 >>> Subject: [PATCH] gpio/mvebu: Use irq_domain_add_linear >>> >>> This fixes the irq allocation in this driver to not print: >>> irq: Cannot allocate irq_descs @ IRQ34, assuming pre-allocated >>> irq: Cannot allocate irq_descs @ IRQ66, assuming pre-allocated >>> >>> Which happens because the driver already called irq_alloc_descs() >>> and so the change to use irq_domain_add_simple resulted in calling >>> irq_alloc_descs() twice. >>> >>> Modernize the irq allocation in this driver to use the >>> irq_domain_add_linear flow directly and eliminate the use of >>> irq_domain_add_simple/legacy >>> >>> Fixes: ce931f571b6d ("gpio/mvebu: convert to use irq_domain_add_simple()") >>> Signed-off-by: Jason Gunthorpe >> >> So can I just apply this? >> Gregory? > > For me it's OK. APplied this inline version. Yours, Linus Walleij