* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible
@ 2017-07-26 6:45 Keerthy
2017-07-26 6:45 ` [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy
` (3 more replies)
0 siblings, 4 replies; 20+ messages in thread
From: Keerthy @ 2017-07-26 6:45 UTC (permalink / raw)
To: linux-arm-kernel
The patch adds keystone-k2g compatible, specific properties and
an example.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Changes in v3:
* Added details about family of SoCs corresponding to compatibles.
.../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
index 5079ba7..fb9efee 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
@@ -1,7 +1,10 @@
Davinci/Keystone GPIO controller bindings
Required Properties:
-- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio"
+- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs
+ "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
+ 66AK2E SoCs
+ "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G
- reg: Physical base address of the controller and the size of memory mapped
registers.
@@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default
two cells specifier as described in Documentation/devicetree/bindings/
interrupt-controller/interrupts.txt.
+Required Properties specific to keystone-k2g
+
+- clocks: Should contain devices input clock. The first parameter
+ is a handle to k2g_clks. The second parameter is the
+ device ID and the third parameter is the clock ID. One can
+ refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data
+
+ Example: <&k2g_clks 0x001c 0x0>;
+
+- clock-names: The driver expects the clock name to be "gpio";
+
Example:
gpio: gpio at 1e26000 {
@@ -60,3 +74,27 @@ leds {
...
};
};
+
+Example for keystone-k2g:
+
+gpio0: gpio at 2603000 {
+ compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
+ reg = <0x02603000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <144>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k2g_clks 0x001b 0x0>;
+ clock-names = "gpio";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes 2017-07-26 6:45 [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Keerthy @ 2017-07-26 6:45 ` Keerthy 2017-07-26 13:03 ` Suman Anna 2017-07-26 13:00 ` [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Suman Anna ` (2 subsequent siblings) 3 siblings, 1 reply; 20+ messages in thread From: Keerthy @ 2017-07-26 6:45 UTC (permalink / raw) To: linux-arm-kernel 66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs functional( 9 banks with 16 gpios = 144). The second instance has only the GPIO0:GPIO67 functional and rest are marked reserved. Signed-off-by: Keerthy <j-keerthy@ti.com> --- The patch depends on the below series: http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2 http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2 Driver patches related are already posted: https://www.spinics.net/lists/arm-kernel/msg594862.html Changes in v2: * Split the documentation part into a separate patch. arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi index bf4d1fa..f9ff299 100644 --- a/arch/arm/boot/dts/keystone-k2g.dtsi +++ b/arch/arm/boot/dts/keystone-k2g.dtsi @@ -15,6 +15,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/pinctrl/keystone.h> +#include <dt-bindings/gpio/gpio.h> / { compatible = "ti,k2g","ti,keystone"; @@ -168,5 +169,46 @@ #reset-cells = <2>; }; }; + + gpio0: gpio at 2603000 { + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; + reg = <0x02603000 0x100>; + gpio-controller; + #gpio-cells = <2>; + + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; + interrupt-controller; + #interrupt-cells = <2>; + ti,ngpio = <144>; + ti,davinci-gpio-unbanked = <0>; + clocks = <&k2g_clks 0x001b 0x0>; + clock-names = "gpio"; + }; + + gpio1: gpio at 260a000 { + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; + reg = <0x0260a000 0x100>; + gpio-controller; + #gpio-cells = <2>; + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>; + interrupt-controller; + #interrupt-cells = <2>; + ti,ngpio = <68>; + ti,davinci-gpio-unbanked = <0>; + clocks = <&k2g_clks 0x001c 0x0>; + clock-names = "gpio"; + }; }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes 2017-07-26 6:45 ` [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy @ 2017-07-26 13:03 ` Suman Anna 2017-07-26 13:29 ` Keerthy 0 siblings, 1 reply; 20+ messages in thread From: Suman Anna @ 2017-07-26 13:03 UTC (permalink / raw) To: linux-arm-kernel Hi Keerthy, On 07/26/2017 01:45 AM, Keerthy wrote: > 66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs > functional( 9 banks with 16 gpios = 144). The second instance has nit, space before ( and not after. > only the GPIO0:GPIO67 functional and rest are marked reserved. s/keystone-k2g-evm/keystone-k2g/ on the patch header please, otherwise this patch looks good. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > The patch depends on the below series: > > http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2 > http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2 FYI, these are already picked up my Santosh and are part of linux-next. regards Suman > > Driver patches related are already posted: > > https://www.spinics.net/lists/arm-kernel/msg594862.html > > Changes in v2: > > * Split the documentation part into a separate patch. > > arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi > index bf4d1fa..f9ff299 100644 > --- a/arch/arm/boot/dts/keystone-k2g.dtsi > +++ b/arch/arm/boot/dts/keystone-k2g.dtsi > @@ -15,6 +15,7 @@ > > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/pinctrl/keystone.h> > +#include <dt-bindings/gpio/gpio.h> > > / { > compatible = "ti,k2g","ti,keystone"; > @@ -168,5 +169,46 @@ > #reset-cells = <2>; > }; > }; > + > + gpio0: gpio at 2603000 { > + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > + reg = <0x02603000 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; > + interrupt-controller; > + #interrupt-cells = <2>; > + ti,ngpio = <144>; > + ti,davinci-gpio-unbanked = <0>; > + clocks = <&k2g_clks 0x001b 0x0>; > + clock-names = "gpio"; > + }; > + > + gpio1: gpio at 260a000 { > + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > + reg = <0x0260a000 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>; > + interrupt-controller; > + #interrupt-cells = <2>; > + ti,ngpio = <68>; > + ti,davinci-gpio-unbanked = <0>; > + clocks = <&k2g_clks 0x001c 0x0>; > + clock-names = "gpio"; > + }; > }; > }; > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes 2017-07-26 13:03 ` Suman Anna @ 2017-07-26 13:29 ` Keerthy 2017-07-26 13:33 ` Russell King - ARM Linux 0 siblings, 1 reply; 20+ messages in thread From: Keerthy @ 2017-07-26 13:29 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 26 July 2017 06:33 PM, Suman Anna wrote: > Hi Keerthy, > > On 07/26/2017 01:45 AM, Keerthy wrote: >> 66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs >> functional( 9 banks with 16 gpios = 144). The second instance has > > nit, space before ( and not after. Sure. > >> only the GPIO0:GPIO67 functional and rest are marked reserved. > > s/keystone-k2g-evm/keystone-k2g/ on the patch header please, otherwise > this patch looks good. Okay. > >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> >> The patch depends on the below series: >> >> http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2 >> http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2 > > FYI, these are already picked up my Santosh and are part of linux-next. Yes saw that now. I will send v4. > > regards > Suman > >> >> Driver patches related are already posted: >> >> https://www.spinics.net/lists/arm-kernel/msg594862.html >> >> Changes in v2: >> >> * Split the documentation part into a separate patch. >> >> arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi >> index bf4d1fa..f9ff299 100644 >> --- a/arch/arm/boot/dts/keystone-k2g.dtsi >> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi >> @@ -15,6 +15,7 @@ >> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> #include <dt-bindings/pinctrl/keystone.h> >> +#include <dt-bindings/gpio/gpio.h> >> >> / { >> compatible = "ti,k2g","ti,keystone"; >> @@ -168,5 +169,46 @@ >> #reset-cells = <2>; >> }; >> }; >> + >> + gpio0: gpio at 2603000 { >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >> + reg = <0x02603000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + >> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <144>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001b 0x0>; >> + clock-names = "gpio"; >> + }; >> + >> + gpio1: gpio at 260a000 { >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >> + reg = <0x0260a000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <68>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001c 0x0>; >> + clock-names = "gpio"; >> + }; >> }; >> }; >> > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes 2017-07-26 13:29 ` Keerthy @ 2017-07-26 13:33 ` Russell King - ARM Linux 2017-07-26 13:43 ` Keerthy 0 siblings, 1 reply; 20+ messages in thread From: Russell King - ARM Linux @ 2017-07-26 13:33 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 26, 2017 at 06:59:58PM +0530, Keerthy wrote: > >> + > >> + gpio0: gpio at 2603000 { > >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > >> + reg = <0x02603000 0x100>; > >> + gpio-controller; > >> + #gpio-cells = <2>; > >> + > >> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; > >> + interrupt-controller; > >> + #interrupt-cells = <2>; > >> + ti,ngpio = <144>; > >> + ti,davinci-gpio-unbanked = <0>; > >> + clocks = <&k2g_clks 0x001b 0x0>; > >> + clock-names = "gpio"; > >> + }; > >> + > >> + gpio1: gpio at 260a000 { > >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > >> + reg = <0x0260a000 0x100>; > >> + gpio-controller; > >> + #gpio-cells = <2>; > >> + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>, > >> + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>; > >> + interrupt-controller; > >> + #interrupt-cells = <2>; > >> + ti,ngpio = <68>; > >> + ti,davinci-gpio-unbanked = <0>; > >> + clocks = <&k2g_clks 0x001c 0x0>; > >> + clock-names = "gpio"; > >> + }; With the addition of GPIO support, does that mean there is a chance to control the noisy fan via the kernel's thermal management? Do we have temperature sensor support for Keystone 2 ? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes 2017-07-26 13:33 ` Russell King - ARM Linux @ 2017-07-26 13:43 ` Keerthy 0 siblings, 0 replies; 20+ messages in thread From: Keerthy @ 2017-07-26 13:43 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 26 July 2017 07:03 PM, Russell King - ARM Linux wrote: > On Wed, Jul 26, 2017 at 06:59:58PM +0530, Keerthy wrote: >>>> + >>>> + gpio0: gpio at 2603000 { >>>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>>> + reg = <0x02603000 0x100>; >>>> + gpio-controller; >>>> + #gpio-cells = <2>; >>>> + >>>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>>> + interrupt-controller; >>>> + #interrupt-cells = <2>; >>>> + ti,ngpio = <144>; >>>> + ti,davinci-gpio-unbanked = <0>; >>>> + clocks = <&k2g_clks 0x001b 0x0>; >>>> + clock-names = "gpio"; >>>> + }; >>>> + >>>> + gpio1: gpio at 260a000 { >>>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>>> + reg = <0x0260a000 0x100>; >>>> + gpio-controller; >>>> + #gpio-cells = <2>; >>>> + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>; >>>> + interrupt-controller; >>>> + #interrupt-cells = <2>; >>>> + ti,ngpio = <68>; >>>> + ti,davinci-gpio-unbanked = <0>; >>>> + clocks = <&k2g_clks 0x001c 0x0>; >>>> + clock-names = "gpio"; >>>> + }; > > With the addition of GPIO support, does that mean there is a chance to > control the noisy fan via the kernel's thermal management? Do we have > temperature sensor support for Keystone 2 ? Russell, GPIO support using davinci driver for K2HK/L/E was there for a long time here: arch/arm/boot/dts/keystone.dtsi commit 970c225636ac4ae98739094d6b6bbf2bdc3694f9 Author: Grygorii Strashko <grygorii.strashko@ti.com> Date: Mon Feb 10 18:41:18 2014 +0200 ARM: dts: keystone: add gpio device entry I have only added the k2g nodes now as it is different compared to other keystone 2 platforms. I believe there is no temperature sensor support for Keystone 2 yet. Regards, Keerthy > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 6:45 [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Keerthy 2017-07-26 6:45 ` [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy @ 2017-07-26 13:00 ` Suman Anna 2017-07-26 13:27 ` Franklin S Cooper Jr 2017-07-26 13:33 ` Keerthy 2017-08-02 9:29 ` Linus Walleij 2017-08-03 16:17 ` Rob Herring 3 siblings, 2 replies; 20+ messages in thread From: Suman Anna @ 2017-07-26 13:00 UTC (permalink / raw) To: linux-arm-kernel Hi Keerthy, On 07/26/2017 01:45 AM, Keerthy wrote: > The patch adds keystone-k2g compatible, specific properties and > an example. Please update patch header to "dt-bindings: gpio: davinci: ...." > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > Changes in v3: > > * Added details about family of SoCs corresponding to compatibles. > > .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt > index 5079ba7..fb9efee 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt > @@ -1,7 +1,10 @@ > Davinci/Keystone GPIO controller bindings > > Required Properties: > -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" > +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs > + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, > + 66AK2E SoCs > + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G > > - reg: Physical base address of the controller and the size of memory mapped > registers. > @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default > two cells specifier as described in Documentation/devicetree/bindings/ > interrupt-controller/interrupts.txt. > > +Required Properties specific to keystone-k2g Thanks for updating the binding for the clocks, but clocks are not specific to K2G. They also apply to other K2 SoCs. Davinci platforms do not have DT clocks atm, so the Davinci portion can be updated later if and when they get added. > + > +- clocks: Should contain devices input clock. The first parameter > + is a handle to k2g_clks. The second parameter is the > + device ID and the third parameter is the clock ID. One can > + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data No need for this link here, just refer to the appropriate clock bindings. Some thing like the following would be better - clocks: Should contain the device's input clock, and should be defined as per the appropriate clock bindings consumer usage in, Documentation/devicetree/bindings/clock/keystone-gate.txt for 66AK2HK/66AK2L/66AK2E SoCs or, Documentation/devicetree/bindings/clock/ti,sci-clk.txt for 66AK2G SoCs > + > + Example: <&k2g_clks 0x001c 0x0>; This can be dropped as well, below example already demonstrates it. > + > +- clock-names: The driver expects the clock name to be "gpio"; Just say, Should be "gpio". No need of mentioning about the driver. > + > Example: > > gpio: gpio at 1e26000 { > @@ -60,3 +74,27 @@ leds { > ... > }; > }; > + > +Example for keystone-k2g: s/keystone-k2g/66AK2G/ > + > +gpio0: gpio at 2603000 { > + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > + reg = <0x02603000 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; > + interrupt-controller; > + #interrupt-cells = <2>; > + ti,ngpio = <144>; > + ti,davinci-gpio-unbanked = <0>; > + clocks = <&k2g_clks 0x001b 0x0>; > + clock-names = "gpio"; > +}; > regards Suman ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 13:00 ` [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Suman Anna @ 2017-07-26 13:27 ` Franklin S Cooper Jr 2017-07-26 13:35 ` Suman Anna 2017-07-26 13:36 ` Keerthy 2017-07-26 13:33 ` Keerthy 1 sibling, 2 replies; 20+ messages in thread From: Franklin S Cooper Jr @ 2017-07-26 13:27 UTC (permalink / raw) To: linux-arm-kernel On 07/26/2017 08:00 AM, Suman Anna wrote: > Hi Keerthy, > > On 07/26/2017 01:45 AM, Keerthy wrote: >> The patch adds keystone-k2g compatible, specific properties and >> an example. Seems we are adding information regarding several Keystone 2 SoCs. So the commit and subject should be tweaked to reflect this. > > Please update patch header to "dt-bindings: gpio: davinci: ...." > >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> >> Changes in v3: >> >> * Added details about family of SoCs corresponding to compatibles. >> >> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> index 5079ba7..fb9efee 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -1,7 +1,10 @@ >> Davinci/Keystone GPIO controller bindings >> >> Required Properties: >> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >> + 66AK2E SoCs >> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >> >> - reg: Physical base address of the controller and the size of memory mapped >> registers. >> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >> two cells specifier as described in Documentation/devicetree/bindings/ >> interrupt-controller/interrupts.txt. >> >> +Required Properties specific to keystone-k2g > > Thanks for updating the binding for the clocks, but clocks are not > specific to K2G. They also apply to other K2 SoCs. Davinci platforms do > not have DT clocks atm, so the Davinci portion can be updated later if > and when they get added. > What about power-domain property? >> + >> +- clocks: Should contain devices input clock. The first parameter >> + is a handle to k2g_clks. The second parameter is the >> + device ID and the third parameter is the clock ID. One can >> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data > > No need for this link here, just refer to the appropriate clock > bindings. Some thing like the following would be better This information is helpful especially with the macros being dropped. However, I agree that this is not the place for this information. Probably should be linked to in the ti,sci-clk.txt and sci-pm-domain.txt. However, both of these are outdated since it is referring to macros and includes that don't exist or will no longer exist. > > - clocks: Should contain the device's input clock, and > should be defined as per the appropriate clock > bindings consumer usage in, > > Documentation/devicetree/bindings/clock/keystone-gate.txt > for 66AK2HK/66AK2L/66AK2E SoCs or, > > Documentation/devicetree/bindings/clock/ti,sci-clk.txt > for 66AK2G SoCs > >> + >> + Example: <&k2g_clks 0x001c 0x0>; > > This can be dropped as well, below example already demonstrates it. > >> + >> +- clock-names: The driver expects the clock name to be "gpio"; > > Just say, Should be "gpio". No need of mentioning about the driver. > >> + >> Example: >> >> gpio: gpio at 1e26000 { >> @@ -60,3 +74,27 @@ leds { >> ... >> }; >> }; >> + >> +Example for keystone-k2g: > > s/keystone-k2g/66AK2G/ > >> + >> +gpio0: gpio at 2603000 { >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >> + reg = <0x02603000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <144>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001b 0x0>; >> + clock-names = "gpio"; >> +}; If your going to talk about other Keystone 2 devices it would be helpful to include an example for one of them since they have slightly different properties. >> > > regards > Suman > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 13:27 ` Franklin S Cooper Jr @ 2017-07-26 13:35 ` Suman Anna 2017-07-26 13:36 ` Keerthy 1 sibling, 0 replies; 20+ messages in thread From: Suman Anna @ 2017-07-26 13:35 UTC (permalink / raw) To: linux-arm-kernel Franklin, On 07/26/2017 08:27 AM, Franklin S Cooper Jr wrote: > > On 07/26/2017 08:00 AM, Suman Anna wrote: >> Hi Keerthy, >> >> On 07/26/2017 01:45 AM, Keerthy wrote: >>> The patch adds keystone-k2g compatible, specific properties and >>> an example. > > Seems we are adding information regarding several Keystone 2 SoCs. So > the commit and subject should be tweaked to reflect this. >> >> Please update patch header to "dt-bindings: gpio: davinci: ...." >> >>> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> --- >>> >>> Changes in v3: >>> >>> * Added details about family of SoCs corresponding to compatibles. >>> >>> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >>> 1 file changed, 39 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> index 5079ba7..fb9efee 100644 >>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> @@ -1,7 +1,10 @@ >>> Davinci/Keystone GPIO controller bindings >>> >>> Required Properties: >>> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >>> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >>> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >>> + 66AK2E SoCs >>> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >>> >>> - reg: Physical base address of the controller and the size of memory mapped >>> registers. >>> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >>> two cells specifier as described in Documentation/devicetree/bindings/ >>> interrupt-controller/interrupts.txt. >>> >>> +Required Properties specific to keystone-k2g >> >> Thanks for updating the binding for the clocks, but clocks are not >> specific to K2G. They also apply to other K2 SoCs. Davinci platforms do >> not have DT clocks atm, so the Davinci portion can be updated later if >> and when they get added. >> > > What about power-domain property? > >>> + >>> +- clocks: Should contain devices input clock. The first parameter >>> + is a handle to k2g_clks. The second parameter is the >>> + device ID and the third parameter is the clock ID. One can >>> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data >> >> No need for this link here, just refer to the appropriate clock >> bindings. Some thing like the following would be better > > This information is helpful especially with the macros being dropped. > However, I agree that this is not the place for this information. > Probably should be linked to in the ti,sci-clk.txt and > sci-pm-domain.txt. However, both of these are outdated since it is > referring to macros and includes that don't exist or will no longer exist. You are probably looking at the bindings on current master. These have already been addressed/updated, lookup linux-next. regards Suman > >> >> - clocks: Should contain the device's input clock, and >> should be defined as per the appropriate clock >> bindings consumer usage in, >> >> Documentation/devicetree/bindings/clock/keystone-gate.txt >> for 66AK2HK/66AK2L/66AK2E SoCs or, >> >> Documentation/devicetree/bindings/clock/ti,sci-clk.txt >> for 66AK2G SoCs >> >>> + >>> + Example: <&k2g_clks 0x001c 0x0>; >> >> This can be dropped as well, below example already demonstrates it. >> >>> + >>> +- clock-names: The driver expects the clock name to be "gpio"; >> >> Just say, Should be "gpio". No need of mentioning about the driver. >> >>> + >>> Example: >>> >>> gpio: gpio at 1e26000 { >>> @@ -60,3 +74,27 @@ leds { >>> ... >>> }; >>> }; >>> + >>> +Example for keystone-k2g: >> >> s/keystone-k2g/66AK2G/ >> >>> + >>> +gpio0: gpio at 2603000 { >>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>> + reg = <0x02603000 0x100>; >>> + gpio-controller; >>> + #gpio-cells = <2>; >>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>> + interrupt-controller; >>> + #interrupt-cells = <2>; >>> + ti,ngpio = <144>; >>> + ti,davinci-gpio-unbanked = <0>; >>> + clocks = <&k2g_clks 0x001b 0x0>; >>> + clock-names = "gpio"; >>> +}; > > If your going to talk about other Keystone 2 devices it would be helpful > to include an example for one of them since they have slightly different > properties. >>> >> >> regards >> Suman >> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 13:27 ` Franklin S Cooper Jr 2017-07-26 13:35 ` Suman Anna @ 2017-07-26 13:36 ` Keerthy 2017-07-26 14:20 ` Suman Anna 1 sibling, 1 reply; 20+ messages in thread From: Keerthy @ 2017-07-26 13:36 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: > > > On 07/26/2017 08:00 AM, Suman Anna wrote: >> Hi Keerthy, >> >> On 07/26/2017 01:45 AM, Keerthy wrote: >>> The patch adds keystone-k2g compatible, specific properties and >>> an example. > > Seems we are adding information regarding several Keystone 2 SoCs. So > the commit and subject should be tweaked to reflect this. Okay i can add that as well. >> >> Please update patch header to "dt-bindings: gpio: davinci: ...." >> >>> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> --- >>> >>> Changes in v3: >>> >>> * Added details about family of SoCs corresponding to compatibles. >>> >>> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >>> 1 file changed, 39 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> index 5079ba7..fb9efee 100644 >>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>> @@ -1,7 +1,10 @@ >>> Davinci/Keystone GPIO controller bindings >>> >>> Required Properties: >>> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >>> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >>> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >>> + 66AK2E SoCs >>> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >>> >>> - reg: Physical base address of the controller and the size of memory mapped >>> registers. >>> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >>> two cells specifier as described in Documentation/devicetree/bindings/ >>> interrupt-controller/interrupts.txt. >>> >>> +Required Properties specific to keystone-k2g >> >> Thanks for updating the binding for the clocks, but clocks are not >> specific to K2G. They also apply to other K2 SoCs. Davinci platforms do >> not have DT clocks atm, so the Davinci portion can be updated later if >> and when they get added. >> > > What about power-domain property? Driver has no pm_runtime implemented yet. > >>> + >>> +- clocks: Should contain devices input clock. The first parameter >>> + is a handle to k2g_clks. The second parameter is the >>> + device ID and the third parameter is the clock ID. One can >>> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data >> >> No need for this link here, just refer to the appropriate clock >> bindings. Some thing like the following would be better > > This information is helpful especially with the macros being dropped. > However, I agree that this is not the place for this information. > Probably should be linked to in the ti,sci-clk.txt and > sci-pm-domain.txt. However, both of these are outdated since it is > referring to macros and includes that don't exist or will no longer exist. Hence included here but yes i can point to something like what Suman asked me to. > >> >> - clocks: Should contain the device's input clock, and >> should be defined as per the appropriate clock >> bindings consumer usage in, >> >> Documentation/devicetree/bindings/clock/keystone-gate.txt >> for 66AK2HK/66AK2L/66AK2E SoCs or, >> >> Documentation/devicetree/bindings/clock/ti,sci-clk.txt >> for 66AK2G SoCs >> >>> + >>> + Example: <&k2g_clks 0x001c 0x0>; >> >> This can be dropped as well, below example already demonstrates it. >> >>> + >>> +- clock-names: The driver expects the clock name to be "gpio"; >> >> Just say, Should be "gpio". No need of mentioning about the driver. >> >>> + >>> Example: >>> >>> gpio: gpio at 1e26000 { >>> @@ -60,3 +74,27 @@ leds { >>> ... >>> }; >>> }; >>> + >>> +Example for keystone-k2g: >> >> s/keystone-k2g/66AK2G/ >> >>> + >>> +gpio0: gpio at 2603000 { >>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>> + reg = <0x02603000 0x100>; >>> + gpio-controller; >>> + #gpio-cells = <2>; >>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>> + interrupt-controller; >>> + #interrupt-cells = <2>; >>> + ti,ngpio = <144>; >>> + ti,davinci-gpio-unbanked = <0>; >>> + clocks = <&k2g_clks 0x001b 0x0>; >>> + clock-names = "gpio"; >>> +}; > > If your going to talk about other Keystone 2 devices it would be helpful > to include an example for one of them since they have slightly different > properties. Sure. >>> >> >> regards >> Suman >> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 13:36 ` Keerthy @ 2017-07-26 14:20 ` Suman Anna 2017-07-26 18:37 ` Franklin S Cooper Jr 2017-07-31 13:44 ` Keerthy 0 siblings, 2 replies; 20+ messages in thread From: Suman Anna @ 2017-07-26 14:20 UTC (permalink / raw) To: linux-arm-kernel On 07/26/2017 08:36 AM, Keerthy wrote: > > On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >> >> >> On 07/26/2017 08:00 AM, Suman Anna wrote: >>> Hi Keerthy, >>> >>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>> The patch adds keystone-k2g compatible, specific properties and >>>> an example. >> >> Seems we are adding information regarding several Keystone 2 SoCs. So >> the commit and subject should be tweaked to reflect this. > > Okay i can add that as well. > >>> >>> Please update patch header to "dt-bindings: gpio: davinci: ...." >>> >>>> >>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>> --- >>>> >>>> Changes in v3: >>>> >>>> * Added details about family of SoCs corresponding to compatibles. >>>> >>>> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >>>> 1 file changed, 39 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>> index 5079ba7..fb9efee 100644 >>>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>> @@ -1,7 +1,10 @@ >>>> Davinci/Keystone GPIO controller bindings >>>> >>>> Required Properties: >>>> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >>>> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >>>> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >>>> + 66AK2E SoCs >>>> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >>>> >>>> - reg: Physical base address of the controller and the size of memory mapped >>>> registers. >>>> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >>>> two cells specifier as described in Documentation/devicetree/bindings/ >>>> interrupt-controller/interrupts.txt. >>>> >>>> +Required Properties specific to keystone-k2g >>> >>> Thanks for updating the binding for the clocks, but clocks are not >>> specific to K2G. They also apply to other K2 SoCs. Davinci platforms do >>> not have DT clocks atm, so the Davinci portion can be updated later if >>> and when they get added. >>> >> >> What about power-domain property? The correct name is "power-domains". > Driver has no pm_runtime implemented yet. True, not yet, but this is in general a required property on K2G SoCs to automatically enable clocks through runtime_pm. Clock properties on K2G nodes should only be truly required if a driver is using clk API (ideally to control optional clocks or for adjusting clock frequencies). When the gpio-davinci driver gets updated to use pm_runtime, the clock properties will be rendered obsolete for K2G. Rob, Any suggestions on how we need to handle this? Should we be adding the property now or later when we adapt the driver for runtime_pm? This would be a common theme for K2G nodes that are reusing Davinci drivers. My take on this would be to add the property now, and mark the clock properties obsolete when the driver gets converted. regards Suman > >> >>>> + >>>> +- clocks: Should contain devices input clock. The first parameter >>>> + is a handle to k2g_clks. The second parameter is the >>>> + device ID and the third parameter is the clock ID. One can >>>> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data >>> >>> No need for this link here, just refer to the appropriate clock >>> bindings. Some thing like the following would be better >> >> This information is helpful especially with the macros being dropped. >> However, I agree that this is not the place for this information. >> Probably should be linked to in the ti,sci-clk.txt and >> sci-pm-domain.txt. However, both of these are outdated since it is >> referring to macros and includes that don't exist or will no longer exist. > > Hence included here but yes i can point to something like what Suman > asked me to. > >> >>> >>> - clocks: Should contain the device's input clock, and >>> should be defined as per the appropriate clock >>> bindings consumer usage in, >>> >>> Documentation/devicetree/bindings/clock/keystone-gate.txt >>> for 66AK2HK/66AK2L/66AK2E SoCs or, >>> >>> Documentation/devicetree/bindings/clock/ti,sci-clk.txt >>> for 66AK2G SoCs >>> >>>> + >>>> + Example: <&k2g_clks 0x001c 0x0>; >>> >>> This can be dropped as well, below example already demonstrates it. >>> >>>> + >>>> +- clock-names: The driver expects the clock name to be "gpio"; >>> >>> Just say, Should be "gpio". No need of mentioning about the driver. >>> >>>> + >>>> Example: >>>> >>>> gpio: gpio at 1e26000 { >>>> @@ -60,3 +74,27 @@ leds { >>>> ... >>>> }; >>>> }; >>>> + >>>> +Example for keystone-k2g: >>> >>> s/keystone-k2g/66AK2G/ >>> >>>> + >>>> +gpio0: gpio at 2603000 { >>>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>>> + reg = <0x02603000 0x100>; >>>> + gpio-controller; >>>> + #gpio-cells = <2>; >>>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>>> + interrupt-controller; >>>> + #interrupt-cells = <2>; >>>> + ti,ngpio = <144>; >>>> + ti,davinci-gpio-unbanked = <0>; >>>> + clocks = <&k2g_clks 0x001b 0x0>; >>>> + clock-names = "gpio"; >>>> +}; >> >> If your going to talk about other Keystone 2 devices it would be helpful >> to include an example for one of them since they have slightly different >> properties. > > Sure. > >>>> >>> >>> regards >>> Suman >>> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 14:20 ` Suman Anna @ 2017-07-26 18:37 ` Franklin S Cooper Jr 2017-07-31 13:44 ` Keerthy 1 sibling, 0 replies; 20+ messages in thread From: Franklin S Cooper Jr @ 2017-07-26 18:37 UTC (permalink / raw) To: linux-arm-kernel On 07/26/2017 09:20 AM, Suman Anna wrote: > On 07/26/2017 08:36 AM, Keerthy wrote: >> >> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >>> >>> >>> On 07/26/2017 08:00 AM, Suman Anna wrote: >>>> Hi Keerthy, >>>> >>>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>>> The patch adds keystone-k2g compatible, specific properties and >>>>> an example. >>> >>> Seems we are adding information regarding several Keystone 2 SoCs. So >>> the commit and subject should be tweaked to reflect this. >> >> Okay i can add that as well. >> >>>> >>>> Please update patch header to "dt-bindings: gpio: davinci: ...." >>>> >>>>> >>>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>>> --- >>>>> >>>>> Changes in v3: >>>>> >>>>> * Added details about family of SoCs corresponding to compatibles. >>>>> >>>>> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >>>>> 1 file changed, 39 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> index 5079ba7..fb9efee 100644 >>>>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> @@ -1,7 +1,10 @@ >>>>> Davinci/Keystone GPIO controller bindings >>>>> >>>>> Required Properties: >>>>> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >>>>> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >>>>> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >>>>> + 66AK2E SoCs >>>>> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >>>>> >>>>> - reg: Physical base address of the controller and the size of memory mapped >>>>> registers. >>>>> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >>>>> two cells specifier as described in Documentation/devicetree/bindings/ >>>>> interrupt-controller/interrupts.txt. >>>>> >>>>> +Required Properties specific to keystone-k2g >>>> >>>> Thanks for updating the binding for the clocks, but clocks are not >>>> specific to K2G. They also apply to other K2 SoCs. Davinci platforms do >>>> not have DT clocks atm, so the Davinci portion can be updated later if >>>> and when they get added. >>>> >>> >>> What about power-domain property? > > The correct name is "power-domains". > >> Driver has no pm_runtime implemented yet. > > True, not yet, but this is in general a required property on K2G SoCs to > automatically enable clocks through runtime_pm. Clock properties on K2G > nodes should only be truly required if a driver is using clk API > (ideally to control optional clocks or for adjusting clock frequencies). > When the gpio-davinci driver gets updated to use pm_runtime, the clock > properties will be rendered obsolete for K2G. Now I understand better when we do or do not need this property after some offline discussion. If the driver doesn't support pm_runtime then no point in adding this property. Binding should discuss how to use the current driver. Not how a feature that may never exist may possibly be used. > > Rob, > Any suggestions on how we need to handle this? Should we be adding the > property now or later when we adapt the driver for runtime_pm? This > would be a common theme for K2G nodes that are reusing Davinci drivers. > > My take on this would be to add the property now, and mark the clock > properties obsolete when the driver gets converted. > > regards > Suman > >> >>> >>>>> + >>>>> +- clocks: Should contain devices input clock. The first parameter >>>>> + is a handle to k2g_clks. The second parameter is the >>>>> + device ID and the third parameter is the clock ID. One can >>>>> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data >>>> >>>> No need for this link here, just refer to the appropriate clock >>>> bindings. Some thing like the following would be better >>> >>> This information is helpful especially with the macros being dropped. >>> However, I agree that this is not the place for this information. >>> Probably should be linked to in the ti,sci-clk.txt and >>> sci-pm-domain.txt. However, both of these are outdated since it is >>> referring to macros and includes that don't exist or will no longer exist. >> >> Hence included here but yes i can point to something like what Suman >> asked me to. >> >>> >>>> >>>> - clocks: Should contain the device's input clock, and >>>> should be defined as per the appropriate clock >>>> bindings consumer usage in, >>>> >>>> Documentation/devicetree/bindings/clock/keystone-gate.txt >>>> for 66AK2HK/66AK2L/66AK2E SoCs or, >>>> >>>> Documentation/devicetree/bindings/clock/ti,sci-clk.txt >>>> for 66AK2G SoCs >>>> >>>>> + >>>>> + Example: <&k2g_clks 0x001c 0x0>; >>>> >>>> This can be dropped as well, below example already demonstrates it. >>>> >>>>> + >>>>> +- clock-names: The driver expects the clock name to be "gpio"; >>>> >>>> Just say, Should be "gpio". No need of mentioning about the driver. >>>> >>>>> + >>>>> Example: >>>>> >>>>> gpio: gpio at 1e26000 { >>>>> @@ -60,3 +74,27 @@ leds { >>>>> ... >>>>> }; >>>>> }; >>>>> + >>>>> +Example for keystone-k2g: >>>> >>>> s/keystone-k2g/66AK2G/ >>>> >>>>> + >>>>> +gpio0: gpio at 2603000 { >>>>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>>>> + reg = <0x02603000 0x100>; >>>>> + gpio-controller; >>>>> + #gpio-cells = <2>; >>>>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>>>> + interrupt-controller; >>>>> + #interrupt-cells = <2>; >>>>> + ti,ngpio = <144>; >>>>> + ti,davinci-gpio-unbanked = <0>; >>>>> + clocks = <&k2g_clks 0x001b 0x0>; >>>>> + clock-names = "gpio"; >>>>> +}; >>> >>> If your going to talk about other Keystone 2 devices it would be helpful >>> to include an example for one of them since they have slightly different >>> properties. >> >> Sure. >> >>>>> >>>> >>>> regards >>>> Suman >>>> > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 14:20 ` Suman Anna 2017-07-26 18:37 ` Franklin S Cooper Jr @ 2017-07-31 13:44 ` Keerthy 2017-08-01 6:12 ` Vignesh R 1 sibling, 1 reply; 20+ messages in thread From: Keerthy @ 2017-07-31 13:44 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote: > On 07/26/2017 08:36 AM, Keerthy wrote: >> >> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >>> >>> >>> On 07/26/2017 08:00 AM, Suman Anna wrote: >>>> Hi Keerthy, >>>> >>>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>>> The patch adds keystone-k2g compatible, specific properties and >>>>> an example. >>> >>> Seems we are adding information regarding several Keystone 2 SoCs. So >>> the commit and subject should be tweaked to reflect this. >> >> Okay i can add that as well. >> >>>> >>>> Please update patch header to "dt-bindings: gpio: davinci: ...." >>>> >>>>> >>>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>>> --- >>>>> >>>>> Changes in v3: >>>>> >>>>> * Added details about family of SoCs corresponding to compatibles. >>>>> >>>>> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >>>>> 1 file changed, 39 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> index 5079ba7..fb9efee 100644 >>>>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >>>>> @@ -1,7 +1,10 @@ >>>>> Davinci/Keystone GPIO controller bindings >>>>> >>>>> Required Properties: >>>>> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >>>>> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >>>>> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >>>>> + 66AK2E SoCs >>>>> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >>>>> >>>>> - reg: Physical base address of the controller and the size of memory mapped >>>>> registers. >>>>> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >>>>> two cells specifier as described in Documentation/devicetree/bindings/ >>>>> interrupt-controller/interrupts.txt. >>>>> >>>>> +Required Properties specific to keystone-k2g >>>> >>>> Thanks for updating the binding for the clocks, but clocks are not >>>> specific to K2G. They also apply to other K2 SoCs. Davinci platforms do >>>> not have DT clocks atm, so the Davinci portion can be updated later if >>>> and when they get added. >>>> >>> >>> What about power-domain property? > > The correct name is "power-domains". > >> Driver has no pm_runtime implemented yet. > > True, not yet, but this is in general a required property on K2G SoCs to > automatically enable clocks through runtime_pm. Clock properties on K2G > nodes should only be truly required if a driver is using clk API > (ideally to control optional clocks or for adjusting clock frequencies). > When the gpio-davinci driver gets updated to use pm_runtime, the clock > properties will be rendered obsolete for K2G. > > Rob, > Any suggestions on how we need to handle this? Should we be adding the > property now or later when we adapt the driver for runtime_pm? This > would be a common theme for K2G nodes that are reusing Davinci drivers. > > My take on this would be to add the property now, and mark the clock > properties obsolete when the driver gets converted. Rob, Any comments on this? Regards, Keerthy > > regards > Suman > >> >>> >>>>> + >>>>> +- clocks: Should contain devices input clock. The first parameter >>>>> + is a handle to k2g_clks. The second parameter is the >>>>> + device ID and the third parameter is the clock ID. One can >>>>> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data >>>> >>>> No need for this link here, just refer to the appropriate clock >>>> bindings. Some thing like the following would be better >>> >>> This information is helpful especially with the macros being dropped. >>> However, I agree that this is not the place for this information. >>> Probably should be linked to in the ti,sci-clk.txt and >>> sci-pm-domain.txt. However, both of these are outdated since it is >>> referring to macros and includes that don't exist or will no longer exist. >> >> Hence included here but yes i can point to something like what Suman >> asked me to. >> >>> >>>> >>>> - clocks: Should contain the device's input clock, and >>>> should be defined as per the appropriate clock >>>> bindings consumer usage in, >>>> >>>> Documentation/devicetree/bindings/clock/keystone-gate.txt >>>> for 66AK2HK/66AK2L/66AK2E SoCs or, >>>> >>>> Documentation/devicetree/bindings/clock/ti,sci-clk.txt >>>> for 66AK2G SoCs >>>> >>>>> + >>>>> + Example: <&k2g_clks 0x001c 0x0>; >>>> >>>> This can be dropped as well, below example already demonstrates it. >>>> >>>>> + >>>>> +- clock-names: The driver expects the clock name to be "gpio"; >>>> >>>> Just say, Should be "gpio". No need of mentioning about the driver. >>>> >>>>> + >>>>> Example: >>>>> >>>>> gpio: gpio at 1e26000 { >>>>> @@ -60,3 +74,27 @@ leds { >>>>> ... >>>>> }; >>>>> }; >>>>> + >>>>> +Example for keystone-k2g: >>>> >>>> s/keystone-k2g/66AK2G/ >>>> >>>>> + >>>>> +gpio0: gpio at 2603000 { >>>>> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >>>>> + reg = <0x02603000 0x100>; >>>>> + gpio-controller; >>>>> + #gpio-cells = <2>; >>>>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >>>>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >>>>> + interrupt-controller; >>>>> + #interrupt-cells = <2>; >>>>> + ti,ngpio = <144>; >>>>> + ti,davinci-gpio-unbanked = <0>; >>>>> + clocks = <&k2g_clks 0x001b 0x0>; >>>>> + clock-names = "gpio"; >>>>> +}; >>> >>> If your going to talk about other Keystone 2 devices it would be helpful >>> to include an example for one of them since they have slightly different >>> properties. >> >> Sure. >> >>>>> >>>> >>>> regards >>>> Suman >>>> > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-31 13:44 ` Keerthy @ 2017-08-01 6:12 ` Vignesh R 2017-08-01 14:30 ` Suman Anna 0 siblings, 1 reply; 20+ messages in thread From: Vignesh R @ 2017-08-01 6:12 UTC (permalink / raw) To: linux-arm-kernel On Monday 31 July 2017 07:14 PM, Keerthy wrote: > > > On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote: >> On 07/26/2017 08:36 AM, Keerthy wrote: >>> >>> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >>>> >>>> >>>> On 07/26/2017 08:00 AM, Suman Anna wrote: >>>>> Hi Keerthy, >>>>> >>>>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>>>> The patch adds keystone-k2g compatible, specific properties and >>>>>> an example. >>>> [...] >>>>> >>>> >>>> What about power-domain property? >> >> The correct name is "power-domains". >> >>> Driver has no pm_runtime implemented yet. >> >> True, not yet, but this is in general a required property on K2G SoCs to >> automatically enable clocks through runtime_pm. Clock properties on K2G >> nodes should only be truly required if a driver is using clk API >> (ideally to control optional clocks or for adjusting clock frequencies). >> When the gpio-davinci driver gets updated to use pm_runtime, the clock >> properties will be rendered obsolete for K2G. >> >> Rob, >> Any suggestions on how we need to handle this? Should we be adding the >> property now or later when we adapt the driver for runtime_pm? This >> would be a common theme for K2G nodes that are reusing Davinci drivers. >> >> My take on this would be to add the property now, and mark the clock >> properties obsolete when the driver gets converted. > I don't think SoC wide properties are put into device specific binding documentation, for example pinctrl bindings are not put into device documentation. > Rob, > > Any comments on this? > [...] -- Regards Vignesh ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-08-01 6:12 ` Vignesh R @ 2017-08-01 14:30 ` Suman Anna 2017-08-01 15:49 ` Franklin S Cooper Jr 0 siblings, 1 reply; 20+ messages in thread From: Suman Anna @ 2017-08-01 14:30 UTC (permalink / raw) To: linux-arm-kernel On 08/01/2017 01:12 AM, Vignesh R wrote: > > > On Monday 31 July 2017 07:14 PM, Keerthy wrote: >> >> >> On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote: >>> On 07/26/2017 08:36 AM, Keerthy wrote: >>>> >>>> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >>>>> >>>>> >>>>> On 07/26/2017 08:00 AM, Suman Anna wrote: >>>>>> Hi Keerthy, >>>>>> >>>>>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>>>>> The patch adds keystone-k2g compatible, specific properties and >>>>>>> an example. >>>>> > [...] >>>>>> >>>>> >>>>> What about power-domain property? >>> >>> The correct name is "power-domains". >>> >>>> Driver has no pm_runtime implemented yet. >>> >>> True, not yet, but this is in general a required property on K2G SoCs to >>> automatically enable clocks through runtime_pm. Clock properties on K2G >>> nodes should only be truly required if a driver is using clk API >>> (ideally to control optional clocks or for adjusting clock frequencies). >>> When the gpio-davinci driver gets updated to use pm_runtime, the clock >>> properties will be rendered obsolete for K2G. >>> >>> Rob, >>> Any suggestions on how we need to handle this? Should we be adding the >>> property now or later when we adapt the driver for runtime_pm? This >>> would be a common theme for K2G nodes that are reusing Davinci drivers. >>> >>> My take on this would be to add the property now, and mark the clock >>> properties obsolete when the driver gets converted. >> > > I don't think SoC wide properties are put into device specific binding > documentation, for example pinctrl bindings are not put into device > documentation. I wouldn't compare this to pinctrl bindings exactly but more similar to clocks or the ti,hwmods on OMAP/AM platforms. I see lot of other bindings documenting the power-domains property just as well. regards Suman > >> Rob, >> >> Any comments on this? >> > > [...] > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-08-01 14:30 ` Suman Anna @ 2017-08-01 15:49 ` Franklin S Cooper Jr 0 siblings, 0 replies; 20+ messages in thread From: Franklin S Cooper Jr @ 2017-08-01 15:49 UTC (permalink / raw) To: linux-arm-kernel On 08/01/2017 09:30 AM, Suman Anna wrote: > On 08/01/2017 01:12 AM, Vignesh R wrote: >> >> >> On Monday 31 July 2017 07:14 PM, Keerthy wrote: >>> >>> >>> On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote: >>>> On 07/26/2017 08:36 AM, Keerthy wrote: >>>>> >>>>> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote: >>>>>> >>>>>> >>>>>> On 07/26/2017 08:00 AM, Suman Anna wrote: >>>>>>> Hi Keerthy, >>>>>>> >>>>>>> On 07/26/2017 01:45 AM, Keerthy wrote: >>>>>>>> The patch adds keystone-k2g compatible, specific properties and >>>>>>>> an example. >>>>>> >> [...] >>>>>>> >>>>>> >>>>>> What about power-domain property? >>>> >>>> The correct name is "power-domains". >>>> >>>>> Driver has no pm_runtime implemented yet. >>>> >>>> True, not yet, but this is in general a required property on K2G SoCs to >>>> automatically enable clocks through runtime_pm. Clock properties on K2G >>>> nodes should only be truly required if a driver is using clk API >>>> (ideally to control optional clocks or for adjusting clock frequencies). >>>> When the gpio-davinci driver gets updated to use pm_runtime, the clock >>>> properties will be rendered obsolete for K2G. >>>> >>>> Rob, >>>> Any suggestions on how we need to handle this? Should we be adding the >>>> property now or later when we adapt the driver for runtime_pm? This >>>> would be a common theme for K2G nodes that are reusing Davinci drivers. >>>> >>>> My take on this would be to add the property now, and mark the clock >>>> properties obsolete when the driver gets converted. >>> >> >> I don't think SoC wide properties are put into device specific binding >> documentation, for example pinctrl bindings are not put into device >> documentation. > > I wouldn't compare this to pinctrl bindings exactly but more similar to > clocks or the ti,hwmods on OMAP/AM platforms. I see lot of other > bindings documenting the power-domains property just as well. The issue is that 66AK2G utilizes drivers from both Keystone/Davinci and OMAP SoC architectures that handles clock and pm in different ways. So for various reasons some drivers just need the power-domain property which is new and unique to 66AK2G and other drivers just need the clocks property while others may also need the clock-names property. This lack of consistency makes properly documenting things important. Also 66AK2G will never used hwmod property so avoiding that confusion will also be helpful if the current bindings document does include references to hwmod. > > regards > Suman > >> >>> Rob, >>> >>> Any comments on this? >>> >> >> [...] >> > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 13:00 ` [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Suman Anna 2017-07-26 13:27 ` Franklin S Cooper Jr @ 2017-07-26 13:33 ` Keerthy 1 sibling, 0 replies; 20+ messages in thread From: Keerthy @ 2017-07-26 13:33 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 26 July 2017 06:30 PM, Suman Anna wrote: > Hi Keerthy, > > On 07/26/2017 01:45 AM, Keerthy wrote: >> The patch adds keystone-k2g compatible, specific properties and >> an example. > > Please update patch header to "dt-bindings: gpio: davinci: ...." Okay > >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> >> Changes in v3: >> >> * Added details about family of SoCs corresponding to compatibles. >> >> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> index 5079ba7..fb9efee 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -1,7 +1,10 @@ >> Davinci/Keystone GPIO controller bindings >> >> Required Properties: >> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >> +- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs >> + "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L, >> + 66AK2E SoCs >> + "ti,keystone-k2g-gpio", "ti,keystone-gpio": for 66AK2G >> >> - reg: Physical base address of the controller and the size of memory mapped >> registers. >> @@ -26,6 +29,17 @@ The GPIO controller also acts as an interrupt controller. It uses the default >> two cells specifier as described in Documentation/devicetree/bindings/ >> interrupt-controller/interrupts.txt. >> >> +Required Properties specific to keystone-k2g > > Thanks for updating the binding for the clocks, but clocks are not > specific to K2G. They also apply to other K2 SoCs. Davinci platforms do > not have DT clocks atm, so the Davinci portion can be updated later if > and when they get added. Yes. I can add that information. > >> + >> +- clocks: Should contain devices input clock. The first parameter >> + is a handle to k2g_clks. The second parameter is the >> + device ID and the third parameter is the clock ID. One can >> + refer: http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data > > No need for this link here, just refer to the appropriate clock > bindings. Some thing like the following would be better > > - clocks: Should contain the device's input clock, and > should be defined as per the appropriate clock > bindings consumer usage in, > > Documentation/devicetree/bindings/clock/keystone-gate.txt > for 66AK2HK/66AK2L/66AK2E SoCs or, > > Documentation/devicetree/bindings/clock/ti,sci-clk.txt > for 66AK2G SoCs Okay > >> + >> + Example: <&k2g_clks 0x001c 0x0>; > > This can be dropped as well, below example already demonstrates it. Okay > >> + >> +- clock-names: The driver expects the clock name to be "gpio"; > > Just say, Should be "gpio". No need of mentioning about the driver. Okay > >> + >> Example: >> >> gpio: gpio at 1e26000 { >> @@ -60,3 +74,27 @@ leds { >> ... >> }; >> }; >> + >> +Example for keystone-k2g: > > s/keystone-k2g/66AK2G/ oops missed out here. I will correct this. > >> + >> +gpio0: gpio at 2603000 { >> + compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; >> + reg = <0x02603000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <144>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001b 0x0>; >> + clock-names = "gpio"; >> +}; >> > > regards > Suman > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 6:45 [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Keerthy 2017-07-26 6:45 ` [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy 2017-07-26 13:00 ` [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Suman Anna @ 2017-08-02 9:29 ` Linus Walleij 2017-08-03 16:17 ` Rob Herring 3 siblings, 0 replies; 20+ messages in thread From: Linus Walleij @ 2017-08-02 9:29 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 26, 2017 at 8:45 AM, Keerthy <j-keerthy@ti.com> wrote: > The patch adds keystone-k2g compatible, specific properties and > an example. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > Changes in v3: I guess I'm waiting for a v4 on this. The changes seem reasonable, also fairly standard and uncontroversial. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-07-26 6:45 [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Keerthy ` (2 preceding siblings ...) 2017-08-02 9:29 ` Linus Walleij @ 2017-08-03 16:17 ` Rob Herring 2017-08-04 4:16 ` Keerthy 3 siblings, 1 reply; 20+ messages in thread From: Rob Herring @ 2017-08-03 16:17 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 26, 2017 at 12:15:23PM +0530, Keerthy wrote: > The patch adds keystone-k2g compatible, specific properties and > an example. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > Changes in v3: > > * Added details about family of SoCs corresponding to compatibles. > > .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible 2017-08-03 16:17 ` Rob Herring @ 2017-08-04 4:16 ` Keerthy 0 siblings, 0 replies; 20+ messages in thread From: Keerthy @ 2017-08-04 4:16 UTC (permalink / raw) To: linux-arm-kernel On Thursday 03 August 2017 09:47 PM, Rob Herring wrote: > On Wed, Jul 26, 2017 at 12:15:23PM +0530, Keerthy wrote: >> The patch adds keystone-k2g compatible, specific properties and >> an example. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> >> Changes in v3: >> >> * Added details about family of SoCs corresponding to compatibles. >> >> .../devicetree/bindings/gpio/gpio-davinci.txt | 40 +++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) > > Acked-by: Rob Herring <robh@kernel.org> Thanks Rob. Santosh, I will post a v4 adding Rob's and Linus's Ack. Thanks, Keerthy > ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2017-08-04 4:16 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-26 6:45 [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Keerthy 2017-07-26 6:45 ` [PATCH v3 2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy 2017-07-26 13:03 ` Suman Anna 2017-07-26 13:29 ` Keerthy 2017-07-26 13:33 ` Russell King - ARM Linux 2017-07-26 13:43 ` Keerthy 2017-07-26 13:00 ` [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible Suman Anna 2017-07-26 13:27 ` Franklin S Cooper Jr 2017-07-26 13:35 ` Suman Anna 2017-07-26 13:36 ` Keerthy 2017-07-26 14:20 ` Suman Anna 2017-07-26 18:37 ` Franklin S Cooper Jr 2017-07-31 13:44 ` Keerthy 2017-08-01 6:12 ` Vignesh R 2017-08-01 14:30 ` Suman Anna 2017-08-01 15:49 ` Franklin S Cooper Jr 2017-07-26 13:33 ` Keerthy 2017-08-02 9:29 ` Linus Walleij 2017-08-03 16:17 ` Rob Herring 2017-08-04 4:16 ` Keerthy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).