linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: queue GPIO operations instead of defering
Date: Thu, 22 Aug 2013 01:07:30 +0200	[thread overview]
Message-ID: <CACRpkdasWurMctYTMZCHS+fwhvmnREaQD1vN54QYpMToTuFjsg@mail.gmail.com> (raw)
In-Reply-To: <52126EDE.5060000@wwwdotorg.org>

On Mon, Aug 19, 2013 at 9:15 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 08/17/2013 08:56 AM, Linus Walleij wrote:

>> and the pin controller need the GPIO driver to be ready.
>
> Why does that happen?

The pin controller call back into the GPIO-side controller
functions by utilizing the GPIO ranges.
(Maybe the code is silly, I dunno, check drivers/pinctrl/pinctrl-nomadik.c)

>> This also happens if
>> pin controllers and GPIO controllers compiled as modules
>> are inserted in a certain order.
>
> Shouldn't deferred probe resolve that just fine, assuming there are no
> circular dependencies?

The above leads to circular dependencies so that is what I'm
trying to fix with this.

>> On the Nomadik we get this situation with the pinctrl
>> driver when moving to requesting GPIOs off the gpiochip
>> right after it has been added,
>
> So, the pinctrl driver calls gpio_request()? Surely the solution is
> simply not to do that?

This is what the other patch we're discussing is doing.
The one that harvests and requests interrupt GPIO's when
a gpiochip is added...

Yours,
Linus Walleij

  reply	other threads:[~2013-08-21 23:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 14:56 [PATCH v2] pinctrl: queue GPIO operations instead of defering Linus Walleij
2013-08-19 19:15 ` Stephen Warren
2013-08-21 23:07   ` Linus Walleij [this message]
2013-08-21 23:23     ` Stephen Warren
2013-08-21 23:44       ` Linus Walleij
2013-08-19 19:21 ` Stephen Warren
2013-08-21 17:45   ` Stephen Warren
2013-08-21 23:04     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdasWurMctYTMZCHS+fwhvmnREaQD1vN54QYpMToTuFjsg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).