From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] pinctrl: basic Nomadik pinctrl interface
Date: Fri, 11 May 2012 09:12:50 +0200 [thread overview]
Message-ID: <CACRpkdaveHBEbpY9bARyooCDb9gX8BMYxfAbX+MSVjXodCAX1w@mail.gmail.com> (raw)
In-Reply-To: <4FAAD4EB.4010007@wwwdotorg.org>
On Wed, May 9, 2012 at 10:34 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 05/08/2012 03:44 AM, Linus Walleij wrote:
>> + ? ? /* Poke in other ASIC variants here */
>> + ? ? if (platid->driver_data == PINCTRL_NMK_DB8500)
>> + ? ? ? ? ? ? nmk_pinctrl_db8500_init(&npct->soc);
>
> Other platforms have a unique top-level driver for each variant, with
> the probe() function for each variant calling into a utility function.
> That way, the common/utility code doesn't need to contain a
> table/list/... of all the variants. Can the same approach be used here?
Now I see why I did this, it doesn't show in the patch but this driver
now has two platform_driver structs and two probes.
So I thought it'd be messy to have the two probes in two different
files, with criss-cross calling, as simple as that.
The goal is to merge them into one probe function providing
all resources though, I'm refactoring stepwise since the mess
up in the arch needs to be handled in some separate step
and I have enough hamming distance already as it is ...
I'm rolling a v2 with the other change though.
Yours,
Linus Walleij
prev parent reply other threads:[~2012-05-11 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 9:44 [PATCH 02/12] pinctrl: basic Nomadik pinctrl interface Linus Walleij
2012-05-09 20:34 ` Stephen Warren
2012-05-10 15:10 ` Linus Walleij
2012-05-10 15:12 ` Linus Walleij
2012-05-10 15:53 ` Arnd Bergmann
2012-05-10 15:57 ` Arnd Bergmann
2012-05-11 7:12 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaveHBEbpY9bARyooCDb9gX8BMYxfAbX+MSVjXodCAX1w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).