From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AA05C433F5 for ; Thu, 10 Mar 2022 08:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c3/Z+Vt4C4stRCUUt4vcfvgnSUQpNoIBdBh4XiHVdCY=; b=IN3szMKMXEb48s jgrfl5HK4eJy9Tb8kAssncCZ2wwoL83xCE0Yib34q5FrZkF7ZbIEL3S7xhY6xTzK346HmXz97uR13 oknVwIGvKHRrDcM6ShHPl4rh9ckAnOVdI72ZkaBxPvdF/CvvjRiUcNLXX2Cw5oizjWHHUR1DGxVth gUkETmlC89Ak0WbT7/P5yVkpWr8bkKIGifAwOe465HyB/ysKBp6Tm/03hha6QxTvRT5rm5YbzWw/D S8UwADw21ZunaBCduoKMDr7vNyTj9hpeIwi5q/B0C1hpxA7e0IK78pcK0GAA5a4FDrXWqKvHDlCs4 Z9uhInZ/Hc9vMsZ6XkDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSEXz-00C1Nu-UN; Thu, 10 Mar 2022 08:53:24 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSEXv-00C1LZ-AI for linux-arm-kernel@lists.infradead.org; Thu, 10 Mar 2022 08:53:20 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id g1so9549378ybe.4 for ; Thu, 10 Mar 2022 00:53:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bD08i1b1Z+a0jckACUWyZF49FUKoI95aym7BAJB81+4=; b=d77zuTOMdWadP7QTexmBQhpN40kO9TgLiGdMXSZntTvlXCspc7CzVF1/iqV/ZhlCaR ytTvDiCt2AtGr7bw0sZKGQn4ljSwnKvlzmgzKC/6VAolV0p6K/Xh2H6UaLJ2NnuQIIqI TqK7dNe0dO1Jf3nKby0mgdH8xo6FqOgYaVhQTLvddmli64sHcWV/jOIoS1uLGOBft5+Z AKYXl4hCUQwH1TJ0+UyZcbS5D3JgtXGJy3i4P3mxduAEFJ0wCgW/N6azFGj4mvGfR5Wa QcJoFYUvSwLHT7RVg7L/5+MTROxcrTNJMXqxlIbldRKKti5Zj3yXSaGQjfufMTAiRzHr kCTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bD08i1b1Z+a0jckACUWyZF49FUKoI95aym7BAJB81+4=; b=2/l5Xt+dqu3V2w8Q3dN2yWrOjC2RuPBA/BagXW6SChz23RLWztc0XCf/RBR+rPrQEs Qu+B6CqtRNttFf2sq3s9E1P70qpks6bVvq9BwZW1IwBc9zhygpcCQaVQRLZGJ60zYsuL eOc/zVmRz8KGHsTHyomsjFiGfYM0mZ+rqJdaDWq4mmv9IJY0WriawWFSZPf3XYF+SObx wWkKp32hoSgVtH3iuLxXBFoOv12gQkZyRsdautMinMPE6P8S/OlLnXjzZhCnSvAAhsTf HtmIDP+XWS2kEUbTi61eCia5XrwZwmrsuJuwW0Lxr4y6SnV65TI5SFTXFQrqVw8cA3/v i8MQ== X-Gm-Message-State: AOAM533j9y3YPzilYFcjoSQmaExJNIb4wjwjiXFUB0jn5G0aK5mPMRUn w0G5oWZDSQOCQgik9Zf9tPWs8pzbt3uUtsSK7bApfQ== X-Google-Smtp-Source: ABdhPJx4ZXsuU9Tb2NC5aJL7+W4AU+IuqrDW+XUD9ehGALWKJCvmPVJbiDN+x9sNKbRVBSm+dS5nJjfNNM6pejuu3UA= X-Received: by 2002:a25:da85:0:b0:629:36f:5669 with SMTP id n127-20020a25da85000000b00629036f5669mr2988219ybf.492.1646902394927; Thu, 10 Mar 2022 00:53:14 -0800 (PST) MIME-Version: 1.0 References: <20220303173935.100622-1-cmirabil@redhat.com> <20220303173935.100622-7-cmirabil@redhat.com> In-Reply-To: <20220303173935.100622-7-cmirabil@redhat.com> From: Linus Walleij Date: Thu, 10 Mar 2022 09:53:03 +0100 Message-ID: Subject: Re: [PATCH v7 6/6] DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4 To: Charles Mirabile Cc: linux-kernel@vger.kernel.org, Serge Schneider , Stefan Wahren , Nicolas Saenz Julienne , Mattias Brugger , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, fedora-rpi@googlegroups.com, Mwesigwa Guma , Joel Savitz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_005319_442442_149B1C8F X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 3, 2022 at 6:43 PM Charles Mirabile wrote: > This patch should not be merged - dtbs files are not stored in the > kernel tree. We just provide this file so the code can be tested. A problem with that approach is that the DTS files are not reviewed and that causes quality problems, and another problem is that the kernel lack examples of real-world systems so people have to scout to find those and that costs developer time. I know many people are opposed to having this kind of stuff in the kernel tree, but I am *for* having this kind of stuff in the kernel tree. Mainly because there is no working community to shepherd it otherwise, while we (the kernel maintainers) are still dependent on there being one. > + lsm9ds1-magn@1c { > + compatible = "st,lsm9ds1-magn"; > + reg = <0x1c>; > + status = "okay"; > + }; > + > + lsm9ds1-accel@6a { > + compatible = "st,lsm9ds1-accel"; > + reg = <0x6a>; > + status = "okay"; > + }; These should typically have mounting matrices. I doubt they are mounted according to the identity matrix, because electronics designers usually have other concerns when layouting PCBs. See Documentation/devicetree/bindings/iio/mount-matrix.txt Yours, Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel