From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] dt-bindings: Add a binding for the RPi firmware GPIO driver.
Date: Fri, 23 Sep 2016 10:57:27 +0200 [thread overview]
Message-ID: <CACRpkdb-hRjD+FmyZ4SKurp94V=HR3L90OLNc-6eUKuy9AK_Rg@mail.gmail.com> (raw)
In-Reply-To: <20160919161314.25858-1-eric@anholt.net>
On Mon, Sep 19, 2016 at 6:13 PM, Eric Anholt <eric@anholt.net> wrote:
> The RPi firmware exposes all of the board's GPIO lines through
> property calls. Linux chooses to control most lines directly through
> the pinctrl driver, but for the FXL6408 GPIO expander on the Pi3, we
> need to access them through the firmware.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Aha
> +++ b/Documentation/devicetree/bindings/gpio/gpio-raspberrypi-firmware.txt
> @@ -0,0 +1,22 @@
> +Raspberry Pi power domain driver
Really? :)
> +Required properties:
> +
> +- compatible: Should be "raspberrypi,firmware-gpio"
Usually this is vendor,compat, is the vendors name "raspberrypi"?
> +- gpio-controller: Marks the device node as a gpio controller
> +- #gpio-cells: Should be <2> for GPIO number and flags
> +- ngpios: Number of GPIO lines to control. See gpio.txt
Is this ever anything else than 8? Else omit it and hardcode
8 in the driver instead.
> +- firmware: Reference to the RPi firmware device node
Reference the DT binding for this.
> +- raspberrypi,firmware-gpio-offset:
> + Number the firmware uses for the first GPIO line
> + controlled by this driver
Does this differ between different instances of this hardware or
can it just be open coded in the driver instead?
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-09-23 8:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 16:13 [PATCH 1/3] dt-bindings: Add a binding for the RPi firmware GPIO driver Eric Anholt
2016-09-19 16:13 ` [PATCH 2/3] gpio: Add a driver for the Raspberry Pi's firmware GPIO calls Eric Anholt
2016-09-23 9:08 ` Linus Walleij
2016-09-23 13:15 ` Eric Anholt
2016-09-23 14:08 ` Linus Walleij
2016-09-24 7:01 ` Eric Anholt
2016-10-06 8:16 ` Linus Walleij
2016-09-26 16:46 ` Stephen Warren
2016-09-23 19:00 ` Stefan Wahren
2016-09-19 16:13 ` [PATCH 3/3] arm64: Add the Raspberry Pi firmware's interface to the FXL6408 Eric Anholt
2016-09-22 20:44 ` Gerd Hoffmann
2016-09-23 9:23 ` Linus Walleij
2016-09-23 8:57 ` Linus Walleij [this message]
2016-09-23 13:08 ` [PATCH 1/3] dt-bindings: Add a binding for the RPi firmware GPIO driver Eric Anholt
2016-09-23 13:53 ` Linus Walleij
2016-09-26 16:40 ` Stephen Warren
2016-09-23 18:39 ` Stefan Wahren
2016-09-26 16:38 ` Stephen Warren
2016-09-26 18:42 ` Stefan Wahren
2016-09-28 17:54 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb-hRjD+FmyZ4SKurp94V=HR3L90OLNc-6eUKuy9AK_Rg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).