From: Linus Walleij <linus.walleij@linaro.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, afaerber@suse.de, balejk@matfyz.cz
Subject: Re: [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte
Date: Sat, 30 Sep 2023 00:05:41 +0200 [thread overview]
Message-ID: <CACRpkdb=8LU9Mkkn_VDcTGoH1pWn=hp9ZhN5dLm5pykif8cp-w@mail.gmail.com> (raw)
In-Reply-To: <20230929-pxa1908-lkml-v5-7-5aa5a1109c5f@skole.hr>
On Fri, Sep 29, 2023 at 5:42 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote:
> Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value
> Edition LTE, a smartphone based on said SoC.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
(...)
> +&pmx {
> + pinctrl-single,gpio-range = <&range 55 55 0>,
> + <&range 110 32 0>,
> + <&range 52 1 0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&board_pins_1 &board_pins_2 &board_pins_3>;
> +
> + board_pins_1: pinmux-board-1 {
> + pinctrl-single,pins = <
> + 0x160 0
> + 0x164 0
> + 0x168 0
> + 0x16c 0
> + >;
> + pinctrl-single,drive-strength = <0x1000 0x1800>;
> + pinctrl-single,bias-pullup = <0x8000 0x8000 0 0xc000>;
> + pinctrl-single,bias-pulldown = <0x8000 0x8000 0 0xa000>;
> + pinctrl-single,input-schmitt = <0 0x30>;
> + pinctrl-single,input-schmitt-enable = <0x40 0 0x40 0x40>;
> + pinctrl-single,low-power-mode = <0x288 0x388>;
> + };
(...)
> + pmx: pinmux@1e000 {
> + compatible = "pinconf-single";
At least add a new binding for "marvell,pxa1908-padconf"
and use that like this:
compatible = "marvell,pxa1908-padconf", "pinconf-single";
When you use pinctrl-single you get the slightly opaque device
trees as seen above, so it's not something I'd recommend, I'd
rather write my own pin controller.
But it exists, so I can't say you can't use it. Not my choice.
I understand it is convenient.
It is possible to switch later, but only if you have a unique
pin controller compatible so please add that.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-29 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 15:41 [PATCH RESEND v5 0/8] Initial Marvell PXA1908 support Duje Mihanović
2023-09-29 15:41 ` [PATCH RESEND v5 1/8] gpio: pxa: disable pinctrl calls for MMP_GPIO Duje Mihanović
2023-10-02 7:19 ` Bartosz Golaszewski
2023-09-29 15:41 ` [PATCH RESEND v5 2/8] clk: mmp: Switch to use struct u32_fract instead of custom one Duje Mihanović
2023-09-29 21:50 ` Linus Walleij
2023-09-29 15:41 ` [PATCH RESEND v5 3/8] dt-bindings: clock: Add Marvell PXA1908 clock bindings Duje Mihanović
2023-09-30 9:30 ` Conor Dooley
2023-09-29 15:42 ` [PATCH RESEND v5 5/8] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2023-09-29 15:42 ` [PATCH RESEND v5 6/8] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Duje Mihanović
2023-09-29 15:42 ` [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2023-09-29 22:05 ` Linus Walleij [this message]
2023-09-30 8:25 ` Duje Mihanović
2023-09-30 15:37 ` Linus Walleij
2023-09-29 15:42 ` [PATCH RESEND v5 8/8] MAINTAINERS: add myself as Marvell PXA1908 maintainer Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb=8LU9Mkkn_VDcTGoH1pWn=hp9ZhN5dLm5pykif8cp-w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=afaerber@suse.de \
--cc=andy@kernel.org \
--cc=balejk@matfyz.cz \
--cc=brgl@bgdev.pl \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).