From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: pl010/pl011: move clk_enable from console write to setup
Date: Tue, 29 Jan 2013 18:45:10 +0100 [thread overview]
Message-ID: <CACRpkdbEMO0wuDDXcd6oW6Jnn3LBhATBdcoHJEAdg7MrU6h-jQ@mail.gmail.com> (raw)
In-Reply-To: <1359475526-17523-1-git-send-email-walimisdev@gmail.com>
On Tue, Jan 29, 2013 at 5:05 PM, Liming Wang <walimisdev@gmail.com> wrote:
> There seems no need to call clk_enable in every console writing. And we
> can move clk_enable to setup function to enable the clock only once.
> Also combine the clk_enable and clk_prepare to clk_prepare_enable.
>
> Signed-off-by: Liming Wang <walimisdev@gmail.com>
NAK.
Consider the case where the console outputs nothing or
a string every 30 minutes. Why should we not gate off the
clock between these sporadic prints?
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-01-29 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 16:05 [PATCH] serial: pl010/pl011: move clk_enable from console write to setup Liming Wang
2013-01-29 16:08 ` Russell King - ARM Linux
2013-01-29 17:45 ` Linus Walleij [this message]
2013-01-30 10:41 ` walimis
2013-01-30 10:48 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbEMO0wuDDXcd6oW6Jnn3LBhATBdcoHJEAdg7MrU6h-jQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).