From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F8C5C43331 for ; Fri, 27 Mar 2020 10:21:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 219DB20705 for ; Fri, 27 Mar 2020 10:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KyhllI7q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BWdcmcSO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 219DB20705 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AI+pye7a2cByf44OZlQ+n6n2cDQ+aN7EUki0ao6X5oU=; b=KyhllI7qDWdvd7 URbB2uU/J8qZmcDrXfyNT/zWWBRdjumruGUgQG0XmTqLQ5RMeV16eVEEbOQD4UIOq09PxQmIfp3YQ yufnu3rXWaHdHGOsJcf7Fsby44EFV74NxO/aaYVryEPwYIo+qzczrLUfBkdr2j0nXPr0ItLza1hrI UJOkQ8ltBeO9kJ4vLs6UA8MkNLFKHuYKjHydN9xrtJqAp2TfSSzrzwVCa3Mn5P0ANxZ5vww21pyal 8QKttw1qbtYCOaLi4WyqYCZGTzJqyoApCnza39WAJVhgx5DAOEgfbVlu4m+yD46+vCcmHHaPCKrGR fgowWBys/tGMVFnImreA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHm73-0000CF-Ew; Fri, 27 Mar 2020 10:21:17 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHm6z-0000BJ-N9 for linux-arm-kernel@lists.infradead.org; Fri, 27 Mar 2020 10:21:16 +0000 Received: by mail-lf1-x144.google.com with SMTP id e7so7396503lfq.1 for ; Fri, 27 Mar 2020 03:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TuB8BNTEMS6Xu4xWKK0GTpM0KTFJDSPd7CoTH260LEY=; b=BWdcmcSOZAia9WokqOKv83FwargH+rfDXr2Mp0QwyZsT/mABCSd3y3ZMISvNsbmXhU gQMIR1duY1UxdvKr1tbHQzNudMLJvKqINJWtOlrbk9+kwOmXToR95IOMrI3yVrYmqYw4 ERIXKr3kSqBiWHHSNhbcDl9Iko5A1Q0USZ7lVRGh7i4ZWuu8E4UBLvEJ0Rb7XNIkfIsy aw8uoNh4prsuenO/RPpdtz/llUkVRpSahQ6WFiqcc4YqGBOhRx5YxeATNzXZkpF5gRXs u9qzGndEeTvD5XvNeditQ2MMZ58/zYFaGXYoaCpP0AzoqV0GaxsvyztxFYEj52lAcoCH pBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TuB8BNTEMS6Xu4xWKK0GTpM0KTFJDSPd7CoTH260LEY=; b=qlCaHFbs/61rUNjZVPn+n+UoIw9jBBTdIanI1zkF/szpV1qPQ38BA/1ju27+xoZQuG 9fteszFlaxZmaaWo5nAp0npBAAywfqEaoz/qeFZyiktc+MtAupTm19TkH2CIKWVFWwtT jwk50XGC9XCj6VQcmbf1XHWHPM7f1aiMtlQo3LM+BDBJ3Wwm2xA2BSrqg6S2feXGm6rn DbzvKQPGplcYjQjIwfM+NGeae1GysfbieSeTmkosra0/WLJeOeJ7w4jMaMEc4+G99UeM B/HLMCmdfdyWYXXtgY1fPzVsyQgIzuOd7FJy+LCW+MTuQRj4dr6dSpLaFr/FQwsGkfvp zsnQ== X-Gm-Message-State: ANhLgQ0n0iY9l2zEkyH39U3frhHrQT4ldhvadEMVBd1H57cQZ8VCzjvj JlLt2YmdkmAhxJ810X6mxdTWeUbFTq5EfTqw835QNQ== X-Google-Smtp-Source: ADFU+vtsIgqK8FyZODtKNKWKI1HxhtKduwTybRXQvKGmxQLsPLeMOqx9p3y4gdOqstKYu6oc3bIWeFZeiamysR3lBHg= X-Received: by 2002:a19:ac8:: with SMTP id 191mr8675462lfk.77.1585304468041; Fri, 27 Mar 2020 03:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20200317205017.28280-1-michael@walle.cc> <20200317205017.28280-13-michael@walle.cc> <9c310f2a11913d4d089ef1b07671be00@walle.cc> <22944c9b62aa69da418de7766b7741bd@walle.cc> In-Reply-To: <22944c9b62aa69da418de7766b7741bd@walle.cc> From: Linus Walleij Date: Fri, 27 Mar 2020 11:20:56 +0100 Message-ID: Subject: Re: [PATCH 12/18] gpio: add support for the sl28cpld GPIO controller To: Michael Walle X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200327_032114_345773_5A816960 X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, linux-devicetree , Jean Delvare , Marc Zyngier , LINUXWATCHDOG , linux-pwm@vger.kernel.org, Shawn Guo , linux-gpio , LKML , Li Yang , Bartosz Golaszewski , Rob Herring , Thierry Reding , Guenter Roeck , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Thomas Gleixner , Wim Van Sebroeck , Lee Jones , arm-soc , Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 26, 2020 at 9:06 PM Michael Walle wrote: > Am 2020-03-25 12:50, schrieb Bartosz Golaszewski: > > In that case maybe you should use the disable_locking option in > > regmap_config and provide your own callbacks that you can use in the > > irqchip code too? > > But how would that solve problem (1). And keep in mind, that the > reqmap_irqchip is actually used for the interrupt controller, which > is not this gpio controller. > > Ie. the interrupt controller of the sl28cpld uses the regmap_irqchip > and all interrupt phandles pointing to the interrupt controller will > reference the toplevel node. Any phandles pointing to the gpio > controller will reference the GPIO subnode. Ideally we would create something generic that has been on my mind for some time, like a generic GPIO regmap irqchip now that there are a few controllers like that. I don't know how feasible it is or how much work it would be. But as with GPIO_GENERIC (for MMIO) it would be helpful since we can then implement things like .set_multiple() and .get_multiple() for everyone. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel