From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D202C43381 for ; Fri, 1 Mar 2019 13:30:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ACA52084D for ; Fri, 1 Mar 2019 13:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GqCgtwPy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DDOKuiSA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ACA52084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=te/vPMoFhvWoT7cion5voFJSG8Yvwx/gKP3/Rq5VMdA=; b=GqCgtwPythhr4i aSf/dJYsEmBOxcOgJ2lI9FGBnmFa/1/uaEqaY8joyOd1rNORJl4Gq5o44aWRpR32Bi8FEexzWReLd ao9dA7N6/L+MF6l2QOpMK5VVT05FWhrHxY1Xr+Bf+SaMA796rSMH5cut0WgeOTuyFOFzA/J7wW3Xn GIrEV9H+H2VY5IbSleHBcBVwmJdXNKRKwKEcIglSAftHOSPhE/bVdJyP70ahr0EoNfoTJcsB8bVeS OfTLSVaxWyikJSv1wg1k4Xewalulb3CRPI2QWa9gqIW/ZALU7b7fhH9OP+ybVS8WdNifbZy/jggCj g5JkxhHPUMAw3XQ0+Irw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gziFN-0000uZ-6i; Fri, 01 Mar 2019 13:30:41 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gziF5-0000U6-O2 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 13:30:39 +0000 Received: by mail-lj1-x242.google.com with SMTP id v16so20359163ljg.13 for ; Fri, 01 Mar 2019 05:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/XJDPgZr92xbE7yFFhPob5maKvzEO0Ch9NxM0VD/tA=; b=DDOKuiSAybrLJ9HTTyxnqDUYKXjm/K4uQyuMsw6fxtSlsimcQPnh5ydyQ3xHrqNBtj Myl/3Ef6pxTs3apyhr0wqKC1c97E93vv1JJ1SvB5LnW2ph+Tyc6uw6+231N51HjXY7/8 FuJbDswOwSPQo/JCFei/uxNAwLpXvrdQJQehhNcL6KzEzP/6OZcxpMsxQ6CXg6I5PHNa PUdyPg0Oe3Khbdo68+M7g7W5M75WXSDzighDnyuCURZwjo/QpQHbgb8vcy34GCcLVO9v sgnh76Y8n9Pav3vNyMPBSoAVX7yoV77yW3TjE6PdjBn/ORpP8c5UiUIL/9ceMgW1UYSf KFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/XJDPgZr92xbE7yFFhPob5maKvzEO0Ch9NxM0VD/tA=; b=gNvlyfeL3mOE7f9fmeX4lpkd+iu7XPjHATUvUTmVQdc8I9YA7DuHTwGmrcVRYGDwmg AOHUA/JYRcMtnQMPurBB3snLINTj38ulW0J+4GXg4X09UTsdZ2sw46CvdpjsvQz7F2vt vnAbUK8WDobEmChngTVcPbLHCIWcwkM9BCsbzE6I6R/neCxaJR6Lh91vxZpDXkCaeuOC 1tI+RdM4AafIIlGbjRICZx32ZqVXw1sJb1RuOazlV6BURKaFuXkKFCPSWxG70msHYA9C Xgdz0lDQhTYEZ8tDN9mETbrQhilFeAgDHkDw9zcB/yPBCX1VJKM8Ad9GKOhubZwb9Dlb t6eA== X-Gm-Message-State: APjAAAWazMmVjnfvRUra8gGn5PT6pVxtEaiGUuc8Jet21cYXfKAWGxmd WSbe3u5ZeMpvdhfoR35IdzFPb3w4pY3D3M4OO1R/xw== X-Google-Smtp-Source: APXvYqzQBL4m/JhwTqQVZZDw5PN823UelfkF5SqwestEOA1FGFQe7QDjXsZTb/laUfbMj1HJu1EZEe6HumI04LW7sZU= X-Received: by 2002:a2e:6a18:: with SMTP id f24mr2839458ljc.97.1551447019150; Fri, 01 Mar 2019 05:30:19 -0800 (PST) MIME-Version: 1.0 References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn> In-Reply-To: <1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn> From: Linus Walleij Date: Fri, 1 Mar 2019 14:30:07 +0100 Message-ID: Subject: Re: [PATCH 11/15] ARM: versatile: fix a leaked reference by addingmissing of_node_put To: Wen Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_053024_264805_0B3A8D1D X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Maxime Ripard , Catalin Marinas , Liviu Dudau , Michal Simek , Xu Wei , Manivannan Sadhasivam , Tomer Maimon , Florian Fainelli , "open list:ARM/Rockchip SoC..." , Will Deacon , OpenBMC Maillist , Magnus Damm , Russell King , Krzysztof Kozlowski , linux-samsung-soc , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list , NXP Linux Team , Brendan Higgins , wang.yi59@zte.com.cn, Ray Jui , Sascha Hauer , Lorenzo Pieralisi , Nancy Yuen , Linux ARM , Scott Branden , avifishman70@gmail.com, Patrick Venture , "linux-kernel@vger.kernel.org" , Linux-Renesas , Dinh Nguyen , Simon Horman , Sascha Hauer , Sudeep Holla , Fabio Estevam , Shawn Guo , =?UTF-8?Q?Andreas_F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 1, 2019 at 9:57 AM Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function. > ./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Cc: Linus Walleij > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Patch applied. Will send upstream next kernel cycle or so. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel