* [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode
@ 2016-11-30 2:21 Chunfeng Yun
2016-12-01 0:45 ` Hongzhou Yang
2016-12-02 12:40 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Chunfeng Yun @ 2016-11-30 2:21 UTC (permalink / raw)
To: linux-arm-kernel
the default mode of GPIO16 pin is gpio, when set EINT16 to
IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
fixed when set its default mode as usb iddig.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
index 13e5b68..9b018fd 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
@@ -201,7 +201,7 @@
MTK_PIN(
PINCTRL_PIN(16, "IDDIG"),
NULL, "mt8173",
- MTK_EINT_FUNCTION(0, 16),
+ MTK_EINT_FUNCTION(1, 16),
MTK_FUNCTION(0, "GPIO16"),
MTK_FUNCTION(1, "IDDIG"),
MTK_FUNCTION(2, "CMFLASH"),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode
2016-11-30 2:21 [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode Chunfeng Yun
@ 2016-12-01 0:45 ` Hongzhou Yang
2016-12-02 12:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Hongzhou Yang @ 2016-12-01 0:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2016-11-30 at 10:21 +0800, Chunfeng Yun wrote:
> the default mode of GPIO16 pin is gpio, when set EINT16 to
> IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
> fixed when set its default mode as usb iddig.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> index 13e5b68..9b018fd 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> @@ -201,7 +201,7 @@
> MTK_PIN(
> PINCTRL_PIN(16, "IDDIG"),
> NULL, "mt8173",
> - MTK_EINT_FUNCTION(0, 16),
> + MTK_EINT_FUNCTION(1, 16),
> MTK_FUNCTION(0, "GPIO16"),
> MTK_FUNCTION(1, "IDDIG"),
> MTK_FUNCTION(2, "CMFLASH"),
Acked-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
Thanks,
Hongzhou
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode
2016-11-30 2:21 [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode Chunfeng Yun
2016-12-01 0:45 ` Hongzhou Yang
@ 2016-12-02 12:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-12-02 12:40 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 30, 2016 at 3:21 AM, Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> the default mode of GPIO16 pin is gpio, when set EINT16 to
> IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
> fixed when set its default mode as usb iddig.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Patch applied with Hongzhou's ACK!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-02 12:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 2:21 [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode Chunfeng Yun
2016-12-01 0:45 ` Hongzhou Yang
2016-12-02 12:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).