Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values

[Linus Walleij <linus.walleij@linaro.org>]

On Wed, Aug 6, 2025 at 8:38 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> On Fri, Aug 1, 2025 at 7:18 PM Julien Massot wrote

> >                 pins-clk {
> >                         pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> >                         drive-strength = <MTK_DRIVE_14mA>;
> > -                       mediatek,pull-down-adv = <10>;
> > +                       mediatek,pull-down-adv = <2>;
>
>         bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
>
> and so on.
>
> ChenYu

I agree with ChenYu, the more standardized properties are the better it is.

All the custom properties makes sense for an engineer working with just
that one SoC (like the SoC vendor...) but for field engineers who have
to use different SoCs every day this is just a big mess for the mind.

The standard properties are clear, concise and tell you exactly what
they are about.

The argument should be in Ohms though, according to the standard
bindings, but maybe the value of MTK_PUPD_SET_R1R0_10 is
something like that?

Yours,
Linus Walleij