From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: Tegra 30 System hangs because of commit "pinctrl: move subsystem mutex to pinctrl_dev struct"
Date: Fri, 3 May 2013 16:22:41 +0200 [thread overview]
Message-ID: <CACRpkdboCQmV_Aam3EDcSG6PRVnpEmGkC78m3h7rXT68V2a9Qg@mail.gmail.com> (raw)
In-Reply-To: <517ED12B.8080502@wwwdotorg.org>
On Mon, Apr 29, 2013 at 9:59 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> I would suggest simply dropping or reverting this patch; I had pointed out a
> long time ago that it was unlikely to be correct.
>
> My guess/suspicion is a recursive lock attempt during processing hogs during
> pinctrl device registration, or perhaps during dt->map conversion. Bryan,
> are you able to confirm this?
This was not the case at all, it was an mutex_unlock misspelled as
mutex_lock()... totally unrecursive dual locking :-)
I did test the patch quite extensively, albeit not on a system using
DT to populate the pinctrl tables so I missed this, mea culpa.
I really want to get rid of the big pinctrl lock and make this more
fine-granular, and that is why the patch is being pushed, bear
with me.
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-05-03 14:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK5ve-KXdS8az=Gtja-mF=Z3_EeZVA7bLYSU0EE2mf5bHmSUKw@mail.gmail.com>
[not found] ` <CAK5ve-KBDyvjNRVMcXgfnhYcajdcGsuAKaepzCBt+epiXoYvSw@mail.gmail.com>
2013-04-29 19:59 ` Fwd: Tegra 30 System hangs because of commit "pinctrl: move subsystem mutex to pinctrl_dev struct" Stephen Warren
2013-04-29 20:54 ` Bryan Wu
2013-05-03 14:22 ` Linus Walleij [this message]
2013-05-04 13:30 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-04 20:52 ` Linus Walleij
2013-05-05 11:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-05 19:57 ` Linus Walleij
2013-05-05 20:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 19:29 ` Linus Walleij
2013-05-06 19:32 ` Bryan Wu
2013-05-06 19:41 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 19:54 ` Russell King - ARM Linux
2013-05-06 20:12 ` Linus Walleij
2013-05-09 13:25 ` Grant Likely
2013-05-09 16:13 ` Olof Johansson
2013-05-09 17:51 ` Fathi Boudra
2013-05-10 9:29 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-14 20:39 ` Rob Herring
2013-05-15 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 20:14 ` Stephen Warren
2013-05-06 20:19 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 20:40 ` Bryan Wu
2013-05-06 20:25 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdboCQmV_Aam3EDcSG6PRVnpEmGkC78m3h7rXT68V2a9Qg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).