From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 105CFC433EF for ; Mon, 18 Jul 2022 16:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bIPezSluoJCy/Ed5g5+OVVycz1YDrWXP8WA7ztbIGio=; b=Y+zUphTw0nIFh2 r/8jQ0lFP/hftcSZBZJNc9cdyChf9XV6MmQY+fxN48feZKyyOYo2KtX1ggMzbzk6XpgYdFP6F3++A bFGW5io+ljlp4xPe/Uy/6P83U1ow1OVFOVouj72OTf2VYNk+duT2p+qiO/eh9a6opqqDnw32BWCRh 1GGCVir9gIY7lZ6FpTmgTYgBAPl5yqL7+qAP2G2uhZRblj/lFJHgnoIsX36xf2LraRZHfW4zJCFvq 8vt9c/OjbjSk7Fje3POga3BJoBrlDFdQ9K3zroBO0+mEzJceicRkGTLCXRE/tyBCvRpjRZbtr0R2l Jf+4mRrdLWgjNSNznM0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDU0S-00Gtde-32; Mon, 18 Jul 2022 16:54:04 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDU0O-00GtZG-CF for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 16:54:01 +0000 Received: by mail-wm1-x32f.google.com with SMTP id o8so7512360wms.2 for ; Mon, 18 Jul 2022 09:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PFgEFsfl8rKJs7ra2dHHZoS/sWYcHlxBizMiDuSMBHs=; b=mKTwFX9DcjFSbsWZCVza9QbOzZMgaViFHpyhezP8skfw9OhFHOtxe7Coa9eHKiupWf GVN5yHFqjF5RvR4cUnCT5TeYNNGH16qQTQo1324kdB32i+xK1jhd92eVU0UxcAZ1VJl+ YCFlHbbXFyJy8vOlddVjkGKOTQ/m/QSiyBzHwmTC5yTtRUwcf7Uvc6jPR9g4q/bJhb7J 0l7QCOPJacqQKytb6294d+jLYTpGkqKCr9Rhiqu6KsMCbZfa8rkADp06Jt0BTjfPbpq6 bKh2lRVqkB/XiLnFVspPNZtdu2+PyjKIBF3giMevCtYzSqa8goeqyMShrFPusWEqeYPO hhSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PFgEFsfl8rKJs7ra2dHHZoS/sWYcHlxBizMiDuSMBHs=; b=aC5JWY0vnbo+NdJbb2bpa3u2QrnGkclQ5R8KX8GnbRzrHDROTkfiyERuE0NrJGl7Ye yhw+wvtWmlKDEeFzE9iOdsOI8ldMKDaPkrXDVN/2QuQZl8flHeyxgIK0j2znEU1Up8w5 qhX2NADpUnApT6/bax7afU9UY+/nNFl0X5kOhWzp30cKzyJm017R5QV3ZGGXaE5fLbXU 8Q85jXfEclzXZq+qDIJKKoYT7YlxEH3VXsRE55sqvxKDuj6pG1TMNTINQfpJHwZ42SlX FD+WVFuWUoxzumpB97iQ4OXw6JlcjVNrz5wUVrrnybWB55Gr6KLJu+yECxqdrYYcgLat D2HA== X-Gm-Message-State: AJIora+U+D5W2E+kbrQmk0GHjLYrCNePcvYZ5ZXh8t+6Guqr3MNwH+aj gTNmw/j/A/D8fikVso4D5ftqPAWXqcTjLT3FpL3A4Q== X-Google-Smtp-Source: AGRyM1vVZb4Aon6v5ILgG/Iyd1Sfx4G+07cbbi2sRUeRYV96oOPEBR88UX4fRnJ/EZaOzI28tw0KmqafYPKa3sfBzio= X-Received: by 2002:a05:600c:a146:b0:3a3:1e79:4446 with SMTP id ib6-20020a05600ca14600b003a31e794446mr3231430wmb.158.1658163235828; Mon, 18 Jul 2022 09:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20220715061027.1612149-1-kaleshsingh@google.com> <20220715061027.1612149-7-kaleshsingh@google.com> <87k08c3vtw.wl-maz@kernel.org> In-Reply-To: <87k08c3vtw.wl-maz@kernel.org> From: Kalesh Singh Date: Mon, 18 Jul 2022 09:53:44 -0700 Message-ID: Subject: Re: [PATCH v4 06/18] arm64: stacktrace: Add description of stacktrace/common.h To: Marc Zyngier Cc: Mark Rutland , Mark Brown , "Madhavan T. Venkataraman" , Will Deacon , Quentin Perret , Fuad Tabba , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , andreyknvl@gmail.com, vincenzo.frascino@arm.com, Masami Hiramatsu , Alexei Starovoitov , Andrew Jones , Kefeng Wang , Marco Elver , Keir Fraser , Zenghui Yu , Ard Biesheuvel , Oliver Upton , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , kvmarm , LKML , android-mm@google.com, "Cc: Android Kernel" , "Russell King (Oracle)" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_095400_436221_18131438 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 17, 2022 at 2:58 AM Marc Zyngier wrote: > > On Fri, 15 Jul 2022 07:10:15 +0100, > Kalesh Singh wrote: > > > > Add brief description on how to use stacktrace/common.h to implement > > a stack unwinder. > > > > Signed-off-by: Kalesh Singh > > --- > > arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h > > index f86efe71479d..b362086f4c70 100644 > > --- a/arch/arm64/include/asm/stacktrace/common.h > > +++ b/arch/arm64/include/asm/stacktrace/common.h > > @@ -2,6 +2,14 @@ > > /* > > * Common arm64 stack unwinder code. > > * > > + * To implement a new arm64 stack unwinder: > > + * 1) Include this header > > + * > > + * 2) Provide implementations for the following functions: > > + * - on_overflow_stack() > > + * - on_accessible_stack() > > + * - unwind_next() > > A short description of what these helpers are supposed to do would > also be helpful. Thanks Fuad, Marc. I'll add descriptions in the next version. > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel