From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] bcma: use device from DT (brcm, bus-chipcommon) for SoC GPIO chip
Date: Tue, 30 Sep 2014 12:41:53 +0200 [thread overview]
Message-ID: <CACna6rx8vm3cqws7hqH0yGZnJiteVy9hsCgi8hXZD5oFdyp_FQ@mail.gmail.com> (raw)
In-Reply-To: <3484902.1UVy7lmJAD@wuerfel>
On 30 September 2014 12:36, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 30 September 2014 12:22:26 Rafa? Mi?ecki wrote:
>> @@ -218,6 +218,12 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
>> #if IS_BUILTIN(CONFIG_BCM47XX)
>> chip->to_irq = bcma_gpio_to_irq;
>> #endif
>> +#if IS_BUILTIN(CONFIG_OF)
>> + if (cc->core->bus->hosttype == BCMA_HOSTTYPE_SOC)
>> + chip->of_node = of_find_compatible_node(
>> + bus->host_pdev->dev.of_node, NULL,
>> + "brcm,bus-chipcommon");
>> +#endif
>> switch (cc->core->bus->chipinfo.id) {
>
> This doesn't: you are now searching through all nodes starting at the
> axi node rather than searching just through the children.
>
> I think it would be better with the first change in place to set
> chip->of_node to cc->core->dev.of_node, and set that pointer in
> bcma_bus_scan by matching the 'reg' number. I think that is what
> an earlier version of the bcma DT support did in order to find the
> IRQs. We no longer need it for that purpose, but it seems like a
> good idea anyway, as I expect other bcma_devices to have similar
> requirements to add additional properties.
Ohh, of course, I didn't notice that
[PATCH v6] bcma: register bcma as device tree driver
already contains bcma_of_fill_device. This will simplify my search a lot!
--
Rafa?
next prev parent reply other threads:[~2014-09-30 10:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:28 [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip Rafał Miłecki
2014-09-26 22:03 ` [PATCH] bcma: use device from DT (brcm, bus-gpio) " Arnd Bergmann
2014-09-27 8:05 ` Rafał Miłecki
2014-09-27 8:33 ` [PATCH] bcma: use device from DT (brcm,bus-gpio) " Hauke Mehrtens
2014-09-27 10:37 ` [PATCH] bcma: use device from DT (brcm, bus-gpio) " Rafał Miłecki
2014-09-27 20:47 ` [PATCH] bcma: use device from DT (brcm,bus-gpio) " Hauke Mehrtens
2014-09-28 8:24 ` [PATCH V2] bcma: use device from DT (brcm, bus-gpio) " Rafał Miłecki
2014-09-30 9:37 ` Arnd Bergmann
2014-09-30 9:56 ` Rafał Miłecki
2014-09-30 10:28 ` Arnd Bergmann
2014-09-30 10:22 ` [PATCH V3] bcma: use device from DT (brcm, bus-chipcommon) " Rafał Miłecki
2014-09-30 10:36 ` Arnd Bergmann
2014-09-30 10:41 ` Rafał Miłecki [this message]
2014-09-30 10:55 ` [PATCH V4] bcma: use chipcommon node from DT " Rafał Miłecki
2014-09-30 11:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6rx8vm3cqws7hqH0yGZnJiteVy9hsCgi8hXZD5oFdyp_FQ@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).