linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lacombar@gmail.com (Arnaud Lacombe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Remove remaining references of CONFIG_GENERIC_TIME
Date: Mon, 1 Aug 2011 12:08:08 -0400	[thread overview]
Message-ID: <CACqU3MUoxSNmcYsSF4zOTgADdedb7TcciPuBPMviG02M5oUPDQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ=bqL=VAx5jnSBkE2q5KJSY_+An-VRTRAzJmJ3waQUvrRFFg@mail.gmail.com>

Hi,

On Mon, Aug 1, 2011 at 11:15 AM, Kyle Moffett <kyle@moffetthome.net> wrote:
> On Mon, Aug 1, 2011 at 11:04, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> Hi,
>>
>> On Mon, Aug 1, 2011 at 7:27 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>> On Mon, Aug 1, 2011 at 12:14, Russell King - ARM Linux
>>>>>[...]
>>>>>
>>>>> Doesn't kconf error out when trying to select a non-existent symbol?
>>>>
>>>> Nope.
>>>
>>> You're right. So that's a bug.
>>>
>> depends on what you are trying to achieve and what the problem is.
>>
>> Internally kconfig will create a dummy symbol when it encounter a
>> missing symbol so that arch/arm/Kconfig can reference a symbol which
>> will be fully defined later on. I do not think you want to forward
>> decl all the symbol which can be used. That'd be a mess. That said, we
>> can come with a form of symbol deprecation that would error-out when
>> used.
>
> Would it be possible instead to make Kconfig go through all the symbols
> after everything is processed and identify any remaining "dummy symbols"
> which were not actually declared anywhere?
>
this is software, everything is possible.

> Right now if you typo a "select" statement you get no warnings that you
> are selecting something that does not exist, which is probably a cause
> of many kinds of errors beyond this particular one.
>
d'oh! ... I'm not sure we want that. Dummy symbol are heavily used
internally, a trivial implementation[0] triggered:

% make REGENERATE_PARSERS=y alldefconfig 2>&1 | grep 'defined without
type' | wc -l
817

Moreover, this approach is deemed to fail. The current symbol
namespace is tied to an arch, so whenever you do:

arch/arm/Kconfig:
config FOO
    bool

config BAZ
    bool

drivers/cpufreq/Kconfig
config BAR
    depends on ARM && FOO
    select BAZ

You will end up triggering the warning for every ARCH != ARM...

 - Arnaud

[0]: or rather a fix as we currently only do the check for symbol linked to menu

  reply	other threads:[~2011-08-01 16:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-30 16:14 [PATCH] Remove remaining references of CONFIG_GENERIC_TIME Zoltan Devai
2011-07-30 16:33 ` Sergei Shtylyov
2011-07-30 16:41 ` richard -rw- weinberger
2011-08-01  8:36 ` Russell King - ARM Linux
2011-08-01 10:09   ` Geert Uytterhoeven
2011-08-01 10:14     ` Russell King - ARM Linux
2011-08-01 11:27       ` Geert Uytterhoeven
2011-08-01 14:36         ` Uwe Kleine-König
2011-08-01 15:04         ` Arnaud Lacombe
2011-08-01 15:15           ` Kyle Moffett
2011-08-01 16:08             ` Arnaud Lacombe [this message]
2011-08-01 16:40               ` Nicolas Pitre
2011-08-01 17:20                 ` Arnaud Lacombe
2011-08-01 16:48               ` Kyle Moffett
2011-08-01 17:14                 ` Arnaud Lacombe
2011-08-01 17:15               ` Arnaud Lacombe
2011-08-01 11:41   ` Zoltan Devai
2011-08-01 14:25     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACqU3MUoxSNmcYsSF4zOTgADdedb7TcciPuBPMviG02M5oUPDQ@mail.gmail.com \
    --to=lacombar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).