From: grant.likely@linaro.org (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dt: fix up PL011 device tree bindings
Date: Thu, 27 Nov 2014 14:00:45 +0000 [thread overview]
Message-ID: <CACxGe6sERSvB4atoZ6taKAFhqerJrypsasamYWwqCwuNJb7yeQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbQYSo0pQxPDXEPw-yMm8pA0oCnYJa2+v==pAgKWax5UA@mail.gmail.com>
On Thu, Nov 27, 2014 at 1:40 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, May 12, 2014 at 11:37 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>
>> Make the map match the reality, the current binding text is
>> nonsense:
>>
>> - The clock required for the clocking of the serial port
>> must come first and is not optional (as the driver will
>> otherwise proceed to grab and use the apb_pclk as uartclk),
>> and the apb_pclk that clocks the logic must come second
>> as the code will retrieve the first clock by index,
>> whereas the PrimeCell but will explicitly look for
>> "apb_pclk" so this can be specified later, as it is
>> looked up by name.
>>
>> - The pin control state "default" is the only mandated
>> state, the sleep state is entirely optional.
>>
>> We also add an example to avoid further confusion.
>>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> ChangeLog v1->v2:
>> - Rename amba_pclk to apb_pclk
>> - Split clock/clocks properties and indicate that listin one
>> clock only is deprecated
>
> PING on this, 6 months and the bindings still look like hell.
>
> Greg can you pick this up through the serial tree?
>
> I can resend the patch if you don't have it...
Ugh, sorry. I'll merge it in my tree right now.
g.
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2014-11-27 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 9:37 [PATCH v2] ARM: dt: fix up PL011 device tree bindings Linus Walleij
2014-05-12 10:48 ` Mark Rutland
2014-09-08 11:31 ` Linus Walleij
2014-11-27 13:40 ` Linus Walleij
2014-11-27 14:00 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACxGe6sERSvB4atoZ6taKAFhqerJrypsasamYWwqCwuNJb7yeQ@mail.gmail.com \
--to=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).